* [PATCH] tune-cortexa72-cortexa53: Add tune
@ 2019-12-13 22:03 Joshua Watt
2019-12-13 22:05 ` Mark Hatle
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-13 22:03 UTC (permalink / raw)
To: openembedded-core
Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
RK3399
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
.../include/tune-cortexa72-cortexa53.inc | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
new file mode 100644
index 00000000000..30e49d20769
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
@@ -0,0 +1,18 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
--
2.23.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-13 22:03 [PATCH] tune-cortexa72-cortexa53: Add tune Joshua Watt
@ 2019-12-13 22:05 ` Mark Hatle
2019-12-13 22:08 ` Joshua Watt
2019-12-13 23:10 ` Adrian Bunk
2019-12-14 0:54 ` [PATCH v2] tune-cortexa72-cortexa53: Add tunes Joshua Watt
2 siblings, 1 reply; 13+ messages in thread
From: Mark Hatle @ 2019-12-13 22:05 UTC (permalink / raw)
To: openembedded-core
On 12/13/19 4:03 PM, Joshua Watt wrote:
> Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> RK3399
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> .../include/tune-cortexa72-cortexa53.inc | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> new file mode 100644
> index 00000000000..30e49d20769
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> @@ -0,0 +1,18 @@
> +DEFAULTTUNE ?= "cortexa72-cortexa53"
> +require conf/machine/include/arm/arch-armv8a.inc
> +
> +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
> +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> +
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
> +
> +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> +
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> +
> +# Little Endian base configs
> +AVAILTUNES += "cortexa72-cortexa53"
> +ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
I'm wondering if the pkgarch should be shorter.. This really does make package
names very long. (I don't know offhand if that is an actual problem or not.)
Also a similar tune has been used by NXP and Wind River. So hopefully we don't
end up with conflicts.
--Mark
> +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
> +BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-13 22:05 ` Mark Hatle
@ 2019-12-13 22:08 ` Joshua Watt
0 siblings, 0 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-13 22:08 UTC (permalink / raw)
To: Mark Hatle; +Cc: OE-core
On Fri, Dec 13, 2019 at 4:05 PM Mark Hatle
<mark.hatle@kernel.crashing.org> wrote:
>
>
>
> On 12/13/19 4:03 PM, Joshua Watt wrote:
> > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> > RK3399
> >
> > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> > ---
> > .../include/tune-cortexa72-cortexa53.inc | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> >
> > diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > new file mode 100644
> > index 00000000000..30e49d20769
> > --- /dev/null
> > +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > @@ -0,0 +1,18 @@
> > +DEFAULTTUNE ?= "cortexa72-cortexa53"
> > +require conf/machine/include/arm/arch-armv8a.inc
> > +
> > +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
> > +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> > +
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
> > +
> > +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> > +
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> > +
> > +# Little Endian base configs
> > +AVAILTUNES += "cortexa72-cortexa53"
> > +ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
>
> I'm wondering if the pkgarch should be shorter.. This really does make package
> names very long. (I don't know offhand if that is an actual problem or not.)
I chose this name because there is already a
tune-cortexa57-cortexa53.inc, so the consistency is nice.
>
> Also a similar tune has been used by NXP and Wind River. So hopefully we don't
> end up with conflicts.
>
> --Mark
>
> > +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
> > +BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-13 22:03 [PATCH] tune-cortexa72-cortexa53: Add tune Joshua Watt
2019-12-13 22:05 ` Mark Hatle
@ 2019-12-13 23:10 ` Adrian Bunk
2019-12-14 0:47 ` Joshua Watt
2019-12-14 0:54 ` [PATCH v2] tune-cortexa72-cortexa53: Add tunes Joshua Watt
2 siblings, 1 reply; 13+ messages in thread
From: Adrian Bunk @ 2019-12-13 23:10 UTC (permalink / raw)
To: Joshua Watt; +Cc: openembedded-core
On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> RK3399
>...
> +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
>...
Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,
so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
The RK3399 implements the optional crypto extensions,
it needs a TUNE_FEATURES_tune-cortexa72-cortexa53-crypto.
cu
Adrian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-13 23:10 ` Adrian Bunk
@ 2019-12-14 0:47 ` Joshua Watt
2019-12-14 1:22 ` Adrian Bunk
0 siblings, 1 reply; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 0:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: OE-core
On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> > RK3399
> >...
> > +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> >...
>
> Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,
> so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
I think that's armv8.1-a, the cortex A72 is only armv8-a (at least
AFAICT), so I think crc would still be an optional feature.
>
> The RK3399 implements the optional crypto extensions,
> it needs a TUNE_FEATURES_tune-cortexa72-cortexa53-crypto.
Ok, I've rewritten the patch to more closely align with the
arch-armv8a.inc tune file, which looks a lot cleaner.
>
> cu
> Adrian
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] tune-cortexa72-cortexa53: Add tunes
2019-12-13 22:03 [PATCH] tune-cortexa72-cortexa53: Add tune Joshua Watt
2019-12-13 22:05 ` Mark Hatle
2019-12-13 23:10 ` Adrian Bunk
@ 2019-12-14 0:54 ` Joshua Watt
2019-12-14 1:21 ` Andre McCurdy
2019-12-14 16:06 ` [PATCH v3] " Joshua Watt
2 siblings, 2 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 0:54 UTC (permalink / raw)
To: openembedded-core; +Cc: bunk
Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without
crypto extensions), e.g. Rockchip RK3399
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
.../include/tune-cortexa72-cortexa53.inc | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
new file mode 100644
index 00000000000..6bf3b83abe9
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-armv8a}"
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crypto}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto = "lib64"
+
--
2.23.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] tune-cortexa72-cortexa53: Add tunes
2019-12-14 0:54 ` [PATCH v2] tune-cortexa72-cortexa53: Add tunes Joshua Watt
@ 2019-12-14 1:21 ` Andre McCurdy
2019-12-14 1:29 ` Joshua Watt
2019-12-14 16:06 ` [PATCH v3] " Joshua Watt
1 sibling, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2019-12-14 1:21 UTC (permalink / raw)
To: Joshua Watt; +Cc: Adrian Bunk, OE Core mailing list
On Fri, Dec 13, 2019 at 4:55 PM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without
> crypto extensions), e.g. Rockchip RK3399
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> .../include/tune-cortexa72-cortexa53.inc | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
>
> diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> new file mode 100644
> index 00000000000..6bf3b83abe9
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> @@ -0,0 +1,24 @@
> +DEFAULTTUNE ?= "cortexa72-cortexa53"
> +
> +require conf/machine/include/arm/arch-armv8a.inc
> +
> +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
> +
> +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> +
> +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> +
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> +
> +# Little Endian base configs
> +AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
> +ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
> +ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53"
> +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-armv8a}"
> +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crypto}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"
Shouldn't cortexa72-cortexa53-crypto also be able to use
cortexa72-cortexa53 packages?
> +BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
> +BASE_LIB_tune-cortexa72-cortexa53-crypto = "lib64"
> +
> --
> 2.23.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-14 0:47 ` Joshua Watt
@ 2019-12-14 1:22 ` Adrian Bunk
2019-12-14 1:28 ` Joshua Watt
0 siblings, 1 reply; 13+ messages in thread
From: Adrian Bunk @ 2019-12-14 1:22 UTC (permalink / raw)
To: Joshua Watt; +Cc: OE-core
On Fri, Dec 13, 2019 at 06:47:33PM -0600, Joshua Watt wrote:
> On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> > > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> > > RK3399
> > >...
> > > +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> > >...
> >
> > Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,
> > so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
>
> I think that's armv8.1-a, the cortex A72 is only armv8-a (at least
> AFAICT), so I think crc would still be an optional feature.
>...
It is optional for armv8-a, but not for Cortex A53 or A72.
What matters in practice is that gcc automatically enables it for
cortex-a72.cortex-a53, so the resulting code might not run on
armv8-a hardware without support for crc - things will break
if the tune features are not 100% aligned with whatever gcc
is doing.
cu
Adrian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-14 1:22 ` Adrian Bunk
@ 2019-12-14 1:28 ` Joshua Watt
2019-12-14 1:41 ` Adrian Bunk
0 siblings, 1 reply; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 1:28 UTC (permalink / raw)
To: Adrian Bunk; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
On Fri, Dec 13, 2019, 7:22 PM Adrian Bunk <bunk@stusta.de> wrote:
> On Fri, Dec 13, 2019 at 06:47:33PM -0600, Joshua Watt wrote:
> > On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> > > > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> > > > RK3399
> > > >...
> > > > +TUNE_FEATURES_tune-cortexa72-cortexa53 =
> "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> > > >...
> > >
> > > Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,
> > > so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
> >
> > I think that's armv8.1-a, the cortex A72 is only armv8-a (at least
> > AFAICT), so I think crc would still be an optional feature.
> >...
>
> It is optional for armv8-a, but not for Cortex A53 or A72.
>
> What matters in practice is that gcc automatically enables it for
> cortex-a72.cortex-a53, so the resulting code might not run on
> armv8-a hardware without support for crc - things will break
> if the tune features are not 100% aligned with whatever gcc
> is doing.
>
I agree, but I can't find anywhere that says crc is enabled by default when
the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?
Thanks
> cu
> Adrian
>
[-- Attachment #2: Type: text/html, Size: 2196 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] tune-cortexa72-cortexa53: Add tunes
2019-12-14 1:21 ` Andre McCurdy
@ 2019-12-14 1:29 ` Joshua Watt
0 siblings, 0 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 1:29 UTC (permalink / raw)
To: Andre McCurdy; +Cc: Adrian Bunk, OE Core mailing list
[-- Attachment #1: Type: text/plain, Size: 2848 bytes --]
On Fri, Dec 13, 2019, 7:21 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> On Fri, Dec 13, 2019 at 4:55 PM Joshua Watt <jpewhacker@gmail.com> wrote:
> >
> > Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without
> > crypto extensions), e.g. Rockchip RK3399
> >
> > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> > ---
> > .../include/tune-cortexa72-cortexa53.inc | 24 +++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> > create mode 100644
> meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> >
> > diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > new file mode 100644
> > index 00000000000..6bf3b83abe9
> > --- /dev/null
> > +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > @@ -0,0 +1,24 @@
> > +DEFAULTTUNE ?= "cortexa72-cortexa53"
> > +
> > +require conf/machine/include/arm/arch-armv8a.inc
> > +
> > +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE
> Cortex-A72.Cortex-A53 specific processor optimizations"
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", "
> -march=armv8-a", "" ,d)}"
>
I also think this is redundant because arch-armv8a.inc does it already
> +
> > +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> > +
> > +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES",
> "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> > +
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES",
> "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> > +
> > +# Little Endian base configs
> > +AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
> > +ARMPKGARCH_tune-cortexa72-cortexa53 =
> "cortexa72-cortexa53"
> > +ARMPKGARCH_tune-cortexa72-cortexa53-crypto =
> "cortexa72-cortexa53"
> > +TUNE_FEATURES_tune-cortexa72-cortexa53 =
> "${TUNE_FEATURES_tune-armv8a}"
> > +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto =
> "${TUNE_FEATURES_tune-armv8a-crypto}"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"
>
> Shouldn't cortexa72-cortexa53-crypto also be able to use
> cortexa72-cortexa53 packages?
>
Yep. I'll send a v3
> > +BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
> > +BASE_LIB_tune-cortexa72-cortexa53-crypto = "lib64"
> > +
> > --
> > 2.23.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 4597 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-14 1:28 ` Joshua Watt
@ 2019-12-14 1:41 ` Adrian Bunk
2019-12-14 1:48 ` Joshua Watt
0 siblings, 1 reply; 13+ messages in thread
From: Adrian Bunk @ 2019-12-14 1:41 UTC (permalink / raw)
To: Joshua Watt; +Cc: OE-core
On Fri, Dec 13, 2019 at 07:28:28PM -0600, Joshua Watt wrote:
> On Fri, Dec 13, 2019, 7:22 PM Adrian Bunk <bunk@stusta.de> wrote:
>
> > On Fri, Dec 13, 2019 at 06:47:33PM -0600, Joshua Watt wrote:
> > > On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <bunk@stusta.de> wrote:
> > > >
> > > > On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> > > > > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
> > > > > RK3399
> > > > >...
> > > > > +TUNE_FEATURES_tune-cortexa72-cortexa53 =
> > "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> > > > >...
> > > >
> > > > Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,
> > > > so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
> > >
> > > I think that's armv8.1-a, the cortex A72 is only armv8-a (at least
> > > AFAICT), so I think crc would still be an optional feature.
> > >...
> >
> > It is optional for armv8-a, but not for Cortex A53 or A72.
> >
> > What matters in practice is that gcc automatically enables it for
> > cortex-a72.cortex-a53, so the resulting code might not run on
> > armv8-a hardware without support for crc - things will break
> > if the tune features are not 100% aligned with whatever gcc
> > is doing.
>
> I agree, but I can't find anywhere that says crc is enabled by default when
> the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arm/arm-cpus.in#L1278
> Thanks
cu
Adrian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] tune-cortexa72-cortexa53: Add tune
2019-12-14 1:41 ` Adrian Bunk
@ 2019-12-14 1:48 ` Joshua Watt
0 siblings, 0 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 1:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]
On Fri, Dec 13, 2019, 7:41 PM Adrian Bunk <bunk@stusta.de> wrote:
> On Fri, Dec 13, 2019 at 07:28:28PM -0600, Joshua Watt wrote:
> > On Fri, Dec 13, 2019, 7:22 PM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > On Fri, Dec 13, 2019 at 06:47:33PM -0600, Joshua Watt wrote:
> > > > On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <bunk@stusta.de> wrote:
> > > > >
> > > > > On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:
> > > > > > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g.
> Rockchip
> > > > > > RK3399
> > > > > >...
> > > > > > +TUNE_FEATURES_tune-cortexa72-cortexa53 =
> > > "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> > > > > >...
> > > > >
> > > > > Looking at the gcc sources cortexa72-cortexa53 defaults to crc
> enabled,
> > > > > so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.
> > > >
> > > > I think that's armv8.1-a, the cortex A72 is only armv8-a (at least
> > > > AFAICT), so I think crc would still be an optional feature.
> > > >...
> > >
> > > It is optional for armv8-a, but not for Cortex A53 or A72.
> > >
> > > What matters in practice is that gcc automatically enables it for
> > > cortex-a72.cortex-a53, so the resulting code might not run on
> > > armv8-a hardware without support for crc - things will break
> > > if the tune features are not 100% aligned with whatever gcc
> > > is doing.
> >
> > I agree, but I can't find anywhere that says crc is enabled by default
> when
> > the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?
>
>
> https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arm/arm-cpus.in#L1278
Excellent. I'll send v3.
Thanks for the help
>
>
>
> > Thanks
>
> cu
> Adrian
>
[-- Attachment #2: Type: text/html, Size: 2938 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3] tune-cortexa72-cortexa53: Add tunes
2019-12-14 0:54 ` [PATCH v2] tune-cortexa72-cortexa53: Add tunes Joshua Watt
2019-12-14 1:21 ` Andre McCurdy
@ 2019-12-14 16:06 ` Joshua Watt
1 sibling, 0 replies; 13+ messages in thread
From: Joshua Watt @ 2019-12-14 16:06 UTC (permalink / raw)
To: openembedded-core; +Cc: bunk
Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without
crypto extensions), e.g. Rockchip RK3399
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
.../include/tune-cortexa72-cortexa53.inc | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
new file mode 100644
index 00000000000..0d43531be70
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
@@ -0,0 +1,23 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# cortexa72.cortexa53 implies crc support
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-armv8a-crc}"
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crc-crypto}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto = "lib64"
+
--
2.23.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-12-14 16:07 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 22:03 [PATCH] tune-cortexa72-cortexa53: Add tune Joshua Watt
2019-12-13 22:05 ` Mark Hatle
2019-12-13 22:08 ` Joshua Watt
2019-12-13 23:10 ` Adrian Bunk
2019-12-14 0:47 ` Joshua Watt
2019-12-14 1:22 ` Adrian Bunk
2019-12-14 1:28 ` Joshua Watt
2019-12-14 1:41 ` Adrian Bunk
2019-12-14 1:48 ` Joshua Watt
2019-12-14 0:54 ` [PATCH v2] tune-cortexa72-cortexa53: Add tunes Joshua Watt
2019-12-14 1:21 ` Andre McCurdy
2019-12-14 1:29 ` Joshua Watt
2019-12-14 16:06 ` [PATCH v3] " Joshua Watt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.