From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 155F1E00C59; Wed, 16 Jan 2019 05:13:07 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (jpewhacker[at]gmail.com) * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.128.43 listed in list.dnswl.org] * 0.0 HTML_MESSAGE BODY: HTML included in message * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 948C0E00C29 for ; Wed, 16 Jan 2019 05:13:05 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id t200so1963235wmt.0 for ; Wed, 16 Jan 2019 05:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mmkkWf8a+aqGXnCHU0JgiivV77hNtOEtlW13Yx9J+xw=; b=t2mKVUbjqGbJpXXX93yQ4EpMpg27AW/65CsoM0NqadKMVqfvu84G/nZ6zsry2hPfZm /CXoc3bhyxNtFh2RF0x4mO9RB/ETmQfW0ytGoU6UiAtPH2UBXz8bSr6uW6SpYF9Rfj5M ylRz0QpyCXiwe4YbtfX2Pedb1JnFie7C+UoCIn2ffxh+lupFyFLKgDOyI8MYQwCrUVK3 oxYHm42T1lsCA13Wh8SQ1KCG6zurSrqh1nugedvIawT2jCePJ0dTwWW/jesyWsezaKwL 5bF/tBJFLA1S81e5JxKpSv8WTqMPMYiPNuKOo+5uq1ZoWn/Z7D4GeqWfNhLZPe4Sri9t Nv2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mmkkWf8a+aqGXnCHU0JgiivV77hNtOEtlW13Yx9J+xw=; b=KYLPCn/MW748cLJrc+z3jQ9AvtVxixco0SxsKDC1YzlR5HfMEheYDEvj3N5u/EPwVC 0NKvGp5U15x2YPkR/9+jrwKFoV3Zuu7ngzN3EpbZ86z8g0Z92U6/wSMUGFRjdZSIuJWs cZCM+btySlat4lwYYzX841vNDBXkjV0ZgrDIrSvHg6d8X20LWOfqzh672ZS4IAFVVE/L aPFFSf99fZ10wUmBe8ywwSvlPY1IkP6224vvTL2uCQ9+gJ3/nwXa7W6Lw9AbIrOmr/Ec F6gErooj1J4TydmI2MmLVPQACNzQ3COXI/DRgRo098xPrw/Pb8thKE7xbqHybaeBcQ9Y hITg== X-Gm-Message-State: AJcUukfRLHR4wEhqLorcfvYkm2UIZUQGCLbK24ECX3e+po+0g8sGXNs6 XF1FDDpba1lMIgDrt0P8I/bvsNTiyMXEYCdwLV8= X-Google-Smtp-Source: ALg8bN7e/1pEqFQfd+hhAueRSX8BdQeKT5IA1nti6pxlBVw9xLZvdxZ4rDTgRSBEOiB/l+uPmrcWr4K00oK3ni4EH8I= X-Received: by 2002:a1c:9806:: with SMTP id a6mr7453888wme.114.1547644384409; Wed, 16 Jan 2019 05:13:04 -0800 (PST) MIME-Version: 1.0 References: <1547631395-435805-1-git-send-email-changqing.li@windriver.com> In-Reply-To: <1547631395-435805-1-git-send-email-changqing.li@windriver.com> From: Joshua Watt Date: Wed, 16 Jan 2019 07:12:52 -0600 Message-ID: To: changqing.li@windriver.com Cc: Yocto list discussion Subject: Re: [meta-mingw][PATCH] mingw32-common: change mingw sdk to .zip type X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 13:13:07 -0000 Content-Type: multipart/alternative; boundary="000000000000c58001057f930902" --000000000000c58001057f930902 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 16, 2019, 3:37 AM From: Changqing Li > > Current sdk type is tar.xz, but for mingw sdk, since we > have symlink under the sdk folder, 7zip which used to > extract tar.xz cannot handle it, refer 7zip upstream bug: > https://sourceforge.net/p/sevenzip/discussion/45797/thread/c71d6b96/ > so change to .zip type > > Also tried to use option --dereference of tar which use means: > "follow symlinks; archive and dump the files they point to" > with this option, when archive it will deal with symlink to hard link, > but windows not support hard link, so drop this solution, > and use .zip for windows. > > Signed-off-by: Changqing Li > --- > conf/machine-sdk/include/mingw32-common.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/conf/machine-sdk/include/mingw32-common.inc > b/conf/machine-sdk/include/mingw32-common.inc > index 9011ded..dbad50a 100644 > --- a/conf/machine-sdk/include/mingw32-common.inc > +++ b/conf/machine-sdk/include/mingw32-common.inc > @@ -46,3 +46,8 @@ GCCPIE_mingw32 = "" > # wine and wineserver are required to test MinGW SDKs > HOSTTOOLS += "${@'wine wineserver' if > (bb.utils.contains_any('IMAGE_CLASSES', 'testsdk', True, False, d) or any(x > in (d.getVar("BBINCLUDED") or "") for x in ["testsdk.bbclass"])) else ''}" > > +# mingw sdk use .zip type > +SDK_TAR_TYPE = "zip" > +SDK_TAR_DEPENDS = "zip-native" > +SDK_TAR_CMD ?= "zip -r > ${SDKDEPLOYDIR}/${TOOLCHAIN_OUTPUTNAME}.${SDK_TAR_TYPE} ." > + > You will also need to update the QA tests, since right now they expecting a tar file (lib/oeqa/sdkmingw/testsdk.py) -- 2.7.4 > > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto > --000000000000c58001057f930902 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Wed, Jan 16, 2019, 3:37 AM <changqing.li@windriver.com wrote:
From: Changqing Li <changqing.li@windriver.com><= br>
Current sdk type is tar.xz, but for mingw sdk, since we
have symlink under the sdk folder, 7zip which used to
extract tar.xz cannot handle it, refer 7zip upstream bug:
https://sourceforge.n= et/p/sevenzip/discussion/45797/thread/c71d6b96/
so change to .zip type

Also tried to use option --dereference of tar which use means:
"follow symlinks; archive and dump the files they point to"
with this option, when archive it will deal with symlink to hard link,
but windows not support hard link, so drop this solution,
and use .zip for windows.

Signed-off-by: Changqing Li <changqing.li@windriver.com><= br> ---
=C2=A0conf/machine-sdk/include/mingw32-common.inc | 5 +++++
=C2=A01 file changed, 5 insertions(+)

diff --git a/conf/machine-sdk/include/mingw32-common.inc b/conf/machine-sdk= /include/mingw32-common.inc
index 9011ded..dbad50a 100644
--- a/conf/machine-sdk/include/mingw32-common.inc
+++ b/conf/machine-sdk/include/mingw32-common.inc
@@ -46,3 +46,8 @@ GCCPIE_mingw32 =3D ""
=C2=A0# wine and wineserver are required to test MinGW SDKs
=C2=A0HOSTTOOLS +=3D "${@'wine wineserver' if (bb.utils.contai= ns_any('IMAGE_CLASSES', 'testsdk', True, False, d) or any(x= in (d.getVar("BBINCLUDED") or "") for x in ["test= sdk.bbclass"])) else ''}"

+# mingw sdk use .zip type
+SDK_TAR_TYPE =3D "zip"
+SDK_TAR_DEPENDS =3D "zip-native"
+SDK_TAR_CMD ?=3D "zip -r=C2=A0 ${SDKDEPLOYDIR}/${TOOLCHAIN_OUTPUTNAME= }.${SDK_TAR_TYPE} ."
+

You will also need to update the QA tests, since right now they expecting = a tar file (lib/oeqa/sdkmingw/testsdk.py)

=
--
2.7.4

--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yoct= o
--000000000000c58001057f930902--