Hello,

On Wed, 27 Jul 2022 21:29:48 +0200
"Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote:

> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> [Arnout:
>  - Indent hash file with two spaces.
>  - Bump to 1.7.3 to fix build failure with recent GCC.
>  - Get from github instead of PyPI.
>  - Add host-meson and host-python-pythran dependencies.
>  - Properly propagate Config.in dependencies.
>  - Correct usage of BR2_INSTALL_LIBSTDCPP symbol.
>  - Remove F77, no longer used.
> ]
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> [Guillaume:
>  - -lnpymath: npymath.ini localization problem
>  - -lnpyrandom resolution problem
>  - fix legal-info for latest version LICENSE.txt
>  - zlib is a scipy::io module runtime requirement
>  - update serie for scipy 1.8.1 (latest)
> ]
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>

I have applied, with the following changes:

    [Thomas:
     - add runtime test
     - drop dependency on OpenBLAS, which is not needed in a minimal
       configuration
     - remove PYTHON_SCIPY_NPY_PKG_CONFIG_PATH logic as it is no longer
       needed
    ]

Could you please:

 (1) Review the runtime test, to see if it can be improved with some
     better testing.

 (2) Review the OpenBLAS dependency, to see if it needs to be added as
     an optional dependency in some way.

> +# Provide system configuration options to numpy distutils extenions, telling
> +# to find all include files and libraries in staging directory.
> +define PYTHON_SCIPY_CONFIGURE_CMDS
> +     -rm -f $(@D)/site.cfg
> +     echo "[DEFAULT]" >> $(@D)/site.cfg
> +     echo "library_dirs = $(STAGING_DIR)/usr/lib" >> $(@D)/site.cfg
> +     echo "include_dirs = $(STAGING_DIR)/usr/include" >> $(@D)/site.cfg
> +endef

This part is a bit annoying, as it's duplicated from python-numpy.mk. I
looked a bit, but couldn't really find a good way of avoiding this
duplication.

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com