From: Jassi Brar <jaswinder.singh@linaro.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
rmk@arm.linux.org.uk, 21cnbao@gmail.com
Subject: Re: [PATCHv3] DMAEngine: Define interleaved transfer request api
Date: Wed, 21 Sep 2011 12:15:42 +0530 [thread overview]
Message-ID: <CAJe_Zhc67VR-+YAYaLhbwOF=eo2s7wOkjwvi+kJ5=bGt-YWmqA@mail.gmail.com> (raw)
In-Reply-To: <1316586723.1573.4.camel@vkoul-udesk3>
On 21 September 2011 12:02, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, 2011-09-20 at 23:38 +0530, Jassi Brar wrote:
>> On 20 September 2011 22:22, Vinod Koul <vinod.koul@intel.com> wrote:
>> > Also for slave transfers, how do we infer direction?
>> I already explained to Barry. Here's it again.
>>
>> At any time, the dmac driver knows if the channel, on which the xfer is
>> prepared/submitted is Slave or not.
>>
>> SLAVE Transfer
>> dmaxfer_template.src_inc && !dmaxfer_template.dst_inc => DMA_TO_DEVICE
>> !dmaxfer_template.src_inc && dmaxfer_template.dst_inc => DMA_FROM_DEVICE
>>
>> Mem->Mem Transfer
>> dmaxfer_template.src_inc && !dmaxfer_template.dst_inc => Meaningless
>> !dmaxfer_template.src_inc && dmaxfer_template.dst_inc => MemSet
> Rather than each driver adding this logic with good chance of screwing
> up, care to add this as helper in dmaengine.h
>
> Ideally, I would have preferred direction to be told explicitly, would
> leave it you..
>
I repeat yet again :- "This api is common to Slave as well as Mem<->Mem"
Even if we have slave clients specify DMA_TO/FROM_DEVICE, what
flag do you suggest Mem->Mem clients use ?
next prev parent reply other threads:[~2011-09-21 6:45 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 11:14 [PATCH] DMAEngine: Define generic transfer request api Jassi Brar
2011-08-16 12:56 ` Koul, Vinod
2011-08-16 13:06 ` Linus Walleij
2011-08-19 13:43 ` Koul, Vinod
2011-08-19 14:19 ` Linus Walleij
2011-08-19 15:46 ` Jassi Brar
2011-08-19 17:28 ` Koul, Vinod
2011-08-19 18:45 ` Jassi Brar
2011-08-23 14:43 ` Matt Porter
2011-08-23 14:43 ` Matt Porter
2011-08-16 14:32 ` Jassi Brar
2011-09-15 7:46 ` [PATCHv2] " Jassi Brar
2011-09-15 8:22 ` Russell King
2011-09-15 10:02 ` Jassi Brar
2011-09-16 7:17 ` Barry Song
2011-09-16 11:03 ` Jassi Brar
2011-09-16 9:07 ` Vinod Koul
2011-09-16 12:30 ` Jassi Brar
2011-09-16 17:06 ` Vinod Koul
2011-09-16 17:51 ` Jassi Brar
2011-09-19 3:23 ` Vinod Koul
2011-09-20 12:12 ` [PATCHv3] DMAEngine: Define interleaved " Jassi Brar
2011-09-20 16:52 ` Vinod Koul
2011-09-20 18:08 ` Jassi Brar
2011-09-21 6:32 ` Vinod Koul
2011-09-21 6:45 ` Jassi Brar [this message]
2011-09-21 6:51 ` Vinod Koul
2011-09-21 7:31 ` Jassi Brar
2011-09-21 10:18 ` Russell King
2011-09-21 15:21 ` Jassi Brar
2011-09-28 6:39 ` [PATCHv4] " Jassi Brar
2011-09-28 9:03 ` Vinod Koul
2011-09-28 15:15 ` Jassi Brar
2011-09-29 11:17 ` Vinod Koul
2011-09-30 6:43 ` Barry Song
2011-09-30 16:01 ` Jassi Brar
2011-10-01 3:05 ` Barry Song
2011-10-01 18:11 ` Vinod Koul
2011-10-01 18:45 ` Jassi Brar
2011-10-01 18:41 ` Jassi Brar
2011-10-01 18:48 ` Jassi Brar
2011-10-02 0:33 ` Barry Song
2011-10-03 6:24 ` Jassi Brar
2011-10-03 16:13 ` Russell King
2011-10-03 16:19 ` Jassi Brar
2011-10-03 17:15 ` Williams, Dan J
2011-10-03 18:23 ` Jassi Brar
2011-10-05 18:19 ` Williams, Dan J
2011-10-06 9:06 ` Jassi Brar
2011-10-05 18:14 ` Williams, Dan J
2011-10-06 7:12 ` Jassi Brar
2011-10-07 5:45 ` Vinod Koul
2011-10-07 11:27 ` Jassi Brar
2011-10-07 14:19 ` Vinod Koul
2011-10-07 14:38 ` Jassi Brar
2011-10-10 6:53 ` Vinod Koul
2011-10-10 9:16 ` Jassi Brar
2011-10-10 9:18 ` Vinod Koul
2011-10-10 9:53 ` Jassi Brar
2011-10-10 10:45 ` Vinod Koul
2011-10-10 11:16 ` Jassi Brar
2011-10-10 16:02 ` Vinod Koul
2011-10-10 16:28 ` Jassi Brar
2011-10-11 11:56 ` Vinod Koul
2011-10-11 15:57 ` Jassi Brar
2011-10-11 16:45 ` Vinod Koul
2011-10-12 5:41 ` Barry Song
2011-10-12 6:19 ` Vinod Koul
2011-10-12 6:30 ` Jassi Brar
2011-10-12 6:53 ` Barry Song
2011-10-11 16:44 ` Williams, Dan J
2011-10-11 18:42 ` Jassi Brar
2011-10-14 18:11 ` Bounine, Alexandre
2011-10-14 17:50 ` Bounine, Alexandre
2011-10-14 18:36 ` Jassi Brar
2011-10-14 19:15 ` Bounine, Alexandre
2011-10-15 11:25 ` Jassi Brar
2011-10-17 14:07 ` Bounine, Alexandre
2011-10-17 15:16 ` Jassi Brar
2011-10-17 18:00 ` Bounine, Alexandre
2011-10-17 19:29 ` Jassi Brar
2011-10-17 21:07 ` Bounine, Alexandre
2011-10-18 5:45 ` Jassi Brar
2011-10-18 7:42 ` Russell King
2011-10-18 8:30 ` Jassi Brar
2011-10-18 8:26 ` Vinod Koul
2011-10-18 8:37 ` Jassi Brar
2011-10-18 14:44 ` Bounine, Alexandre
2011-10-18 9:49 ` Russell King
2011-10-18 11:50 ` Jassi Brar
2011-10-18 11:59 ` Russell King
2011-10-18 17:57 ` Bounine, Alexandre
2011-10-24 3:49 ` Vinod Koul
2011-10-24 12:36 ` Bounine, Alexandre
2011-10-24 15:27 ` Vinod Koul
2011-10-18 17:26 ` Bounine, Alexandre
2011-10-18 17:35 ` Russell King
2011-10-18 17:53 ` Jassi Brar
2011-10-18 13:51 ` Bounine, Alexandre
2011-10-18 14:54 ` Jassi Brar
2011-10-18 15:15 ` Bounine, Alexandre
2011-09-30 15:47 ` Jassi Brar
2011-10-13 7:03 ` [PATCHv5] " Jassi Brar
2011-10-14 7:32 ` Barry Song
2011-10-14 11:51 ` Jassi Brar
2011-10-14 13:31 ` Vinod Koul
2011-10-14 13:51 ` Jassi Brar
2011-10-14 14:05 ` Vinod Koul
2011-10-14 14:18 ` Vinod Koul
2011-10-14 14:55 ` Barry Song
2011-10-14 15:06 ` Vinod Koul
2011-10-14 15:38 ` Barry Song
2011-10-14 16:09 ` Vinod Koul
2011-10-14 16:35 ` Jassi Brar
2011-10-14 17:04 ` Vinod Koul
2011-10-14 17:59 ` Jassi Brar
2011-10-15 17:11 ` Vinod Koul
2011-10-14 15:16 ` Vinod Koul
2011-10-14 15:50 ` Barry Song
2011-10-16 11:16 ` Jassi Brar
2011-10-16 12:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJe_Zhc67VR-+YAYaLhbwOF=eo2s7wOkjwvi+kJ5=bGt-YWmqA@mail.gmail.com' \
--to=jaswinder.singh@linaro.org \
--cc=21cnbao@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.