From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F7A5C433EF for ; Fri, 22 Jul 2022 03:39:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 801AE82105; Fri, 22 Jul 2022 05:39:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="u7XkPTqr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 34D2A82DA1; Fri, 22 Jul 2022 05:39:45 +0200 (CEST) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 74D3781877 for ; Fri, 22 Jul 2022 05:39:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jaswinder.singh@linaro.org Received: by mail-pj1-x1029.google.com with SMTP id ku18so3322183pjb.2 for ; Thu, 21 Jul 2022 20:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=862rc5FLrX3BdA09kOG5ntVsE25JpzVdifop0Lv7Gco=; b=u7XkPTqrncrmMPEkd9nNRve5IoXiRbV6z8yFQ5RojKmPCL6gfmrvpCeS6INSG4N90Y Bqz2wbs5xTvJhnS5mJoo3xiN1P7HawWfPcs6DQ/ZNkfPkL0nCzFesshqIeUasRh7+kzi ZALEFOiA6c6HU8wejLfRyyuT+KQbR/XP13K/r/yAREwaTQNbnQFDnD3x9gxoJ3tWOgnW Ny0Ebmjb+kq41vzxPe1Klkc3++ivdvS74P/vvTaekq7xoyUeRfmm13ocHUEY40SYj57h vrTeA7w4uoOYzKtEUQOScBRKLRPRoXTlwJvAKqhBecz0W/fFPgI4tvMbbBS6h0e37H9E YzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=862rc5FLrX3BdA09kOG5ntVsE25JpzVdifop0Lv7Gco=; b=7h1G9JzlYqRUTmV2QOEUjMgyKIHOOA1fKVlwPtco/1rMV5VMyCQIZ+nSy+t9emZFxb xMYrCxa/X4FxtI2jJBfwXPweDNzqz7P1H09PY/Zq0RvCe/A3TXs7/TKPKWFuYoMi46Jw hBZOVKACwGduR6itziOx+dy4rgw0xx8mFDyFkohqZwbWX4+eZE504B/EGlEuLMvwMGKD N9b/TCSflDiqgwmS4kQ9JLFFaBobblZGyL31eG56QjCxt4OaTVB3QsC+y7P56XwTP6bD hgkXBcgdMwa8j1ufMSJVAhwn0JKpI3ZTGShAelYtYqJvWMjxPA8H9z1yth7ER4zbPZDg OvJw== X-Gm-Message-State: AJIora8eaoyULnySX3gngBEt5k/kQtcb1ytqI1YccC/WnkOiOaJXFDx3 3P9Qp1Ol2Bblz1T9iv3jEtOP4xg18R0Ya+gF/+XoJA== X-Google-Smtp-Source: AGRyM1uXm/oRZ93ahSEfeyUsW+UFctkAT47q3YerFwjT589pWzySeIiSR5hjGhpMzE/vJGDcmKtpKb+w/kNgCOBopMM= X-Received: by 2002:a17:90b:384d:b0:1f0:2b57:5648 with SMTP id nl13-20020a17090b384d00b001f02b575648mr14560205pjb.125.1658461180428; Thu, 21 Jul 2022 20:39:40 -0700 (PDT) MIME-Version: 1.0 References: <20220714183913.118505-1-sughosh.ganu@linaro.org> <20220714183913.118505-7-sughosh.ganu@linaro.org> In-Reply-To: <20220714183913.118505-7-sughosh.ganu@linaro.org> From: Jassi Brar Date: Thu, 21 Jul 2022 22:39:29 -0500 Message-ID: Subject: Re: [PATCH v7 06/13] FWU: stm32mp1: Add helper functions for accessing FWU metadata To: Sughosh Ganu Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Patrick Delaunay , Patrice Chotard , Simon Glass , Bin Meng , Tom Rini , Etienne Carriere , Michal Simek Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, 14 Jul 2022 at 13:40, Sughosh Ganu wrote: > > Add helper functions needed for accessing the FWU metadata which > contains information on the updatable images. These functions have > been added for the STM32MP157C-DK2 board which has the updatable > images on the uSD card, formatted as GPT partitions. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > --- > Changes since V6: None > > board/st/stm32mp1/stm32mp1.c | 40 ++++++++++++++++ > include/fwu.h | 3 ++ > lib/fwu_updates/Makefile | 6 +++ > lib/fwu_updates/fwu_gpt.c | 88 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 137 insertions(+) > create mode 100644 lib/fwu_updates/Makefile > create mode 100644 lib/fwu_updates/fwu_gpt.c > fwu_gpt is to be used by all platforms that have the gpt-scheme, not just STM. So do you want to break this patch into two ? One generic that introduces the helper functions and another for stm using that api Also, you may want to specify GPL-2.0-or-later everywhere. thanks.