From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH] DMAEngine: Define generic transfer request api Date: Tue, 13 Sep 2011 14:13:43 +0530 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:60954 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753914Ab1IMInp convert rfc822-to-8bit (ORCPT ); Tue, 13 Sep 2011 04:43:45 -0400 Received: by wyh22 with SMTP id 22so296062wyh.19 for ; Tue, 13 Sep 2011 01:43:44 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Barry Song <21cnbao@gmail.com> Cc: dan.j.williams@intel.com, sundaram@ti.com, linus.walleij@linaro.org, vinod.koul@intel.com, rmk+kernel@arm.linux.org.uk, linux-omap@vger.kernel.org, DL-SHA-WorkGroupLinux On 13 September 2011 13:16, Barry Song <21cnbao@gmail.com> wrote: >> if test pass, to the patch, and even for the moment, to the API's id= ea >> Acked-by: Barry Song > > one issue i noticed is with a device_prep_dma_genxfer, i don't need > device_prep_slave_sg any more, Yeah, the damengine would need to adapt to the fact that these interleaved tranfers could be Mem->Mem as well as Mem<->Dev (even though yours could be only one type, but some dmacs could do both). > How about: > > =A0 =A0 =A0 BUG_ON(dma_has_cap(DMA_MEMCPY, device->cap_mask) && > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_dma_memcpy); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_dma_memcpy && > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_dma_genxfer); > > =A0 =A0 =A0 =A0BUG_ON(dma_has_cap(DMA_SLAVE, device->cap_mask) && > =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_slave_sg); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_slave_sg && > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 !device->device_prep_dma_genxfer); > Seems ok, but please modify in a way you think is best and submit a pat= ch on top of this new api. Then it'll be easier to evaluate everything. thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html