All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zheng Hacker <hackerzheng666@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>,
	"alex000young@gmail.com" <alex000young@gmail.com>,
	"security@kernel.org" <security@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"joonas.lahtinen@linux.intel.com"
	<joonas.lahtinen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	xmzyshypnc <1002992920@qq.com>,
	"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
	"intel-gvt-dev@lists.freedesktop.org" 
	<intel-gvt-dev@lists.freedesktop.org>,
	"zhi.a.wang@intel.com" <zhi.a.wang@intel.com>
Subject: Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.
Date: Fri, 16 Sep 2022 23:21:35 +0800	[thread overview]
Message-ID: <CAJedcCy-beMX=ytszAWMu28FH0qGKCsLC=0bJPL_Tmh35wigKw@mail.gmail.com> (raw)
In-Reply-To: <YyQzDlM5n7mOLh5Q@kroah.com>

Hi greg,

Thanks for pointing that out. Working on it now :)

Best wishes,
Zheng Wang

Greg KH <gregkh@linuxfoundation.org> 于2022年9月16日周五 16:25写道:
>
> On Fri, Sep 16, 2022 at 02:39:21PM +0800, Zheng Hacker wrote:
> > >From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001
> > From: xmzyshypnc <1002992920@qq.com>
> > Date: Fri, 16 Sep 2022 14:37:48 +0800
> > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry
> >
> > There is a double-free security bug in split_2MB_gtt_entry.
> >
> > Here is a calling chain :
> > ppgtt_populate_spt->ppgtt_populate_shadow_entry->split_2MB_gtt_entry.
> > If intel_gvt_dma_map_guest_page failed, it will call
> > ppgtt_invalidate_spt, which will finally call ppgtt_free_spt and
> > kfree(spt). But the caller does not notice that, and it will call
> > ppgtt_free_spt again in error path.
> >
> > Fix this by only freeing spt in ppgtt_invalidate_spt in good case.
> >
> > Signed-off-by: xmzyshypnc <1002992920@qq.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/gtt.c | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> > index 9f14fded8c0c..31d2a8d56384 100644
> > --- a/drivers/gpu/drm/i915/gvt/gtt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> > @@ -959,7 +959,7 @@ static inline int ppgtt_put_spt(struct
> > intel_vgpu_ppgtt_spt *spt)
> >   return atomic_dec_return(&spt->refcount);
> >  }
> >
> > -static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *spt);
> > +static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *sptm,
> > int is_error);
>
> Your patch is whitespace damaged and linewrapped and can not be applied,
> and can only barely read :(
>
> Please fix up your email client to not do this so that the change can be
> properly reviewed and accepted if correct.
>
> thanks,
>
> greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Zheng Hacker <hackerzheng666@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "alex000young@gmail.com" <alex000young@gmail.com>,
	"security@kernel.org" <security@kernel.org>,
	"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, xmzyshypnc <1002992920@qq.com>,
	"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>,
	"zhi.a.wang@intel.com" <zhi.a.wang@intel.com>
Subject: Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.
Date: Fri, 16 Sep 2022 23:21:35 +0800	[thread overview]
Message-ID: <CAJedcCy-beMX=ytszAWMu28FH0qGKCsLC=0bJPL_Tmh35wigKw@mail.gmail.com> (raw)
In-Reply-To: <YyQzDlM5n7mOLh5Q@kroah.com>

Hi greg,

Thanks for pointing that out. Working on it now :)

Best wishes,
Zheng Wang

Greg KH <gregkh@linuxfoundation.org> 于2022年9月16日周五 16:25写道:
>
> On Fri, Sep 16, 2022 at 02:39:21PM +0800, Zheng Hacker wrote:
> > >From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001
> > From: xmzyshypnc <1002992920@qq.com>
> > Date: Fri, 16 Sep 2022 14:37:48 +0800
> > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry
> >
> > There is a double-free security bug in split_2MB_gtt_entry.
> >
> > Here is a calling chain :
> > ppgtt_populate_spt->ppgtt_populate_shadow_entry->split_2MB_gtt_entry.
> > If intel_gvt_dma_map_guest_page failed, it will call
> > ppgtt_invalidate_spt, which will finally call ppgtt_free_spt and
> > kfree(spt). But the caller does not notice that, and it will call
> > ppgtt_free_spt again in error path.
> >
> > Fix this by only freeing spt in ppgtt_invalidate_spt in good case.
> >
> > Signed-off-by: xmzyshypnc <1002992920@qq.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/gtt.c | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> > index 9f14fded8c0c..31d2a8d56384 100644
> > --- a/drivers/gpu/drm/i915/gvt/gtt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> > @@ -959,7 +959,7 @@ static inline int ppgtt_put_spt(struct
> > intel_vgpu_ppgtt_spt *spt)
> >   return atomic_dec_return(&spt->refcount);
> >  }
> >
> > -static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *spt);
> > +static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *sptm,
> > int is_error);
>
> Your patch is whitespace damaged and linewrapped and can not be applied,
> and can only barely read :(
>
> Please fix up your email client to not do this so that the change can be
> properly reviewed and accepted if correct.
>
> thanks,
>
> greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Zheng Hacker <hackerzheng666@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "alex000young@gmail.com" <alex000young@gmail.com>,
	"security@kernel.org" <security@kernel.org>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, xmzyshypnc <1002992920@qq.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.
Date: Fri, 16 Sep 2022 23:21:35 +0800	[thread overview]
Message-ID: <CAJedcCy-beMX=ytszAWMu28FH0qGKCsLC=0bJPL_Tmh35wigKw@mail.gmail.com> (raw)
In-Reply-To: <YyQzDlM5n7mOLh5Q@kroah.com>

Hi greg,

Thanks for pointing that out. Working on it now :)

Best wishes,
Zheng Wang

Greg KH <gregkh@linuxfoundation.org> 于2022年9月16日周五 16:25写道:
>
> On Fri, Sep 16, 2022 at 02:39:21PM +0800, Zheng Hacker wrote:
> > >From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001
> > From: xmzyshypnc <1002992920@qq.com>
> > Date: Fri, 16 Sep 2022 14:37:48 +0800
> > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry
> >
> > There is a double-free security bug in split_2MB_gtt_entry.
> >
> > Here is a calling chain :
> > ppgtt_populate_spt->ppgtt_populate_shadow_entry->split_2MB_gtt_entry.
> > If intel_gvt_dma_map_guest_page failed, it will call
> > ppgtt_invalidate_spt, which will finally call ppgtt_free_spt and
> > kfree(spt). But the caller does not notice that, and it will call
> > ppgtt_free_spt again in error path.
> >
> > Fix this by only freeing spt in ppgtt_invalidate_spt in good case.
> >
> > Signed-off-by: xmzyshypnc <1002992920@qq.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/gtt.c | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> > index 9f14fded8c0c..31d2a8d56384 100644
> > --- a/drivers/gpu/drm/i915/gvt/gtt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> > @@ -959,7 +959,7 @@ static inline int ppgtt_put_spt(struct
> > intel_vgpu_ppgtt_spt *spt)
> >   return atomic_dec_return(&spt->refcount);
> >  }
> >
> > -static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *spt);
> > +static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *sptm,
> > int is_error);
>
> Your patch is whitespace damaged and linewrapped and can not be applied,
> and can only barely read :(
>
> Please fix up your email client to not do this so that the change can be
> properly reviewed and accepted if correct.
>
> thanks,
>
> greg k-h

  reply	other threads:[~2022-09-16 15:22 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_E1BBF05904DFB73C478DCD592740AAE0780A@qq.com>
2022-09-05  4:47 ` [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry Zheng Hacker
2022-09-05  4:47   ` [Intel-gfx] " Zheng Hacker
2022-09-05  6:11   ` Zheng Hacker
2022-09-05  6:11     ` [Intel-gfx] " Zheng Hacker
2022-09-05  7:35   ` Zheng Hacker
2022-09-05  7:35     ` [Intel-gfx] " Zheng Hacker
2022-09-05  7:35     ` Zheng Hacker
2022-09-05  7:46     ` Zheng Hacker
2022-09-05  7:46       ` [Intel-gfx] " Zheng Hacker
2022-09-05  7:46       ` Zheng Hacker
2022-09-05  8:04       ` Greg KH
2022-09-05  8:04         ` [Intel-gfx] " Greg KH
2022-09-05  8:04         ` Greg KH
2022-09-05  8:53         ` Alex Young
2022-09-05  8:53           ` Alex Young
2022-09-06 11:36         ` Zheng Hacker
2022-09-06 11:36           ` [Intel-gfx] " Zheng Hacker
2022-09-06 11:36           ` Zheng Hacker
2022-09-07  3:07           ` Zhenyu Wang
2022-09-07  3:07             ` [Intel-gfx] " Zhenyu Wang
2022-09-07  3:07             ` Zhenyu Wang
2022-09-07  6:47             ` Zheng Hacker
2022-09-07  6:47               ` [Intel-gfx] " Zheng Hacker
2022-09-07  6:47               ` Zheng Hacker
2022-09-08  9:09             ` Zheng Hacker
2022-09-08  9:09               ` [Intel-gfx] " Zheng Hacker
2022-09-08  9:09               ` Zheng Hacker
2022-09-08  9:19               ` Greg KH
2022-09-08  9:19                 ` [Intel-gfx] " Greg KH
2022-09-08  9:19                 ` Greg KH
2022-09-08 11:59                 ` Zheng Hacker
2022-09-08 11:59                   ` [Intel-gfx] " Zheng Hacker
2022-09-16  6:39                   ` Zheng Hacker
2022-09-16  6:39                     ` [Intel-gfx] " Zheng Hacker
2022-09-16  6:39                     ` Zheng Hacker
2022-09-16  6:40                     ` Zheng Hacker
2022-09-16  6:40                       ` [Intel-gfx] " Zheng Hacker
2022-09-16  6:40                       ` Zheng Hacker
2022-09-16  8:25                     ` Greg KH
2022-09-16  8:25                       ` [Intel-gfx] " Greg KH
2022-09-16  8:25                       ` Greg KH
2022-09-16 15:21                       ` Zheng Hacker [this message]
2022-09-16 15:21                         ` [Intel-gfx] " Zheng Hacker
2022-09-16 15:21                         ` Zheng Hacker
2022-09-16 15:54                       ` Zheng Hacker
2022-09-16 15:54                         ` [Intel-gfx] " Zheng Hacker
2022-09-16 15:54                         ` Zheng Hacker
2022-09-17  9:08                         ` Greg KH
2022-09-17  9:08                           ` [Intel-gfx] " Greg KH
2022-09-17  9:08                           ` Greg KH
2022-09-17  9:10                           ` Zheng Hacker
2022-09-17  9:10                             ` [Intel-gfx] " Zheng Hacker
2022-09-18 17:08                           ` =?gb18030?B?s68=?=
2022-09-18 17:08                             ` [Intel-gfx] " =?gb18030?B?s68=?=
2022-09-18 17:17                           ` Zheng Hacker
2022-09-18 17:17                             ` [Intel-gfx] " Zheng Hacker
2022-09-18 17:17                             ` Zheng Hacker
2022-09-19 20:16   ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-09-06 12:58 ` Patchwork
2022-09-06 14:22   ` Zheng Hacker
2022-09-06 14:29   ` Zheng Hacker
2022-09-19 20:20 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry. (rev3) Patchwork
2022-09-18 19:24 [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry Zheng Wang
2022-09-19  9:30 ` Jani Nikula
2022-09-19  9:55   ` Zheng Hacker
2022-09-19  9:55     ` Zheng Hacker
2022-09-21  9:13   ` Zheng Hacker
2022-09-21  9:13     ` Zheng Hacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJedcCy-beMX=ytszAWMu28FH0qGKCsLC=0bJPL_Tmh35wigKw@mail.gmail.com' \
    --to=hackerzheng666@gmail.com \
    --cc=1002992920@qq.com \
    --cc=airlied@linux.ie \
    --cc=alex000young@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=security@kernel.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.