From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CAADC19F2A for ; Mon, 1 Aug 2022 14:42:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB85D83F9A; Mon, 1 Aug 2022 16:42:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CidRb8AO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7356983FA1; Mon, 1 Aug 2022 16:42:40 +0200 (CEST) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 13B5A83EE2 for ; Mon, 1 Aug 2022 16:42:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jnhuang95@gmail.com Received: by mail-ej1-x62d.google.com with SMTP id a7so7779657ejp.2 for ; Mon, 01 Aug 2022 07:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc; bh=TM3wHl2zIiH+doyf4Cq9j4NhGaV5/aPn5dvdANtCHAw=; b=CidRb8AOUXImsPDkLHU1CPcZyEKk7wKK8VCye+Vne3gtAhPKNcCRcNHaR1bjtJQ5ba 5d9XmiJawoLLKuZ+sYrrHnzuRfq7K6vYufbq05Svy/akyzfdELtmC+GYDtolvZs28oO+ RdfqklHsEFss/Gh4Knl8hcFVXQkyq6pP2xyESeHBKdhlDnvbPedjP5A0MOmP0OimP/XF /YLBCsLCMaz4Ulnxd/93S5HoNk8zFBzudzpBdS7wJN9SERI0DjCd/Au96eQBATBv7jpk 1UidW7Zx9rWQB/9tczGU6S9F89mudg4H4ZwW+5JjZSZ7MsROH5lJ30UrKdtQ+SZlSS9M rFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc; bh=TM3wHl2zIiH+doyf4Cq9j4NhGaV5/aPn5dvdANtCHAw=; b=SseJ425yqE++mz1qxoDs1N7y8FaABnCGBU/2nk0BFk5jhD7RJrR/J66xX+fNl5LcTx adXkJ3HN+KaoffRNgNBY/K/cXWcxVhuLzz2lK1/Y6ug8iFRTLBQlQfWXT1D8HEZNj0oK RkI6io2HJnzyi1Bq1JcCbQcfRYENVxBWPZ/WOGfUyj4s3SddlwMMf3spTsH5nRWXnFFJ 93gS1NOP4jVZFQj7c60npPEdegpesmvL7K6yBGagcgcWxbItJmUS5ZTjNTXlSxzsZinS Jbkv5Td/yFnh5NVu5OWkjfHOAji8yeiIhmcRJWMDiCFJ53vPNVCeXUd1uTr0tyciPvK0 xKmw== X-Gm-Message-State: ACgBeo13+mWNpdwvqRC5K4AnJZ/CCEcq+bhVaHgRB9mh4saSgjDptY0X 3BEMG8z9jLmUvk83ELjhlulqJZzEUivjE/g4hfE= X-Google-Smtp-Source: AA6agR5AFIWJ+E9Nj7vXiMFNaVVtqhK4KayE7m6RflmbfS6jLCwELxMyByfqsKKq/7fAwYMbbMNvptm6gxpfTSFDWd0= X-Received: by 2002:a17:906:cc4a:b0:730:850f:5cb5 with SMTP id mm10-20020a170906cc4a00b00730850f5cb5mr4117016ejb.658.1659364957593; Mon, 01 Aug 2022 07:42:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6f02:8395:b0:20:75fc:d540 with HTTP; Mon, 1 Aug 2022 07:42:36 -0700 (PDT) In-Reply-To: <20220801132711.353837-1-heinrich.schuchardt@canonical.com> References: <20220801132711.353837-1-heinrich.schuchardt@canonical.com> From: Huang Jianan Date: Mon, 1 Aug 2022 22:42:36 +0800 Message-ID: Subject: Re: [PATCH 1/1] fs/erofs: silence erofs_probe() To: Heinrich Schuchardt Cc: "linux-erofs@lists.ozlabs.org" , "u-boot@lists.denx.de" , Simon Glass Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean =E5=9C=A8 2022=E5=B9=B48=E6=9C=881=E6=97=A5=E6=98=9F=E6=9C=9F=E4=B8=80=EF= =BC=8CHeinrich Schuchardt =E5=86=99=E9= =81=93=EF=BC=9A > fs_set_blk_dev() probes all file-systems until it finds one that matches > the volume. We do not expect any console output for non-matching > file-systems. > > Convert error messages in erofs_read_superblock() to debug output. > > Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > --- > v2: > keep erofs_err() for block size mismatch > --- > fs/erofs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good to me. Reviewed-by: Huang Jianan Thanks, Jianan > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 4cca322b9e..8277d9b53f 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -65,14 +65,14 @@ int erofs_read_superblock(void) > > ret =3D erofs_blk_read(data, 0, 1); > if (ret < 0) { > - erofs_err("cannot read erofs superblock: %d", ret); > + erofs_dbg("cannot read erofs superblock: %d", ret); > return -EIO; > } > dsb =3D (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET); > > ret =3D -EINVAL; > if (le32_to_cpu(dsb->magic) !=3D EROFS_SUPER_MAGIC_V1) { > - erofs_err("cannot find valid erofs superblock"); > + erofs_dbg("cannot find valid erofs superblock"); > return ret; > } > > -- > 2.36.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52729C00144 for ; Mon, 1 Aug 2022 14:42:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LxLSs405Hz3054 for ; Tue, 2 Aug 2022 00:42:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=CidRb8AO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::62f; helo=mail-ej1-x62f.google.com; envelope-from=jnhuang95@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=CidRb8AO; dkim-atps=neutral Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LxLSj716Wz2y27 for ; Tue, 2 Aug 2022 00:42:44 +1000 (AEST) Received: by mail-ej1-x62f.google.com with SMTP id tl27so2910436ejc.1 for ; Mon, 01 Aug 2022 07:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc; bh=TM3wHl2zIiH+doyf4Cq9j4NhGaV5/aPn5dvdANtCHAw=; b=CidRb8AOUXImsPDkLHU1CPcZyEKk7wKK8VCye+Vne3gtAhPKNcCRcNHaR1bjtJQ5ba 5d9XmiJawoLLKuZ+sYrrHnzuRfq7K6vYufbq05Svy/akyzfdELtmC+GYDtolvZs28oO+ RdfqklHsEFss/Gh4Knl8hcFVXQkyq6pP2xyESeHBKdhlDnvbPedjP5A0MOmP0OimP/XF /YLBCsLCMaz4Ulnxd/93S5HoNk8zFBzudzpBdS7wJN9SERI0DjCd/Au96eQBATBv7jpk 1UidW7Zx9rWQB/9tczGU6S9F89mudg4H4ZwW+5JjZSZ7MsROH5lJ30UrKdtQ+SZlSS9M rFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc; bh=TM3wHl2zIiH+doyf4Cq9j4NhGaV5/aPn5dvdANtCHAw=; b=sBx9Ui9aEwARxWQjP54AEOxD25ikMGOf5lvconBtUQm3sliChX0E+LXGmLjHPVN/qa a8pBbOfzcxJTgOgZzex7L7t6utmuYgWjX+mbmWVjS66j9KXyyB+7AzJ6VETa5G4J9f8B 4ZiSrfbJKWdEcvvBQnIuONkLjqy/9KJI5SNIOe7uZXkiDm5hC1kkNAoM/VELlu3G+0Kl 01y49BLrNdSiASDKiMo/FpIeCivM3i2HjhkDhU0bP/21XbYlo5Z6gWS7tU1IO6aFUayo P2a9k6XIXOGgv34A9t53u6dRrHlgvvBZykqK2mYwC5r5qF16J5ukme7iTSfWu9/pXed2 ehRQ== X-Gm-Message-State: ACgBeo2yv4jZueE2eW4JVXT4Q5/RkjWkLfPsL0LAwmoz51in91q9qliT Ep4tQx2AZQMoM1sr3OU1YGpn58uVjPEcHjpG+ek= X-Google-Smtp-Source: AA6agR5AFIWJ+E9Nj7vXiMFNaVVtqhK4KayE7m6RflmbfS6jLCwELxMyByfqsKKq/7fAwYMbbMNvptm6gxpfTSFDWd0= X-Received: by 2002:a17:906:cc4a:b0:730:850f:5cb5 with SMTP id mm10-20020a170906cc4a00b00730850f5cb5mr4117016ejb.658.1659364957593; Mon, 01 Aug 2022 07:42:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6f02:8395:b0:20:75fc:d540 with HTTP; Mon, 1 Aug 2022 07:42:36 -0700 (PDT) In-Reply-To: <20220801132711.353837-1-heinrich.schuchardt@canonical.com> References: <20220801132711.353837-1-heinrich.schuchardt@canonical.com> From: Huang Jianan Date: Mon, 1 Aug 2022 22:42:36 +0800 Message-ID: Subject: Re: [PATCH 1/1] fs/erofs: silence erofs_probe() To: Heinrich Schuchardt Content-Type: multipart/alternative; boundary="000000000000d9a54905e52f029d" X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "u-boot@lists.denx.de" , Simon Glass , "linux-erofs@lists.ozlabs.org" Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" --000000000000d9a54905e52f029d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =E5=9C=A8 2022=E5=B9=B48=E6=9C=881=E6=97=A5=E6=98=9F=E6=9C=9F=E4=B8=80=EF= =BC=8CHeinrich Schuchardt =E5=86=99=E9= =81=93=EF=BC=9A > fs_set_blk_dev() probes all file-systems until it finds one that matches > the volume. We do not expect any console output for non-matching > file-systems. > > Convert error messages in erofs_read_superblock() to debug output. > > Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > --- > v2: > keep erofs_err() for block size mismatch > --- > fs/erofs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good to me. Reviewed-by: Huang Jianan Thanks, Jianan > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 4cca322b9e..8277d9b53f 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -65,14 +65,14 @@ int erofs_read_superblock(void) > > ret =3D erofs_blk_read(data, 0, 1); > if (ret < 0) { > - erofs_err("cannot read erofs superblock: %d", ret); > + erofs_dbg("cannot read erofs superblock: %d", ret); > return -EIO; > } > dsb =3D (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET); > > ret =3D -EINVAL; > if (le32_to_cpu(dsb->magic) !=3D EROFS_SUPER_MAGIC_V1) { > - erofs_err("cannot find valid erofs superblock"); > + erofs_dbg("cannot find valid erofs superblock"); > return ret; > } > > -- > 2.36.1 > > --000000000000d9a54905e52f029d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

=E5=9C=A8 2022=E5=B9=B48=E6=9C=881=E6=97=A5=E6=98=9F=E6=9C=9F=E4=B8= =80=EF=BC=8CHeinrich Schuchardt <heinrich.schuchardt@canonical.com> =E5=86=99=E9=81=93= =EF=BC=9A
fs_set_blk_dev() probes all fil= e-systems until it finds one that matches
the volume. We do not expect any console output for non-matching
file-systems.

Convert error messages in erofs_read_superblock() to debug output.

Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromi= um.org>
---
v2:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 keep erofs_err() for block size mismatch
---
=C2=A0fs/erofs/super.c | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

=
Looks good to me.
Reviewed-by: Huang Jianan <jnhuang95@gmail.com>=C2=A0

Thanks,
Jianan=C2=A0=C2=A0

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 4cca322b9e..8277d9b53f 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -65,14 +65,14 @@ int erofs_read_superblock(void)

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D erofs_blk_read(data, 0, 1);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ret < 0) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0erofs_err("can= not read erofs superblock: %d", ret);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0erofs_dbg("can= not read erofs superblock: %d", ret);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EIO;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 dsb =3D (struct erofs_super_block *)(data + ERO= FS_SUPER_OFFSET);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D -EINVAL;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (le32_to_cpu(dsb->magic) !=3D EROFS_SUPER= _MAGIC_V1) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0erofs_err("can= not find valid erofs superblock");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0erofs_dbg("can= not find valid erofs superblock");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ret;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0
--
2.36.1

--000000000000d9a54905e52f029d--