All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Ondrej Mosnacek <omosnace@redhat.com>,
	SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH userspace] policycoreutils/setfiles: do not create useless setfiles.8.man file
Date: Wed, 21 Apr 2021 10:27:36 +0200	[thread overview]
Message-ID: <CAJfZ7=n+0sS0K17JJbAmz6pRg-aV3RYCzA8c6YSGvrJYRZav3Q@mail.gmail.com> (raw)
In-Reply-To: <20210319213059.2779873-1-omosnace@redhat.com>

On Fri, Mar 19, 2021 at 10:32 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Seems to have been there to allow for some sed substitution over the
> text. Now that this is gone, the redundant intermediate file can be
> removed, too.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

Hello,
It seems nobody reviewed this patch, and it looks good to me. So if
nobody complains, I will merge it tomorrow.

Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>

Thanks,
Nicolas

> ---
>  policycoreutils/setfiles/.gitignore | 1 -
>  policycoreutils/setfiles/Makefile   | 9 +++------
>  2 files changed, 3 insertions(+), 7 deletions(-)
>  delete mode 100644 policycoreutils/setfiles/.gitignore
>
> diff --git a/policycoreutils/setfiles/.gitignore b/policycoreutils/setfiles/.gitignore
> deleted file mode 100644
> index 5e899c95..00000000
> --- a/policycoreutils/setfiles/.gitignore
> +++ /dev/null
> @@ -1 +0,0 @@
> -setfiles.8.man
> diff --git a/policycoreutils/setfiles/Makefile b/policycoreutils/setfiles/Makefile
> index a3bbbe11..63d81850 100644
> --- a/policycoreutils/setfiles/Makefile
> +++ b/policycoreutils/setfiles/Makefile
> @@ -13,7 +13,7 @@ ifeq ($(AUDITH), y)
>         override LDLIBS += -laudit
>  endif
>
> -all: setfiles restorecon restorecon_xattr man
> +all: setfiles restorecon restorecon_xattr
>
>  setfiles: setfiles.o restore.o
>
> @@ -22,16 +22,13 @@ restorecon: setfiles
>
>  restorecon_xattr: restorecon_xattr.o restore.o
>
> -man:
> -       @cp -af setfiles.8 setfiles.8.man
> -
>  install: all
>         [ -d $(DESTDIR)$(MANDIR)/man8 ] || mkdir -p $(DESTDIR)$(MANDIR)/man8
>         -mkdir -p $(DESTDIR)$(SBINDIR)
>         install -m 755 setfiles $(DESTDIR)$(SBINDIR)
>         (cd $(DESTDIR)$(SBINDIR) && ln -sf setfiles restorecon)
>         install -m 755 restorecon_xattr $(DESTDIR)$(SBINDIR)
> -       install -m 644 setfiles.8.man $(DESTDIR)$(MANDIR)/man8/setfiles.8
> +       install -m 644 setfiles.8 $(DESTDIR)$(MANDIR)/man8/setfiles.8
>         install -m 644 restorecon.8 $(DESTDIR)$(MANDIR)/man8/restorecon.8
>         install -m 644 restorecon_xattr.8 $(DESTDIR)$(MANDIR)/man8/restorecon_xattr.8
>         for lang in $(LINGUAS) ; do \
> @@ -42,7 +39,7 @@ install: all
>         done
>
>  clean:
> -       rm -f setfiles restorecon restorecon_xattr *.o setfiles.8.man
> +       rm -f setfiles restorecon restorecon_xattr *.o
>
>  indent:
>         ../../scripts/Lindent $(wildcard *.[ch])
> --
> 2.30.2
>


  reply	other threads:[~2021-04-21  8:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 21:30 [PATCH userspace] policycoreutils/setfiles: do not create useless setfiles.8.man file Ondrej Mosnacek
2021-04-21  8:27 ` Nicolas Iooss [this message]
2021-04-22 19:10   ` Nicolas Iooss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfZ7=n+0sS0K17JJbAmz6pRg-aV3RYCzA8c6YSGvrJYRZav3Q@mail.gmail.com' \
    --to=nicolas.iooss@m4x.org \
    --cc=omosnace@redhat.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.