Re: [RFC PATCH v2] ovl: don't follow redirects if redirect_dir=off

[Miklos Szeredi <miklos@szeredi.hu>]

On Fri, Dec 8, 2017 at 3:36 PM, David Howells <dhowells@redhat.com> wrote:
> Miklos Szeredi <miklos@szeredi.hu> wrote:
>
>> +     const char *redirect_mode;
>> ...
>> +     kfree(ofs->config.redirect_mode);
>
> That's going to get you a compiler warning under some circumstances.

How so?  kfree() takes const void *, which is compatible with const char *.

>
>> +                     config->redirect_mode = match_strdup(&args[0]);
>
> We shouldn't really be copying the string if we can help it, though I grant we
> may not have the match_*() function to do otherwise at the moment.  I would
> much prefer seeing it rendered to an enum value at this point.

I think that's going into the bike shedding territory, and this shed
is mine, so there ;-p

Thanks,
Miklos