All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [GIT PULL for 4.8] consolidate vfs API for overlayfs
Date: Thu, 30 Jun 2016 09:22:07 +0200	[thread overview]
Message-ID: <CAJfpeguMumFdFy9unZkYfrmVfc-oibhspQKytNKRtoyi8-qhKQ@mail.gmail.com> (raw)
In-Reply-To: <20160629230952.GE14480@ZenIV.linux.org.uk>

On Thu, Jun 30, 2016 at 1:09 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Jun 28, 2016 at 10:18:10AM +0200, Miklos Szeredi wrote:
>> Hi Al,
>>
>> Please pull from:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git d_real
>>
>> This consolidates the d_real/d_select_inode API as well as some documentation
>> cleanups.
>
> Two notes:
>
> 1) you have 4 places with identical "if DCACHE_OP_REAL is there,
> call ->d_real(dentry, ..., ...), otherwise return dentry".  And you have
> exactly one place where d_real() wrapper is called.  Looks like we would
> be better off with the calling conventions for wrapper updated as well.
>
> 2) while we can't turn dentry argument into const struct dentry * (due to
> ovl_copy_up()), could we at least do that to the inode one?
>
> IOW, how about this, on top of that branch?  Or fold it into the commit
> changing the arguments of ->d_real(), for that matter...

Makes sense.  Folded, updated doc and force pushed to the same branch.

Thanks,
Miklos

      reply	other threads:[~2016-06-30  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  8:18 [GIT PULL for 4.8] consolidate vfs API for overlayfs Miklos Szeredi
2016-06-29 23:09 ` Al Viro
2016-06-30  7:22   ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpeguMumFdFy9unZkYfrmVfc-oibhspQKytNKRtoyi8-qhKQ@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.