All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: sync dirty data when remounting to ro mode
Date: Wed, 22 Apr 2020 10:26:12 +0200	[thread overview]
Message-ID: <CAJfpeguqT2Wxm5df36yaTh4JL1oz2qj4r-Eb9-rCCqRhq0OAXA@mail.gmail.com> (raw)
In-Reply-To: <171a0f2ccf8.efa2ca517201.9030529562121260568@mykernel.net>

On Wed, Apr 22, 2020 at 10:13 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
>  ---- 在 星期三, 2020-04-22 15:29:33 Miklos Szeredi <miklos@szeredi.hu> 撰写 ----
>  > On Wed, Apr 22, 2020 at 6:29 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
>  > >
>  > > sync_filesystem() does not sync dirty data for readonly
>  > > filesystem during umount, so before changing to readonly
>  > > filesystem we should sync dirty data for data integrity.
>  >
>  > Isn't the same true for ->put_super()?
>  >
>
> Before getting into ->put_super(),  dirty data have been synced through below functions,
> so I think we don't have to worry about ->put_super().
>
> kill_anon_super()
>   generic_shutdown_super()
>      sync_filesystem()

Okay, makes sense.

Thanks,
Miklos

      reply	other threads:[~2020-04-22  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  4:28 [PATCH] ovl: sync dirty data when remounting to ro mode Chengguang Xu
2020-04-22  7:29 ` Miklos Szeredi
2020-04-22  8:13   ` Chengguang Xu
2020-04-22  8:26     ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpeguqT2Wxm5df36yaTh4JL1oz2qj4r-Eb9-rCCqRhq0OAXA@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=cgxu519@mykernel.net \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.