From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CDDC433E0 for ; Mon, 15 Jun 2020 08:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 914442053B for ; Mon, 15 Jun 2020 08:24:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="Uy4iXrsd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728428AbgFOIY4 (ORCPT ); Mon, 15 Jun 2020 04:24:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728180AbgFOIY4 (ORCPT ); Mon, 15 Jun 2020 04:24:56 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5244BC061A0E for ; Mon, 15 Jun 2020 01:24:55 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id t21so10818861edr.12 for ; Mon, 15 Jun 2020 01:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZhrHsoF+IuuCWsNYTt36CnOUPKOXLNanHzXXw538ijY=; b=Uy4iXrsdKb9Jk+JDiX/Chl9qMKx9QpugSWS5NkriaPMVcmD97vURwhir28xYpfpmqh SPDMoEWcuI4fT1IewSfOaVTFRjIgC0ZgI+aTtHVa8Bt1v7S6TEeRQHOUatH5LzhwpGJ+ 6YojzNXVz6UCsvtK15ZaCT6yZnZ3E7q4SDk9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZhrHsoF+IuuCWsNYTt36CnOUPKOXLNanHzXXw538ijY=; b=ESkMxv/AYKxt3ng0l89Wde29vlZJCkxoPzpf6zClVSP46rzRJsaidc4FbucYeCZ6JQ 427Fzykrshvahd29KzlVE3XpugGi7gETqTROgCjM3B2lJTa6l6TWxxG8PnGzzsONPXEp fVXa0pMvMcQOZTTSnTwoZgJr1zanL7sqbb71dHlLWYkvFTy4D075ypcgC2+tpz4IBqhk ZtYnU6gmRPd9qba0R7Q9CRoLkG5cGCfDP9LbHa35WgWzN71RL+62bnAcNaheHuNm7JzO 7JZnyUD/P3AV7rMQXqnYVJ5CFw/GIW1KMgUuNbRC5L3b1DlTd0g7S5JLwLBAfiXi7GeO Dpzg== X-Gm-Message-State: AOAM532pyrK60sVycOijn9h+Czd708lmS/J0dbgCqQcmlf+KyT02nFVK orDKPN/NjJ9ISe0gBgDd+2/TJJLJpFzWNHrpI4mIYA== X-Google-Smtp-Source: ABdhPJyTYfl7L17Ro5jQwnBv2wTKOxjN4zvQSKG7SGBI4x6Y1v+nhySmXXUUI9zXVpw1KDpsuc+QcQbm++UqGImgmT8= X-Received: by 2002:a50:d785:: with SMTP id w5mr22156433edi.212.1592209493931; Mon, 15 Jun 2020 01:24:53 -0700 (PDT) MIME-Version: 1.0 References: <20200612004644.255692-1-mike.kravetz@oracle.com> <20200612015842.GC23230@ZenIV.linux.org.uk> In-Reply-To: From: Miklos Szeredi Date: Mon, 15 Jun 2020 10:24:42 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] hugetlb: use f_mode & FMODE_HUGETLBFS to identify hugetlbfs files To: Amir Goldstein Cc: Mike Kravetz , Al Viro , Linux MM , linux-fsdevel , overlayfs , linux-kernel , Matthew Wilcox , Colin Walters , Andrew Morton , syzbot , syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Sender: linux-unionfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org On Sat, Jun 13, 2020 at 8:53 AM Amir Goldstein wrote: > > I also looked at normal filesystem lower and hugetlbfs upper. Yes, overlayfs > > allows this. This is somewhat 'interesting' as write() is not supported in > > hugetlbfs. Writing to files in the overlay actually ended up writing to > > files in the lower filesystem. That seems wrong, but overlayfs is new to me. Yes, this very definitely should not happen. > I am not sure how that happened, but I think that ovl_open_realfile() > needs to fixup f_mode flags FMODE_CAN_WRITE | FMODE_CAN_READ > after open_with_fake_path(). Okay, but how did the write actually get to the lower layer? I failed to reproduce this. Mike, how did you trigger this? Thanks, Miklos From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5442C433DF for ; Mon, 15 Jun 2020 08:24:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E9B22053B for ; Mon, 15 Jun 2020 08:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="Uy4iXrsd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E9B22053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=szeredi.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4C266B0005; Mon, 15 Jun 2020 04:24:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4766B0006; Mon, 15 Jun 2020 04:24:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89D1D6B0007; Mon, 15 Jun 2020 04:24:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 6E16C6B0005 for ; Mon, 15 Jun 2020 04:24:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F198E8245571 for ; Mon, 15 Jun 2020 08:24:55 +0000 (UTC) X-FDA: 76930760550.22.car44_61008fa26df4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id C09B618038E6B for ; Mon, 15 Jun 2020 08:24:55 +0000 (UTC) X-HE-Tag: car44_61008fa26df4 X-Filterd-Recvd-Size: 3766 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 08:24:55 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id x25so3878459edr.8 for ; Mon, 15 Jun 2020 01:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZhrHsoF+IuuCWsNYTt36CnOUPKOXLNanHzXXw538ijY=; b=Uy4iXrsdKb9Jk+JDiX/Chl9qMKx9QpugSWS5NkriaPMVcmD97vURwhir28xYpfpmqh SPDMoEWcuI4fT1IewSfOaVTFRjIgC0ZgI+aTtHVa8Bt1v7S6TEeRQHOUatH5LzhwpGJ+ 6YojzNXVz6UCsvtK15ZaCT6yZnZ3E7q4SDk9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZhrHsoF+IuuCWsNYTt36CnOUPKOXLNanHzXXw538ijY=; b=VZUHfHxt/gJlUQ/5QuUVmoCkN4Pbhl97OUqAf8RtRuCdD7JyEdEMJM7ZoLMh8ouaXq +4Yx7TmvDqg5JNrpYZyKV7Sw53idOXNs5+qB2h3TvcFzKzdaRe+nsv8OIYpT6z1i07ay DJzVLRFqigIXK3qmM6dZXbCj0cYTMdLRUWQUKy1wswb4Pol4DBsvpE3oWZKqLGmYiMGH W8prr2oi8JIuByfcliEwHnAXOpiGSX/716MV6NMA9YCEAwhr2ovoVL0VYUCImWR/Ps0c yooFmfhhKdOeassJxkYyesdQX5djM/1xAOYxpeVKxj4zmPtfCrrE3m+JthYxpw5jq8Se bk7A== X-Gm-Message-State: AOAM533kiCC2qgjj4S4sAuOJ8uiPrnoJvTuF2/Efk0PrEMHdqZy1dZN2 8NEGx/lK+D60ympTsJLbiz9HOVDUgdJFt/k3o7FN/Q== X-Google-Smtp-Source: ABdhPJyTYfl7L17Ro5jQwnBv2wTKOxjN4zvQSKG7SGBI4x6Y1v+nhySmXXUUI9zXVpw1KDpsuc+QcQbm++UqGImgmT8= X-Received: by 2002:a50:d785:: with SMTP id w5mr22156433edi.212.1592209493931; Mon, 15 Jun 2020 01:24:53 -0700 (PDT) MIME-Version: 1.0 References: <20200612004644.255692-1-mike.kravetz@oracle.com> <20200612015842.GC23230@ZenIV.linux.org.uk> In-Reply-To: From: Miklos Szeredi Date: Mon, 15 Jun 2020 10:24:42 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] hugetlb: use f_mode & FMODE_HUGETLBFS to identify hugetlbfs files To: Amir Goldstein Cc: Mike Kravetz , Al Viro , Linux MM , linux-fsdevel , overlayfs , linux-kernel , Matthew Wilcox , Colin Walters , Andrew Morton , syzbot , syzkaller-bugs Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C09B618038E6B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 13, 2020 at 8:53 AM Amir Goldstein wrote: > > I also looked at normal filesystem lower and hugetlbfs upper. Yes, overlayfs > > allows this. This is somewhat 'interesting' as write() is not supported in > > hugetlbfs. Writing to files in the overlay actually ended up writing to > > files in the lower filesystem. That seems wrong, but overlayfs is new to me. Yes, this very definitely should not happen. > I am not sure how that happened, but I think that ovl_open_realfile() > needs to fixup f_mode flags FMODE_CAN_WRITE | FMODE_CAN_READ > after open_with_fake_path(). Okay, but how did the write actually get to the lower layer? I failed to reproduce this. Mike, how did you trigger this? Thanks, Miklos