All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	Amir Goldstein <amir73il@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Yu-li Lin <yulilin@google.com>,
	Chirantan Ekbote <chirantan@chromium.org>
Subject: Re: [PATCH v4 04/10] cachefiles: only pass inode to *mark_inode_inuse() helpers
Date: Sat, 24 Sep 2022 07:02:19 +0200	[thread overview]
Message-ID: <CAJfpegv39g--QB=ks9oFRajbCveO+q0nwH3caZz1_Sw4TLiNww@mail.gmail.com> (raw)
In-Reply-To: <Yy6OASz8zZIpBRNk@ZenIV>

On Sat, 24 Sept 2022 at 06:56, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Fri, Sep 23, 2022 at 05:42:01PM +0200, Miklos Szeredi wrote:
> > On Thu, 22 Sept 2022 at 18:22, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > > I would rather leave unobfuscating that to a separate patch,
> > > if not a separate series, but since you are touching
> > > cachefiles_unmark_inode_in_use() anyway, might as well
> > > get rid of if (inode) in there - it's equivalent to if (true).
> >
> > Okay, pushed updated version (also with
> > cachefiles_do_unmark_inode_in_use() un-open-coding) to:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#fuse-tmpfile-v5
>
> OK...  I can live with that.  Could you
> replace
>         cachefiles_do_unmark_inode_in_use(object, file_inode(file));
> with
>         cachefiles_do_unmark_inode_in_use(object, inode);
> in there and repush?  Or I could do cherry-pick and fix it up...

Done.  Head is now:

7d37539037c2 ("fuse: implement ->tmpfile()")

Thanks,
Miklos

  reply	other threads:[~2022-09-24  5:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  8:44 [PATCH v4 00/10] fuse tmpfile Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 01/10] vfs: add vfs_tmpfile_open() helper Miklos Szeredi
2022-09-22 15:23   ` Christian Brauner
2022-09-22  8:44 ` [PATCH v4 02/10] hugetlbfs: cleanup mknod and tmpfile Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 03/10] cachefiles: tmpfile error handling cleanup Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 04/10] cachefiles: only pass inode to *mark_inode_inuse() helpers Miklos Szeredi
2022-09-22 15:24   ` Christian Brauner
2022-09-22 16:22   ` Al Viro
2022-09-23 15:42     ` Miklos Szeredi
2022-09-24  4:56       ` Al Viro
2022-09-24  5:02         ` Miklos Szeredi [this message]
2022-09-24 14:37           ` Al Viro
2022-09-22  8:44 ` [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper Miklos Szeredi
2022-09-22 15:26   ` Christian Brauner
2022-09-22  8:44 ` [PATCH v4 06/10] ovl: " Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 07/10] vfs: make vfs_tmpfile() static Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 08/10] vfs: move open right after ->tmpfile() Miklos Szeredi
2022-09-22  8:44 ` [PATCH v4 09/10] vfs: open inside ->tmpfile() Miklos Szeredi
2022-09-22 15:27   ` Christian Brauner
2022-09-22  8:44 ` [PATCH v4 10/10] fuse: implement ->tmpfile() Miklos Szeredi
2022-09-22 15:29   ` Christian Brauner
2022-09-29  8:37 ` [PATCH v4 00/10] fuse tmpfile David Howells
2022-09-29  8:44 ` [PATCH v4 05/10] cachefiles: use vfs_tmpfile_open() helper David Howells
2022-09-30 13:53   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegv39g--QB=ks9oFRajbCveO+q0nwH3caZz1_Sw4TLiNww@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=chirantan@chromium.org \
    --cc=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yulilin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.