All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/6] vfs: create vfs helper vfs_tmpfile()
Date: Mon, 16 Jan 2017 15:15:51 +0100	[thread overview]
Message-ID: <CAJfpegvQrCHpxpy+Yw7z=P3jexrvFhSpq41w2NT2KXq46kOo-w@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxi040SvV=kQUy+pB7CFAjbQPfMVmKRFDjuuL3jeV_fMWA@mail.gmail.com>

On Mon, Jan 16, 2017 at 3:04 PM, Amir Goldstein <amir73il@gmail.com> wrote:

> What I tried to do at first is leave d_alloc inside vfs_tmpfile()
> and return dentry, but I did not want this interface to deal with struct file
> as well.

Agreed, I think you should do that.

>
> so do_tmpfile() is very roughly equivalent to:
> path_lookupat()
> mnt_want_write()
> vfs_tmpfile() (including d_alloc)
> dentry_open()
> inode->i_state |= I_LINKABLE
>
> So I can set LINKABLE inside vfs_tmpfile() only if I also pass
> it open_flag

Yes.

> and then it would also happen before open returns
> success.

It doesn't matter.  If open fails the temporary file will be deleted,
dentry, inode and all.

Thanks,
Miklos

  reply	other threads:[~2017-01-16 14:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-15 13:57 [PATCH 0/6] ovl: concurrent copy up Amir Goldstein
2017-01-15 13:57 ` [PATCH 1/6] vfs: create vfs helper vfs_tmpfile() Amir Goldstein
2017-01-16 11:00   ` Miklos Szeredi
2017-01-16 11:19     ` Amir Goldstein
2017-01-16 13:22       ` Miklos Szeredi
2017-01-16 14:04         ` Amir Goldstein
2017-01-16 14:15           ` Miklos Szeredi [this message]
2017-01-15 13:57 ` [PATCH 2/6] ovl: check if upperdir fs supports O_TMPFILE Amir Goldstein
2017-01-16 14:02   ` Miklos Szeredi
2017-01-16 14:16     ` Amir Goldstein
2017-01-16 14:29       ` Miklos Szeredi
2017-01-15 13:57 ` [PATCH 3/6] ovl: rearrange code in ovl_copy_up_locked() Amir Goldstein
2017-01-15 13:57 ` [PATCH 4/6] ovl: copy up regular file using O_TMPFILE Amir Goldstein
2017-01-15 13:57 ` [PATCH 5/6] ovl: introduce copy up waitqueue Amir Goldstein
2017-01-15 13:57 ` [PATCH 6/6] ovl: concurrent copy up of regular files Amir Goldstein
2017-01-16 11:05   ` Miklos Szeredi
2017-01-16 11:31     ` Amir Goldstein
2017-01-16 11:58   ` [PATCH v2 " Amir Goldstein
2017-01-16 13:29     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegvQrCHpxpy+Yw7z=P3jexrvFhSpq41w2NT2KXq46kOo-w@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.