From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbaBMS40 (ORCPT ); Thu, 13 Feb 2014 13:56:26 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:63634 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbaBMS4Y (ORCPT ); Thu, 13 Feb 2014 13:56:24 -0500 MIME-Version: 1.0 X-Originating-IP: [86.59.245.170] In-Reply-To: References: <1391791751-2533-1-git-send-email-miklos@szeredi.hu> <19258.1392306854@warthog.procyon.org.uk> <20140213162534.GB4026@tucsk.piliscsaba.szeredi.hu> <20106.1392309770@warthog.procyon.org.uk> Date: Thu, 13 Feb 2014 19:56:23 +0100 Message-ID: Subject: Re: [PATCH 00/13] cross rename v4 From: Miklos Szeredi To: Linus Torvalds Cc: David Howells , Al Viro , Linux-Fsdevel , Kernel Mailing List , Bruce Fields , Christoph Hellwig , Andrew Morton , Zach Brown , Jan Kara , Andy Lutomirski , "mszeredi@suse.cz" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 13, 2014 at 7:29 PM, Linus Torvalds wrote: > On Thu, Feb 13, 2014 at 9:28 AM, Miklos Szeredi wrote: >>> >>> I would suggest that whiteouts appear as otherwise negative dentries and that >>> they don't appear in getdents(). >> >> I'd argue that this is an administration nightmare. E.g. what if the >> a backup needs to be made of the rw layer? > > The major issue is user space support. > > So what do others that support this do? Looking at the gitweb for > ls.c in coreutils, we find: > > http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/ls.c > > # ifdef DT_WHT > case DT_WHT: type = whiteout; break; > # endif > > so that's presumably what we should use. Fair enough, that allows the thing to be listed, at least. What about creation? A new syscall? Removal? unlink(2)? Should stat(2) succeed with a new filetype? Thanks, Miklos