From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82664C4338F for ; Wed, 28 Jul 2021 14:34:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F5C760F91 for ; Wed, 28 Jul 2021 14:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F5C760F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79C266EB2D; Wed, 28 Jul 2021 14:34:29 +0000 (UTC) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EC386EB29 for ; Wed, 28 Jul 2021 14:34:27 +0000 (UTC) Received: by mail-ua1-x929.google.com with SMTP id d6so1184286uav.2 for ; Wed, 28 Jul 2021 07:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7u2BTk0mrMKoVnndTza4mcFVVzMmku9h4wSobsJzJUs=; b=kFDUlnbAKeAGtgqONFDWFYDiQfyoWPHSCclsB8xQjKMo5wmAuNAm2UT0e5yfNnapxI f4tB0UmaF/ucF/t9ooyYFuDbgxbGrgXiR1AKXFE68p5p4LWt4CUu/pWW1UFFfkJhT96V nx3QNkFX0fFstdPaET2GrDDT6gPiHba+O+yWDfpYqCy72I4Ptaz7X7BdM/RHosgz1uAU P9huM7gLFoROYj86VVgPQHDcWTlK2BZdhcfoSesLdjAhKMJj06lbOImgeQkvMRE/1o7c AfgInLjSbTMkcefYrQq6plLcSgMiAYlhz1UuqRQhtepIxcyh32UyCL7cPfg/7e0suJKl 7KMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7u2BTk0mrMKoVnndTza4mcFVVzMmku9h4wSobsJzJUs=; b=tadp2LOUVrIyEBhxOaGOSbuNbK/fart0jzvD1LnDawNeQq8xo9WBoLhTihybjHHyWc 0eshZDmbUssBir0aqaBGByiqXYnAnNzu/i+0JwHvS2RaqSdUDe/myblPjOsclMyR4KMd creLM0eeZVCLDnlBSVYMqMbxU/o0kJoxotXb/SUNqi3x4ZPkyCvlphgtXmkWSYGHAt0X iHzLNvTu0r9EPxxDbzGGVZCo1PypgCS5Xe1ttyNckuRsOa7+IGOPOE39IIKYT5CEdbJK LR6ydfcApziOys0Qqibt5PttpgWwzRBzE3BFiRfM15fA823ZX2S2rGYrY54padL/SmtD DnvQ== X-Gm-Message-State: AOAM531PgjPy0ZDRn2ojVQiLg57w2+wgZ0qQL4QFSiKpxK5xpPgUNSMs bFfOTlXPMejx2bFGuIOxeuG7e+y3JEo/U6mTEQc= X-Google-Smtp-Source: ABdhPJyPNjUpufsG7zWKi5R3dBQQ+gs28pFkpo1Oh3BpQfnLxrH+pv/zmNBnwuN+D6u/AAkbCQXjWctcLxYFNKzQTzg= X-Received: by 2002:ab0:25c5:: with SMTP id y5mr67652uan.142.1627482866205; Wed, 28 Jul 2021 07:34:26 -0700 (PDT) MIME-Version: 1.0 References: <20210721175526.22020-1-sean@poorly.run> <20210721175526.22020-3-sean@poorly.run> In-Reply-To: <20210721175526.22020-3-sean@poorly.run> From: jim.cromie@gmail.com Date: Wed, 28 Jul 2021 10:34:00 -0400 Message-ID: Subject: Re: [RESEND PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg To: Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Sean Paul , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" hi Sean, one little niggle here. On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > Use the drm debug helper instead of dev_printk in order to leverage the > upcoming tracefs support > > Signed-off-by: Sean Paul > Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-3-sean@poorly.run #v5 > > Changes in v5: > -Added to the set > Changes in v6: > -None > --- > drivers/gpu/drm/i2c/sil164_drv.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c > index 741886b54419..b315a789fca2 100644 > --- a/drivers/gpu/drm/i2c/sil164_drv.c > +++ b/drivers/gpu/drm/i2c/sil164_drv.c > @@ -43,11 +43,6 @@ struct sil164_priv { > #define to_sil164_priv(x) \ > ((struct sil164_priv *)to_encoder_slave(x)->slave_priv) > > -#define sil164_dbg(client, format, ...) do { \ > - if (drm_debug_enabled(DRM_UT_KMS)) \ > - dev_printk(KERN_DEBUG, &client->dev, \ > - "%s: " format, __func__, ## __VA_ARGS__); \ > - } while (0) > #define sil164_info(client, format, ...) \ > dev_info(&client->dev, format, __VA_ARGS__) > #define sil164_err(client, format, ...) \ > @@ -359,8 +354,8 @@ sil164_probe(struct i2c_client *client, const struct i2c_device_id *id) > int rev = sil164_read(client, SIL164_REVISION); > > if (vendor != 0x1 || device != 0x6) { > - sil164_dbg(client, "Unknown device %x:%x.%x\n", > - vendor, device, rev); > + drm_dev_dbg(&client->dev, DRM_UT_KMS, > + "Unknown device %x:%x.%x\n", vendor, device, rev); we have a macro for that :-) #define drm_dbg_kms(drm, fmt, ...) \ - drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_KMS, fmt, ##__VA_ARGS__) + drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_DBG_CLASS_KMS, fmt, ##__VA_ARGS__) and again below.