From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A5EC433F5 for ; Thu, 18 Nov 2021 03:41:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9122D61ABD for ; Thu, 18 Nov 2021 03:41:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9122D61ABD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCDDB6E52F; Thu, 18 Nov 2021 03:41:39 +0000 (UTC) Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECCF96E52F for ; Thu, 18 Nov 2021 03:41:38 +0000 (UTC) Received: by mail-ua1-x930.google.com with SMTP id i6so10698936uae.6 for ; Wed, 17 Nov 2021 19:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nM+ilNHr8Jh1IA59axtY4h7kpnXK6OLprg2Adk0fxuk=; b=P7JhcxD/dpomFqjv4CZPSkgHolofBTNTsbMJVYTTd+W3uJ7JN67a1MXFC6pQyzdUSg YiQVt5z1Lpykku+daRkbwn/b+6Sh2wn6ARjjTA5jZtwLsV8uKWvO0EHOt58WbvrQkhVb BJtZeRhGRUFf9+T3p+1RoifADytk8r+3epb1ShAZIyYGMs3xVA8wE9zqUJ+XdrrYqyOc vEZE46emMVg+HA5we5GQmlINhRw3Uk9TS3/ZpDiCuy53o4iuNMmtX/4Vxg+PACdCpvn5 irJG6iy6OP5fq9tt/UG9X2GFXTonVWUA+DpNWjTBjjpe+FH3kIhpIP4p2MyvDSMgBXNI 69cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nM+ilNHr8Jh1IA59axtY4h7kpnXK6OLprg2Adk0fxuk=; b=OIv4Bo1Ln4ywh3lYsw+CHQSr4kBDtzr6PVI/+RydMC3xnA24NRWqwVvGS8aj66rkTG JQgt15/QEfWQ2Ia7qL8Fxj357oJ7U04tIKAV3CY90ynXG3uwWdwVhA6ZignhuMycTz/d szmVMPrLIlKg5wTKCjAWfTGZKH0MjlG0ZElVGEiEV2A/QqVpsGlEfarmrLRLAjUWLiAb sy9iFWyUUlAzHgy9KQQqtVJMw9b8DGZaitVq2p5jDMLaQkp+MDpmcxIEgoBmR21Jv/gm 6fZvFvtoqHP3NiPpaBlK5EI74YJ7aSmXP8HoAMpQ0Tze22XkdPNbCrt7omViNycZnTTB HBqw== X-Gm-Message-State: AOAM530vHQaOKRPbUfA0qkilld1kiNBemArVCuZs1bs5MS3R6zc+SJwd Sg3TBv7iq3gMqe39yXaZakzRCMRU+8Yi/MU57RU= X-Google-Smtp-Source: ABdhPJzO9OXrSNbqAdTzWGxHcWIrsHLRKhgAbR6ZltlK9edEI/DVjoM7gtflR9FVvK/T9x+Kvc/C+z4Vh5+FYgjgWmI= X-Received: by 2002:a67:ca92:: with SMTP id a18mr76696187vsl.11.1637206897834; Wed, 17 Nov 2021 19:41:37 -0800 (PST) MIME-Version: 1.0 References: <87fsrx3eed.fsf@intel.com> In-Reply-To: From: jim.cromie@gmail.com Date: Wed, 17 Nov 2021 20:41:11 -0700 Message-ID: Subject: Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name To: Claudio Suarez Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sam Ravnborg , dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 15, 2021 at 12:40 PM Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > > >> Hi Claudio, > > >> > > >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > > >> > The prefered way to log connectors is [CONNECTOR:id:name]. Change = it in > > >> > drm core programs. > > >> > > > >> > Suggested-by: Ville Syrj=C3=A4l=C3=A4 > > >> > Signed-off-by: Claudio Suarez > > >> > > >> While touching all these logging calls, could you convernt them to t= he > > >> newer drm_dbg_kms variants? > > >> DRM_DEBUG_* are all deprecated. > > >> > > > > > > Yes, I can, but it is recommended to do it in a different patch: > > > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.htm= l#separate-your-changes > > > > > > C&P: > > > "Separate your changes > > > Separate each logical change into a separate patch. > > > For example, if your changes include both bug fixes and performance e= nhancements..." > > > > > > > > > I will study and send a new separate patch with your suggestion. > > > > I feel these logging changes are the types of changes where I'd err on > > the side of fewer patches than strictly following the above guidelines. > > To size the problem: > - there are about 3434 references to DRM_DEBUG_* in all the drm code, all= drivers. > - there are 413 references to DRM_DEBUG_* in the drm core code, only 66 o= f > them are related to connectors. > - there are 62 references to DRM_ERR* and 7 references to DRM_INFO in > the drm core programs. > > I meant I can make two patches: > 1 - this one with the change to CONNECTOR:id:name (29 changes) Is there a "committee" that makes or coordinates these log-facing changes ? The reason I ask is that Ive proposed that the DRM_UT_ be replaced by a set of prefix strings; "drm:core:" "drm:kms:" etc. If the DRM_DEBUG_* etc api were converted to use pr_debug, then dyndbg could optimize away the drm_debug_enabled() overheads. dyndbg would enable those classes of drm-debug callsites using #> echo module drm format drm:kms: > /proc/dyndbg/control the patchset includes a macro to declare a bit-field to implement drm.debug https://patchwork.freedesktop.org/series/96328/ how would one (hope to) coordinate changes like this ?