From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBDCBC433F5 for ; Thu, 30 Sep 2021 03:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC5B6613D3 for ; Thu, 30 Sep 2021 03:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347990AbhI3Dj0 (ORCPT ); Wed, 29 Sep 2021 23:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346796AbhI3DjZ (ORCPT ); Wed, 29 Sep 2021 23:39:25 -0400 Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE52C06161C for ; Wed, 29 Sep 2021 20:37:43 -0700 (PDT) Received: by mail-vk1-xa32.google.com with SMTP id s137so2174806vke.11 for ; Wed, 29 Sep 2021 20:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=BNthy7e7lNpu4+NE9vBtOHHjcEgbb9FfvTE2xiomHVM5k2AoSstsZb0Ib/bCmpHFL2 I7MR8CYJ1bz2mS6+go3Vk3zlHbpEz2YpzUW4xC+aZL+sl50WG8u78lofZsgMmXGZO6wh SLuR9F9VRZ68fE7aorklrfFUs40JM6A2qD1kgg8mj6vBGvoiR/kUJ0cnY9Shc0zUkdmu ZSWq3OAoyiTyhP074mbKhtSX7Dif1MwN/KE1ylJ708rkMwt1FA6CQhcKE2gVly5xOd3G cJOK7OgaI/JneKqOYeXV4utbWJjLCypgybzg8yYzI27DyrECFZKR+YY/IVrB4p1G4/h5 jiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=efFVIj8DlV7Y1B1/fzhlV3DfmUk9bc3dLniD9WLaaaMRIz7ZAb27f/v1BCKTOHvuDA tfuIlcVBxT1vi+tawe1O0oU7V16nv/Y8v8cl5OVU3xlcb6WRunJp9amzeoeZu9rFuT6y joeyGIv0cpV6ezVOjZFeaCExzyKGgWY+Ub19tcdcWyvDFlbqMbX70lT5knDCrKg38xig q/UrLKHQWbnsrUWW8SDgtSQGQtZhawBriZddk2N9GOs4rEAE6OcZrXGIowRmA3eztjhi xertewb1Yr565nV6oOkIxtl/tbVg8Hk3+ot5J3O2MRsdQ3vwMXOpZ2U0mJxdO55UdsL2 cINA== X-Gm-Message-State: AOAM533W3ub5RXf87PaB/o0zMykvumLi7sXYxYHWSV8oOBObNoHsi6Un 2tJZrKrF9cEZYgtWBdz8UXzTqsZQ3KoEXPFvbb7F/09H X-Google-Smtp-Source: ABdhPJziVCgaFcxzo8BazIHTTlgJGuIrwL4ipzqezGpkldOKIC4mrZi+hraS0wbXD15E+6UNWvZS0MEa3h+MYmpMsEU= X-Received: by 2002:a1f:1f0a:: with SMTP id f10mr1667502vkf.21.1632973062492; Wed, 29 Sep 2021 20:37:42 -0700 (PDT) MIME-Version: 1.0 References: <20210930014427.14239-1-jim.cromie@gmail.com> <20210930014427.14239-3-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Wed, 29 Sep 2021 21:37:16 -0600 Message-ID: Subject: Re: [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls To: Joe Perches Cc: dri-devel , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 8:08 PM Joe Perches wrote: > > On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > > There are blocks of DRM_DEBUG calls, consolidate their args into > > single calls. With dynamic-debug in use, each callsite consumes 56 > > bytes of callsite data, and this patch removes about 65 calls, so > > it saves ~3.5kb. > > > > no functional changes. > > No functional change, but an output logging content change. > > > RFC: this creates multi-line log messages, does that break any syslog > > conventions ? > > It does change the output as each individual DRM_DEBUG is a call to > __drm_dbg which is effectively: > > printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", > __builtin_return_address(0), &vaf); > > ok. that would disqualify the nouveau patch too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD740C433EF for ; Thu, 30 Sep 2021 03:37:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B8C2615E1 for ; Thu, 30 Sep 2021 03:37:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B8C2615E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6317F6EB45; Thu, 30 Sep 2021 03:37:45 +0000 (UTC) Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9808C6E2D5; Thu, 30 Sep 2021 03:37:43 +0000 (UTC) Received: by mail-vk1-xa29.google.com with SMTP id w68so2180124vkd.7; Wed, 29 Sep 2021 20:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=BNthy7e7lNpu4+NE9vBtOHHjcEgbb9FfvTE2xiomHVM5k2AoSstsZb0Ib/bCmpHFL2 I7MR8CYJ1bz2mS6+go3Vk3zlHbpEz2YpzUW4xC+aZL+sl50WG8u78lofZsgMmXGZO6wh SLuR9F9VRZ68fE7aorklrfFUs40JM6A2qD1kgg8mj6vBGvoiR/kUJ0cnY9Shc0zUkdmu ZSWq3OAoyiTyhP074mbKhtSX7Dif1MwN/KE1ylJ708rkMwt1FA6CQhcKE2gVly5xOd3G cJOK7OgaI/JneKqOYeXV4utbWJjLCypgybzg8yYzI27DyrECFZKR+YY/IVrB4p1G4/h5 jiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=4qoY6rZpKtsu31ZmuwpxhDQjDjHVuO8MQxdvAgvQAqGtuhfHA6FSIlhW5hPupPwt6A rtk/cvtF3JIYC0q48Oz9YTWV6i63qVCIeS5aRrqKSwi78mSyP1IijTZqVJDLfswshCx8 w2cYr8gwRNFEpCR8Fgz74Ro9MTt49TcpCoV6KXXCjtDutHKD0zvsvX60gsPU7hAUxFh7 QAFWyJECwwCU0qCV7Z8YQFHps8S6HrF2vDaQtAVUkIeS7TYfqhb495Hn5eb1TjVSRtXZ 4Ugm7VtrTZF7EGBD4vco0ZQ9JqOVUemqowRuK/pHZ0+kkLq50ayN2JBVljkFvPKR8dSQ idqw== X-Gm-Message-State: AOAM533UoJjx+ZPVQESgwQ7zuKg+7lSA7LUCnuXnj5FT7rMOk0zRWtkF Nlf1ukdXX3DckNGaKM1Te+IaM36T+e/EDDktaug= X-Google-Smtp-Source: ABdhPJziVCgaFcxzo8BazIHTTlgJGuIrwL4ipzqezGpkldOKIC4mrZi+hraS0wbXD15E+6UNWvZS0MEa3h+MYmpMsEU= X-Received: by 2002:a1f:1f0a:: with SMTP id f10mr1667502vkf.21.1632973062492; Wed, 29 Sep 2021 20:37:42 -0700 (PDT) MIME-Version: 1.0 References: <20210930014427.14239-1-jim.cromie@gmail.com> <20210930014427.14239-3-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Wed, 29 Sep 2021 21:37:16 -0600 Message-ID: Subject: Re: [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls To: Joe Perches Cc: dri-devel , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development , LKML Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 29, 2021 at 8:08 PM Joe Perches wrote: > > On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > > There are blocks of DRM_DEBUG calls, consolidate their args into > > single calls. With dynamic-debug in use, each callsite consumes 56 > > bytes of callsite data, and this patch removes about 65 calls, so > > it saves ~3.5kb. > > > > no functional changes. > > No functional change, but an output logging content change. > > > RFC: this creates multi-line log messages, does that break any syslog > > conventions ? > > It does change the output as each individual DRM_DEBUG is a call to > __drm_dbg which is effectively: > > printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", > __builtin_return_address(0), &vaf); > > ok. that would disqualify the nouveau patch too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3895AC433FE for ; Thu, 30 Sep 2021 03:37:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08018613D3 for ; Thu, 30 Sep 2021 03:37:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08018613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D616EB43; Thu, 30 Sep 2021 03:37:44 +0000 (UTC) Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9808C6E2D5; Thu, 30 Sep 2021 03:37:43 +0000 (UTC) Received: by mail-vk1-xa29.google.com with SMTP id w68so2180124vkd.7; Wed, 29 Sep 2021 20:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=BNthy7e7lNpu4+NE9vBtOHHjcEgbb9FfvTE2xiomHVM5k2AoSstsZb0Ib/bCmpHFL2 I7MR8CYJ1bz2mS6+go3Vk3zlHbpEz2YpzUW4xC+aZL+sl50WG8u78lofZsgMmXGZO6wh SLuR9F9VRZ68fE7aorklrfFUs40JM6A2qD1kgg8mj6vBGvoiR/kUJ0cnY9Shc0zUkdmu ZSWq3OAoyiTyhP074mbKhtSX7Dif1MwN/KE1ylJ708rkMwt1FA6CQhcKE2gVly5xOd3G cJOK7OgaI/JneKqOYeXV4utbWJjLCypgybzg8yYzI27DyrECFZKR+YY/IVrB4p1G4/h5 jiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4b3DOEuint+WBw7an5Qknmrkjl0i1y1HcTIoKU3zalE=; b=4qoY6rZpKtsu31ZmuwpxhDQjDjHVuO8MQxdvAgvQAqGtuhfHA6FSIlhW5hPupPwt6A rtk/cvtF3JIYC0q48Oz9YTWV6i63qVCIeS5aRrqKSwi78mSyP1IijTZqVJDLfswshCx8 w2cYr8gwRNFEpCR8Fgz74Ro9MTt49TcpCoV6KXXCjtDutHKD0zvsvX60gsPU7hAUxFh7 QAFWyJECwwCU0qCV7Z8YQFHps8S6HrF2vDaQtAVUkIeS7TYfqhb495Hn5eb1TjVSRtXZ 4Ugm7VtrTZF7EGBD4vco0ZQ9JqOVUemqowRuK/pHZ0+kkLq50ayN2JBVljkFvPKR8dSQ idqw== X-Gm-Message-State: AOAM533UoJjx+ZPVQESgwQ7zuKg+7lSA7LUCnuXnj5FT7rMOk0zRWtkF Nlf1ukdXX3DckNGaKM1Te+IaM36T+e/EDDktaug= X-Google-Smtp-Source: ABdhPJziVCgaFcxzo8BazIHTTlgJGuIrwL4ipzqezGpkldOKIC4mrZi+hraS0wbXD15E+6UNWvZS0MEa3h+MYmpMsEU= X-Received: by 2002:a1f:1f0a:: with SMTP id f10mr1667502vkf.21.1632973062492; Wed, 29 Sep 2021 20:37:42 -0700 (PDT) MIME-Version: 1.0 References: <20210930014427.14239-1-jim.cromie@gmail.com> <20210930014427.14239-3-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Wed, 29 Sep 2021 21:37:16 -0600 Message-ID: To: Joe Perches Cc: dri-devel , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development , LKML Content-Type: text/plain; charset="UTF-8" Subject: Re: [Intel-gfx] [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Sep 29, 2021 at 8:08 PM Joe Perches wrote: > > On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > > There are blocks of DRM_DEBUG calls, consolidate their args into > > single calls. With dynamic-debug in use, each callsite consumes 56 > > bytes of callsite data, and this patch removes about 65 calls, so > > it saves ~3.5kb. > > > > no functional changes. > > No functional change, but an output logging content change. > > > RFC: this creates multi-line log messages, does that break any syslog > > conventions ? > > It does change the output as each individual DRM_DEBUG is a call to > __drm_dbg which is effectively: > > printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", > __builtin_return_address(0), &vaf); > > ok. that would disqualify the nouveau patch too.