From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754350AbcCUKpT (ORCPT ); Mon, 21 Mar 2016 06:45:19 -0400 Received: from mail-qg0-f65.google.com ([209.85.192.65]:35253 "EHLO mail-qg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753332AbcCUKpN (ORCPT ); Mon, 21 Mar 2016 06:45:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> Date: Mon, 21 Mar 2016 11:45:12 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue From: Alexandre Torgue To: Chen-Yu Tsai Cc: Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , Joachim Eastwood , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : > Hi, > > On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE > wrote: >> Signed-off-by: Alexandre TORGUE >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> new file mode 100644 >> index 0000000..ada2aa4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> @@ -0,0 +1,32 @@ >> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >> + >> +This file documents platform glue layer for stmmac. >> +Please see stmmac.txt for the other unchanged properties. >> + >> +The device node has following properties. >> + >> +Required properties: >> +- compatible: Should be "st,stm32-dwmac" to select glue, and >> + "snps,dwmac-3.50a" to select IP vesrion. > > If you need have sort of hardware glue, then it is not compatible. > We could have the case where the glue is set by a bootloader. In this case, we will select IP version in compatible and we will use generic dwmac glue to probe stmmac driver. Regards Alex. > ChenYu > >> +- clocks: Must contain a phandle for each entry in clock-names. >> +- clock-names: Should be "stmmaceth" for the host clock. >> + Should be "tx-clk" for the MAC TX clock. >> + Should be "rx-clk" for the MAC RX clock. >> +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which >> + encompases the glue register, and the offset of the control register. >> +Example: >> + >> + ethernet0: dwmac@40028000 { >> + compatible = "st,stm32-dwmac", "snps,dwmac-3.50a"; >> + status = "disabled"; >> + reg = <0x40028000 0x8000>; >> + reg-names = "stmmaceth"; >> + interrupts = <0 61 0>, <0 62 0>; >> + interrupt-names = "macirq", "eth_wake_irq"; >> + clock-names = "stmmaceth", "tx-clk", "rx-clk"; >> + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>; >> + st,syscon = <&syscfg 0x4>; >> + snps,pbl = <8>; >> + snps,mixed-burst; >> + dma-ranges; >> + }; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.torgue@gmail.com (Alexandre Torgue) Date: Mon, 21 Mar 2016 11:45:12 +0100 Subject: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : > Hi, > > On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE > wrote: >> Signed-off-by: Alexandre TORGUE >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> new file mode 100644 >> index 0000000..ada2aa4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> @@ -0,0 +1,32 @@ >> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >> + >> +This file documents platform glue layer for stmmac. >> +Please see stmmac.txt for the other unchanged properties. >> + >> +The device node has following properties. >> + >> +Required properties: >> +- compatible: Should be "st,stm32-dwmac" to select glue, and >> + "snps,dwmac-3.50a" to select IP vesrion. > > If you need have sort of hardware glue, then it is not compatible. > We could have the case where the glue is set by a bootloader. In this case, we will select IP version in compatible and we will use generic dwmac glue to probe stmmac driver. Regards Alex. > ChenYu > >> +- clocks: Must contain a phandle for each entry in clock-names. >> +- clock-names: Should be "stmmaceth" for the host clock. >> + Should be "tx-clk" for the MAC TX clock. >> + Should be "rx-clk" for the MAC RX clock. >> +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which >> + encompases the glue register, and the offset of the control register. >> +Example: >> + >> + ethernet0: dwmac at 40028000 { >> + compatible = "st,stm32-dwmac", "snps,dwmac-3.50a"; >> + status = "disabled"; >> + reg = <0x40028000 0x8000>; >> + reg-names = "stmmaceth"; >> + interrupts = <0 61 0>, <0 62 0>; >> + interrupt-names = "macirq", "eth_wake_irq"; >> + clock-names = "stmmaceth", "tx-clk", "rx-clk"; >> + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>; >> + st,syscon = <&syscfg 0x4>; >> + snps,pbl = <8>; >> + snps,mixed-burst; >> + dma-ranges; >> + }; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel