From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998AbcDDOkv (ORCPT ); Mon, 4 Apr 2016 10:40:51 -0400 Received: from mail-qg0-f66.google.com ([209.85.192.66]:33259 "EHLO mail-qg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541AbcDDOkt (ORCPT ); Mon, 4 Apr 2016 10:40:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> <20160321124043.GA26873@rob-hp-laptop> Date: Mon, 4 Apr 2016 16:40:47 +0200 Message-ID: Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue From: Alexandre Torgue To: Joachim Eastwood Cc: Rob Herring , Chen-Yu Tsai , Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, 2016-03-22 17:11 GMT+01:00 Alexandre Torgue : > Hi guys, > > I will fix typo issues (s/vesrion/version and ethernet @). > > Concerning compatible string. For sure "snps,dwmac-3.50a" string is > not used inside glue driver. > I perfere to keep it for information but if you really want that I > remove it I will not block ;) > > 2016-03-21 16:36 GMT+01:00 Joachim Eastwood : >> On 21 March 2016 at 13:40, Rob Herring wrote: >>> On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: >>>> Hi, >>>> >>>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>>> wrote: >>>> > +- clocks: Must contain a phandle for each entry in clock-names. >>>> > +- clock-names: Should be "stmmaceth" for the host clock. >>> > We can remove host clock (stmmac eth) entry here and refer to > stmmac.txt binding for common entry > >>> This doesn't sound like the clock input signal name... >>> >>>> > + Should be "tx-clk" for the MAC TX clock. >>>> > + Should be "rx-clk" for the MAC RX clock. >>> >>> How can other DWMAC blocks not have these clocks? The glue can't really >>> add these clocks. It could combine them into one or a new version of >>> DWMAC could have a different number of clock inputs. So if there is >>> variation here, then some of the bindings are probably wrong. I guess >>> the only change I'm suggesting is possibly moving these into common >>> binding doc. >> >> The LPC18xx implementation probably have these clocks as well but the >> LPC1850 user manual only documents the main clock. Someone with access >> to the IP block doc from Synopsys should be able to check which clocks >> the MAC really needs. >> >> Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx". >> These are probably the same as stm32 needs so maybe use these names >> and move them into the main doc and update the rockchip binding. >> > I think we can use same name. But I have a doubt on moving it in a > common bindings (maybe I don't well understood). When you say "common > binding file" is it "stmmac.txt" binding ? If yes does it mean that we > have to control it inside stmmac driver (no more in glue) ? In this > case those clocks will become "required" for stm32 and rockship but > not for others chip. It could create confusion? A gentle ping. Can you give me your feedback please ? I will send next patchset version according to your answer. Thanks in advance Alex > > Best regards > > Alex > >> >> regards, >> Joachim Eastwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Torgue Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue Date: Mon, 4 Apr 2016 16:40:47 +0200 Message-ID: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> <20160321124043.GA26873@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Rob Herring , Chen-Yu Tsai , Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , linux-kernel , linux-arm-kernel To: Joachim Eastwood Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Rob, 2016-03-22 17:11 GMT+01:00 Alexandre Torgue : > Hi guys, > > I will fix typo issues (s/vesrion/version and ethernet @). > > Concerning compatible string. For sure "snps,dwmac-3.50a" string is > not used inside glue driver. > I perfere to keep it for information but if you really want that I > remove it I will not block ;) > > 2016-03-21 16:36 GMT+01:00 Joachim Eastwood : >> On 21 March 2016 at 13:40, Rob Herring wrote: >>> On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: >>>> Hi, >>>> >>>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>>> wrote: >>>> > +- clocks: Must contain a phandle for each entry in clock-names. >>>> > +- clock-names: Should be "stmmaceth" for the host clock. >>> > We can remove host clock (stmmac eth) entry here and refer to > stmmac.txt binding for common entry > >>> This doesn't sound like the clock input signal name... >>> >>>> > + Should be "tx-clk" for the MAC TX clock. >>>> > + Should be "rx-clk" for the MAC RX clock. >>> >>> How can other DWMAC blocks not have these clocks? The glue can't really >>> add these clocks. It could combine them into one or a new version of >>> DWMAC could have a different number of clock inputs. So if there is >>> variation here, then some of the bindings are probably wrong. I guess >>> the only change I'm suggesting is possibly moving these into common >>> binding doc. >> >> The LPC18xx implementation probably have these clocks as well but the >> LPC1850 user manual only documents the main clock. Someone with access >> to the IP block doc from Synopsys should be able to check which clocks >> the MAC really needs. >> >> Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx". >> These are probably the same as stm32 needs so maybe use these names >> and move them into the main doc and update the rockchip binding. >> > I think we can use same name. But I have a doubt on moving it in a > common bindings (maybe I don't well understood). When you say "common > binding file" is it "stmmac.txt" binding ? If yes does it mean that we > have to control it inside stmmac driver (no more in glue) ? In this > case those clocks will become "required" for stm32 and rockship but > not for others chip. It could create confusion? A gentle ping. Can you give me your feedback please ? I will send next patchset version according to your answer. Thanks in advance Alex > > Best regards > > Alex > >> >> regards, >> Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.torgue@gmail.com (Alexandre Torgue) Date: Mon, 4 Apr 2016 16:40:47 +0200 Subject: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> <20160321124043.GA26873@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, 2016-03-22 17:11 GMT+01:00 Alexandre Torgue : > Hi guys, > > I will fix typo issues (s/vesrion/version and ethernet @). > > Concerning compatible string. For sure "snps,dwmac-3.50a" string is > not used inside glue driver. > I perfere to keep it for information but if you really want that I > remove it I will not block ;) > > 2016-03-21 16:36 GMT+01:00 Joachim Eastwood : >> On 21 March 2016 at 13:40, Rob Herring wrote: >>> On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: >>>> Hi, >>>> >>>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>>> wrote: >>>> > +- clocks: Must contain a phandle for each entry in clock-names. >>>> > +- clock-names: Should be "stmmaceth" for the host clock. >>> > We can remove host clock (stmmac eth) entry here and refer to > stmmac.txt binding for common entry > >>> This doesn't sound like the clock input signal name... >>> >>>> > + Should be "tx-clk" for the MAC TX clock. >>>> > + Should be "rx-clk" for the MAC RX clock. >>> >>> How can other DWMAC blocks not have these clocks? The glue can't really >>> add these clocks. It could combine them into one or a new version of >>> DWMAC could have a different number of clock inputs. So if there is >>> variation here, then some of the bindings are probably wrong. I guess >>> the only change I'm suggesting is possibly moving these into common >>> binding doc. >> >> The LPC18xx implementation probably have these clocks as well but the >> LPC1850 user manual only documents the main clock. Someone with access >> to the IP block doc from Synopsys should be able to check which clocks >> the MAC really needs. >> >> Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx". >> These are probably the same as stm32 needs so maybe use these names >> and move them into the main doc and update the rockchip binding. >> > I think we can use same name. But I have a doubt on moving it in a > common bindings (maybe I don't well understood). When you say "common > binding file" is it "stmmac.txt" binding ? If yes does it mean that we > have to control it inside stmmac driver (no more in glue) ? In this > case those clocks will become "required" for stm32 and rockship but > not for others chip. It could create confusion? A gentle ping. Can you give me your feedback please ? I will send next patchset version according to your answer. Thanks in advance Alex > > Best regards > > Alex > >> >> regards, >> Joachim Eastwood