From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6921FC4167E for ; Thu, 14 Apr 2022 14:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350906AbiDNO3D (ORCPT ); Thu, 14 Apr 2022 10:29:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343966AbiDNNjc (ORCPT ); Thu, 14 Apr 2022 09:39:32 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A7DA99EF5; Thu, 14 Apr 2022 06:35:57 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id i20so9424343ybj.7; Thu, 14 Apr 2022 06:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=usbrVmh/IqZeGrbdE2M9/Szfr5yBTnD3ZEUOMvSshiE=; b=NLzWJaSJZPz1VxfJ8V35JeiQ1OKP+tDwmCDOL7OEXoBRqFaqNqB1W8N4bJJrl5SRDO BFPtv1bbVEw/tMuvepFWesW4JU7SeKkwbBPXYSfh/t5/IZOneS7duUAwQasMnSpiITQ9 XndS1oIdD9jLUoeqTbuMs7OZ+I/NQzLvN3tLEEGwkU7+JFcFcjsh9TbKTJKTjyVu18KN 2owBNh8/ILzG/g2vY0LQzUx0JdQxfT181fGTsE7mqO3js9KsHvu827tXz3XoV6PO3F2e 4RFn15p8gCznyV8aiDlpQhf49jqef/UFlYcIZlfK3lbgv6UwpD4c7HKg1X1kDqU123ez /lAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=usbrVmh/IqZeGrbdE2M9/Szfr5yBTnD3ZEUOMvSshiE=; b=wcty3/V9HCLzKzMZgWfQeTeFsxbKCvWkyqw3VwRjFDxwUEHfdX2YfBMhsu6X4Dn/iE Fu/ptF3ljHDOGbDoEWUjGBHxsmRfyM5xj28ym6jWptQq99HUk99LmXd/PSQq7GDFWcOI VvHP4C7Q5xTknE3Xb+Hh8VQo5RS0QrwSXwUfxgi3NHhieg3CXPicHa82urkRLwsqU/W+ UiCaK1CFCoN2QfX9RVJ1sg6m4/GKCnK71QajpYRJdLMDZHHqsbV30HvZqT8cXFhIsjUw ddGpiib3Ljof5mw3DqEWUKg3oV7zZMJqd6bh2gG72fjfeOVxt5JEhLbztw9LvXYETFkx Zyog== X-Gm-Message-State: AOAM533DzkhzlcLJUO08Sv6jAOivYREyNqBYoGdyalyKtMItJaHJcmOg wdfqwAtZ+w+yPX7bYiPQ8M00JBN2k5ST5x9BbwNPX25JqBI= X-Google-Smtp-Source: ABdhPJwopzv0ttPI92q96WOpOVANWZ/UA4QN3jGSBMSpKFajdl7+sC2a5dQBmaIJ77V2WoYOt6pYigc+WE79LYNZ87g= X-Received: by 2002:a05:6902:1206:b0:641:bc56:7444 with SMTP id s6-20020a056902120600b00641bc567444mr1819943ybu.376.1649943356542; Thu, 14 Apr 2022 06:35:56 -0700 (PDT) MIME-Version: 1.0 References: <20220330132152.4568-1-jiangshanlai@gmail.com> <20220330132152.4568-4-jiangshanlai@gmail.com> <683974e7-5801-e289-8fa4-c8a8d21ec1b2@redhat.com> In-Reply-To: From: Lai Jiangshan Date: Thu, 14 Apr 2022 21:35:45 +0800 Message-ID: Subject: Re: [RFC PATCH V3 3/4] KVM: X86: Alloc role.pae_root shadow page To: Paolo Bonzini Cc: Sean Christopherson , LKML , kvm@vger.kernel.org, Lai Jiangshan , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022 at 5:32 PM Lai Jiangshan wrote: > > All new kinds of sp added in this patchset are in the hash too. > I think role.guest_pae_root is needed to distinguish it from a sp for a level-3 guest page in a 4-level pagetable. Or just role.guest_root_level(or role.root_level) and it can replace role.passthrough_depth and role.guest_pae_root and role.pae_root. role.pae_root will be (role.root_level == 3 || role.root_level == 2) && role.level == 3 && (host is 32bit || !tdp_enabled)