All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
	Lai Jiangshan <jiangshan.ljs@antgroup.com>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH 2/7] x86/entry: Move PTI_USER_* to arch/x86/include/asm/processor-flags.h
Date: Wed, 11 May 2022 20:40:38 +0800	[thread overview]
Message-ID: <CAJhGHyCXCUDe_grNa9XdLXuCJYcX35G0m3KvjWnSvgYUApLbcA@mail.gmail.com> (raw)
In-Reply-To: <87h75wgycl.ffs@tglx>

On Wed, May 11, 2022 at 6:25 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Wed, May 11 2022 at 15:27, Lai Jiangshan wrote:
> > From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> >
> > These constants will be also used in C file.
> >
> > Move them to arch/x86/include/asm/processor-flags.h which already has
> > a kin X86_CR3_PTI_PCID_USER_BIT defined in it.
> >
> > Remove PTI_PGTABLE_SWITCH_BIT and replace it with PTI_USER_PGTABLE_BIT
> > since they are the same in meaning and value.
>
> Just from looking at the patch it's obvious that it breaks the 32bit
> CONFIG_PAGETABLE_ISOLATION=y build. Sigh.

Ahhh.
Thank you!

I'm sorry and I will move the "#ifdef CONFIG_X86_64" down a
little bit in arch/x86/include/asm/processor-flags.h.

Thanks
Lai

  reply	other threads:[~2022-05-11 12:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  7:27 [PATCH 0/7] x86/entry: Convert error_entry() to C code Lai Jiangshan
2022-05-11  7:27 ` [PATCH 1/7] x86/entry: Introduce __entry_text for entry code written in C Lai Jiangshan
2022-05-11 18:01   ` Nick Desaulniers
2022-05-11 19:27     ` Miguel Ojeda
2022-05-11 19:34       ` Nick Desaulniers
2022-05-11 19:41         ` Miguel Ojeda
2022-05-11 20:09     ` Thomas Gleixner
2022-05-11  7:27 ` [PATCH 2/7] x86/entry: Move PTI_USER_* to arch/x86/include/asm/processor-flags.h Lai Jiangshan
2022-05-11 10:25   ` Thomas Gleixner
2022-05-11 12:40     ` Lai Jiangshan [this message]
2022-05-11  7:27 ` [PATCH 3/7] x86: Mark __native_read_cr3() & native_write_cr3() as __always_inline Lai Jiangshan
2022-05-11  7:27 ` [PATCH 4/7] x86/entry: Add arch/x86/entry/entry64.c for C entry code Lai Jiangshan
2022-05-11  7:27 ` [PATCH 5/7] x86/entry: Add the C verion of SWITCH_TO_KERNEL_CR3 as switch_to_kernel_cr3() Lai Jiangshan
2022-05-11  7:27 ` [PATCH 6/7] x86/traps: Add fence_swapgs_{user,kernel}_entry() and user_entry_swapgs_and_fence() Lai Jiangshan
2022-05-11  7:27 ` [PATCH 7/7] x86/entry: Implement the whole error_entry() as C code Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJhGHyCXCUDe_grNa9XdLXuCJYcX35G0m3KvjWnSvgYUApLbcA@mail.gmail.com \
    --to=jiangshanlai@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jiangshan.ljs@antgroup.com \
    --cc=jpoimboe@redhat.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.