From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755031AbbAWEEH (ORCPT ); Thu, 22 Jan 2015 23:04:07 -0500 Received: from mail-vc0-f173.google.com ([209.85.220.173]:59121 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbbAWEEF (ORCPT ); Thu, 22 Jan 2015 23:04:05 -0500 MIME-Version: 1.0 In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> From: Pranith Kumar Date: Thu, 22 Jan 2015 23:03:34 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n To: Stewart Smith Cc: Michael Ellerman , Rob Herring , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Mahesh Salgaonkar , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith wrote: > Pranith Kumar writes: >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >>>> return 0. Check for these return values and skip registering the dump buffer. >>>> >>>> Signed-off-by: Pranith Kumar >>>> CC: Michael Ellerman >>>> --- >>>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>> >>> What changed since v1? I don't see anything? >>> >> >> Nothing in this patch but there is a v2 of the first patch in this >> series, so had to resend this patch with a v2. > > You also missed my Reviewed-by :) > Sincere apologies for the oversight. Maintainers, could you please add this Reviewed-by tag when picking this up? Reviewed-by: Stewart Smith Thanks! -- Pranith From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-x235.google.com (mail-vc0-x235.google.com [IPv6:2607:f8b0:400c:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 105BF1A0EB7 for ; Fri, 23 Jan 2015 15:04:07 +1100 (AEDT) Received: by mail-vc0-f181.google.com with SMTP id id10so1847390vcb.12 for ; Thu, 22 Jan 2015 20:04:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> From: Pranith Kumar Date: Thu, 22 Jan 2015 23:03:34 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n To: Stewart Smith Content-Type: text/plain; charset=UTF-8 Cc: Rob Herring , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Mahesh Salgaonkar , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith wrote: > Pranith Kumar writes: >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >>>> return 0. Check for these return values and skip registering the dump buffer. >>>> >>>> Signed-off-by: Pranith Kumar >>>> CC: Michael Ellerman >>>> --- >>>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>> >>> What changed since v1? I don't see anything? >>> >> >> Nothing in this patch but there is a v2 of the first patch in this >> series, so had to resend this patch with a v2. > > You also missed my Reviewed-by :) > Sincere apologies for the oversight. Maintainers, could you please add this Reviewed-by tag when picking this up? Reviewed-by: Stewart Smith Thanks! -- Pranith