From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbbAVOfM (ORCPT ); Thu, 22 Jan 2015 09:35:12 -0500 Received: from mail-vc0-f172.google.com ([209.85.220.172]:36099 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbbAVOfI (ORCPT ); Thu, 22 Jan 2015 09:35:08 -0500 MIME-Version: 1.0 In-Reply-To: <1421903958.4598.4.camel@ellerman.id.au> References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> From: Pranith Kumar Date: Thu, 22 Jan 2015 09:34:37 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n To: Michael Ellerman Cc: Benjamin Herrenschmidt , Paul Mackerras , Mahesh Salgaonkar , Anton Blanchard , Neelesh Gupta , Joel Stanley , Vasant Hegde , Rob Herring , "open list:LINUX FOR POWERPC..." , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: > On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >> return 0. Check for these return values and skip registering the dump buffer. >> >> Signed-off-by: Pranith Kumar >> CC: Michael Ellerman >> --- >> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >> 1 file changed, 6 insertions(+) > > What changed since v1? I don't see anything? > Nothing in this patch but there is a v2 of the first patch in this series, so had to resend this patch with a v2. Thanks! -- Pranith From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-x22d.google.com (mail-vc0-x22d.google.com [IPv6:2607:f8b0:400c:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 02C921A0E7E for ; Fri, 23 Jan 2015 01:35:11 +1100 (AEDT) Received: by mail-vc0-f173.google.com with SMTP id id10so579468vcb.4 for ; Thu, 22 Jan 2015 06:35:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1421903958.4598.4.camel@ellerman.id.au> References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> From: Pranith Kumar Date: Thu, 22 Jan 2015 09:34:37 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n To: Michael Ellerman Content-Type: text/plain; charset=UTF-8 Cc: Rob Herring , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Mahesh Salgaonkar , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: > On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >> return 0. Check for these return values and skip registering the dump buffer. >> >> Signed-off-by: Pranith Kumar >> CC: Michael Ellerman >> --- >> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >> 1 file changed, 6 insertions(+) > > What changed since v1? I don't see anything? > Nothing in this patch but there is a v2 of the first patch in this series, so had to resend this patch with a v2. Thanks! -- Pranith