From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768C6C433E0 for ; Tue, 4 Aug 2020 09:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B52222D01 for ; Tue, 4 Aug 2020 09:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LMbQEkRc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729385AbgHDJsy (ORCPT ); Tue, 4 Aug 2020 05:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbgHDJsx (ORCPT ); Tue, 4 Aug 2020 05:48:53 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FE9C06174A; Tue, 4 Aug 2020 02:48:53 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id o13so21831458pgf.0; Tue, 04 Aug 2020 02:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hg8Qv9n5WNyPEJBzVokQio7quoYDQddeKfpiH64yPFA=; b=LMbQEkRcjUfHXw8ytwWW0WO3GgVrO+i3HjZUS94+ApzAkYhajuff/4eZFLZmbSK4bC d/rT8MUtyRDXp/FQCikE48qmLGZOY66FZGnzVa6NpN5/9VocD8dS/DwSCwzzw96XAx/C CR+oEZC7RAROP2FRut9Zv42SjP9g0OVKnm0IJD0+oG10HEaeYuBARF9MTNnReS3sM3PK Uc/6K11QUi1bdbCGFSF34Dv04lcHQOcn1nfuJ0Ts9NrcSxYkXAurIO3l1tXTKUp8VJs8 dUjWK3xu7O7PT7JwOKEb/Tjydd2ogN5DyqU3RpsFdCA4zImBN9xCZW6GX16CScHBPdBF bgbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hg8Qv9n5WNyPEJBzVokQio7quoYDQddeKfpiH64yPFA=; b=sCOmCWqkjk8XJBhiw2TRBWaSSom1PVaDHI/C/u+PTa/wRRw8K7TqjZhsQJJXjxHZA8 M09W9gAq3OEJYT8PLajZRXUFdCwOXmstI/X5v8VTWUW+Yq/OJIHUxK2o+9ekNantrWL6 2TwQ/hZ1fEyqYnbBlZGn+WzottZYLO15I2R/YiOkkDg0T+ynycRP3wgbThWCwHbKmPan XhRNAGpP02FCiJaYDak01+SRQnhA60m1WmPGAuHT+7954U8byV91fAKG3qXIYc1TRCrJ buZ7tMptLT9yGGBY7oKkfIpFj79EbokxRIJkPEEk52ldEvarza+fUs32C3Bi+vYNkedt 9wMA== X-Gm-Message-State: AOAM533/8buaA1eUsj9u512KRlCe2QIK9d5f0Cnd1k7Ghv8gV5kHqqeJ tZUG/02ZWNruutyqSny682ejPoJPxEHRrhGPLi8= X-Google-Smtp-Source: ABdhPJybKXGbFap3TKijT0dD+vkqRoMpV6l290J8k1gLIvrXI37lgTvMzyVNLS6WMV0DvFfrSVCtimlE2ICcyBhJOYE= X-Received: by 2002:a63:5412:: with SMTP id i18mr19103370pgb.63.1596534533069; Tue, 04 Aug 2020 02:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20200730073702.16887-1-xie.he.0141@gmail.com> In-Reply-To: From: Xie He Date: Tue, 4 Aug 2020 02:48:42 -0700 Message-ID: Subject: Re: [PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len To: Martin Schiller , Willem de Bruijn Cc: "David S. Miller" , Jakub Kicinski , Linux Kernel Network Developers , LKML , Linux X25 Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 3, 2020 at 11:53 PM Martin Schiller wrote: > > I don't like the idea to get rid of the 1-byte header. > This header is also used in userspace, for example when using a tun/tap > interface for an XoT (X.25 over TCP) application. A change would > therefore have very far-reaching consequences. Thank you for your comment! This is very important information to me. Now I think it may be the best to keep the 1-byte header so that the kernel interface can be kept unchanged. > BTW: The linux x25 mailing list does not seem to work anymore. I've been > on it for some time now, but haven't received a single email from it. > I've tried to contact owner-linux-x25@vger.kernel.org, but only got an > "undeliverable" email back. I was suspecting that it was not working, too. I CC'd all my patches to the mail list but got no response from it. It appears that you were not able to receive my emails through it, too. > It would be great if you could add me to CC list of all versions of your > patches, so I don't need to "google" for any further related mails. OK. I'll surely do that! Thank you for taking time to review my patches! > So, what's the latest version of the patch now, which you want me to > review? It is at: http://patchwork.ozlabs.org/project/netdev/patch/20200802195046.402539-1-xie.he.0141@gmail.com/ Thank you so much for your review!