From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3BD7C282C0 for ; Wed, 23 Jan 2019 16:33:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5B15217D4 for ; Wed, 23 Jan 2019 16:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="CCHWeer5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbfAWQdg (ORCPT ); Wed, 23 Jan 2019 11:33:36 -0500 Received: from mail-ed1-f50.google.com ([209.85.208.50]:44658 "EHLO mail-ed1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfAWQdg (ORCPT ); Wed, 23 Jan 2019 11:33:36 -0500 Received: by mail-ed1-f50.google.com with SMTP id y56so2176371edd.11 for ; Wed, 23 Jan 2019 08:33:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ApODTmq6KUc/IDc3TBuvCmvniTr6I+fAEgN2YFaOjk=; b=CCHWeer53EBHeS3h0Da17ZWhcb3045inGfk6qhhkyg9h3OHsb1Bg0yif032eRvq4d9 Aii75F9xxvWtd4Lq9N1jzhaiGgBk3fSjgrFi1i1DzE3hdojpklCIQkV+tUvIupPqAVSY Cz+jTaFlZImQO6IKYhQaulsEOtpxlK+SXmPa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ApODTmq6KUc/IDc3TBuvCmvniTr6I+fAEgN2YFaOjk=; b=q21J2BqYmN2JGgx3jSNo2iz6RvN688sy+lCMdjG32dMiOfHo5UNi80Hwmq77BRLh1w bpiWr3tmHKpJCcJSWIIARBYP8e28E9lr3il1StKGqTwL5iS4PlgdLuoFvhweVlHCkEzK s+UL8FP1i73WPm7KN+TrPNZgYm5TFtXOE7V/nEGyLY5I3sPQ9Co5SsMfMPJ+KMOd/9vF ARrI5EJY+Z6fXusU+0Pysub6b0aTZQbj8ksWwEwT47CKEXxYnLUtUKSXSjf4wgaCxvRZ QhrcBJdKDJJy0hb12b7kD2t7q6fFJavHWuJ796KGnk7ddgJHUIVzQEV5WSZ252nNMSRT /d9Q== X-Gm-Message-State: AJcUukeOqmAF21/rP9XCktRRUKkyYbRJbHqK7i1f0FVHzCtDbsPzYsuN rqsgEekhac3DajUWbzfHRr/Bvet1aATclf/UY/erVQ== X-Google-Smtp-Source: ALg8bN4gQ3zPxyCiHLKwAr3QbUG7I72xlz6u4psyX0RLZQ8BWz+gtP8fDiTTa/MHIXND0tm1wg+5FcdHuIUKVV4bjVU= X-Received: by 2002:a50:9315:: with SMTP id m21mr3302117eda.58.1548261214372; Wed, 23 Jan 2019 08:33:34 -0800 (PST) MIME-Version: 1.0 References: <800cb3d3-c749-3f36-83ea-0375e67fbd33@cumulusnetworks.com> In-Reply-To: <800cb3d3-c749-3f36-83ea-0375e67fbd33@cumulusnetworks.com> From: Roopa Prabhu Date: Wed, 23 Jan 2019 08:33:27 -0800 Message-ID: Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script To: Nikolay Aleksandrov Cc: Stefano Brivio , David Ahern , Phil Sutter , Eric Garver , Tomas Dolezal , Stephen Hemminger , Lennert Buytenhek , netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 23, 2019 at 7:09 AM Nikolay Aleksandrov wrote: > > On 18/01/2019 19:00, Stefano Brivio wrote: > > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement > > of the standalone 'brctl' utility. > > > > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6, > > has no dependencies other than a POSIX shell, and it's less than half > > the binary size of brctl on x86_64. > > > > As many users (including myself) seem to find brctl usage vastly more > > intuitive than ip-link, possibly due to habit, this might be a lightweight > > approach to provide brctl syntax without the need to maintain bridge-utils > > any longer. > > > > Signed-off-by: Stefano Brivio > > Acked-by: Phil Sutter > > --- > > man/man8/Makefile | 5 +- > > man/man8/ip-brctl.8 | 187 +++++++++++++++ > > misc/Makefile | 9 +- > > misc/ip-brctl.in | 572 ++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 770 insertions(+), 3 deletions(-) > > create mode 100644 man/man8/ip-brctl.8 > > create mode 100755 misc/ip-brctl.in > > Hi, > IMO the effort should be towards improving iproute2 to be > easier to use and more intuitive. We should be pushing people to use the new tools > instead of trying to find workarounds to keep the old tools alive. > I do like to idea of deprecating bridge-utils, but I think it should be done > via improving ip/bridge enough to be pleasant to use. We will have to > maintain this compatibility layer forever if it gets accepted and we'll never > get rid of brctl this way. > +1, we should move people away from brtcl. there is enough confusion among users looking at bridge attributes., ip -d link show bridge -d link show brctl Adding a 4th one to the list is not going to ease the confusion. We should try to make the 'ip -d link show and bridge -d link show' outputs better. Any suggestions there from people will be useful.