From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B27BC282DA for ; Tue, 16 Apr 2019 14:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D719D20693 for ; Tue, 16 Apr 2019 14:28:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="DoAb6lbS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729613AbfDPO2o (ORCPT ); Tue, 16 Apr 2019 10:28:44 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:46702 "EHLO mail-ed1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfDPO2o (ORCPT ); Tue, 16 Apr 2019 10:28:44 -0400 Received: by mail-ed1-f41.google.com with SMTP id d1so18057293edd.13 for ; Tue, 16 Apr 2019 07:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2JZuPkYAqreJqrBQGSD+MitoEIu5XPVCG2OACUlJ1uY=; b=DoAb6lbSQheNIyRPaqBDXLQYQLqikCKMrcAS52EjVuwjtjWnr9VTNBhCxxX25kApqG +lZNzEUQQiXV1p5QlgdG4nwQ1nAHZr0+oFeeB3OSzqySNHZIFZMJjuN6ZRsmAjocUEqF vhCHOTTTRQsgDNlXtAiz7r91bd4hQMiSOC4ZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2JZuPkYAqreJqrBQGSD+MitoEIu5XPVCG2OACUlJ1uY=; b=Ri2a+5VypDqPMx6VYJ5KXuaXuQwSlQz36K5Xpi6ecXhmADVBdlJeDe3/K6JuWafE6a 5s0wTblENg6mH7/utejTCua5LU7DbffiFduRdolczhjIWz+3dT7YqQJAJkdISb4gVZYo /Prm1H1s7v5xx0KcaBNP5E6bMicwc61HNv33lHaWAZt7AJWmZeUs7j8YG25yMStETHDI aPP6emoJ5ORAkgRLqyiPucdCa3M8p+2yb5XtLTMIbdpbPsOdWuKMjkl2yU1Nz13CKbmR oOjemEyl2+nKfQNTSU4DlJyqbFkzogLGPDJLQMe5AWc1SbKb81iisiHD29wLkdEijNmp +qrg== X-Gm-Message-State: APjAAAVYQYqcWRva4RLYIKBpQwIr+2zCkRnrnAkks771PcDcmoTzO1PW laCWv4veAGOgEkHds+3AwnJ3xwvalnoLIjP8WHj6PQ== X-Google-Smtp-Source: APXvYqxRgQ2cCtLvTMxwNK67U/iWPqVEqKmf2rMTdmw2lAAHPOdLcZVbuFU4LZPuOE1//uaP2bAXhDXLn4PkOSP7Lgk= X-Received: by 2002:a17:906:f84:: with SMTP id q4mr43667911ejj.117.1555424922845; Tue, 16 Apr 2019 07:28:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Roopa Prabhu Date: Tue, 16 Apr 2019 07:28:33 -0700 Message-ID: Subject: Re: iproute2 broken vlan stats output To: Nikolay Aleksandrov Cc: Stephen Hemminger , network dev , David Ahern Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov wrote: > > Hi Stephen, > It seems standard (non-json) vlan stats output has been broken since commit: > 0f36267485e3 ("bridge: fix vlan show formatting") > > bridge -s vlan show output before commit 0f36267485e3: > port vlan id > br0 1 PVID untagged > RX: 0 bytes 0 packets > TX: 0 bytes 0 packets > eth4 1 PVID untagged > RX: 0 bytes 0 packets > TX: 0 bytes 0 packets > > bridge -s vlan show output after commit 0f36267485e3: > root@debian~/# bridge -s vlan > port vlan id > br0br0 1 PVID Egress Untagged > RX: 0 bytes 0 packets > TX: 0 bytes 0 packetseth4eth4 1 PVID Egress Untagged > RX: 0 bytes 0 packets > TX: 0 bytes 0 packetsroot@debian:~/# > :(. Looks like iproute2 should have selftests too. Its hard to catch these in code review.