All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Ahern <dsahern@gmail.com>, netdev <netdev@vger.kernel.org>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH iproute2 net-next 1/2] bridge: fdb get support
Date: Sat, 28 Sep 2019 13:20:24 -0700	[thread overview]
Message-ID: <CAJieiUie-C39YRXKNBsLoRze6C+hCx4yheLivuXqtc5edUD6fQ@mail.gmail.com> (raw)
In-Reply-To: <20190928084641.69233a5a@hermes.lan>

On Sat, Sep 28, 2019 at 8:46 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 27 Sep 2019 21:48:23 -0700
> Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
>
> Overall, looks good.
>
> > +     if (print_fdb(answer, (void *)stdout) < 0) {
>
> Cast to void is not necessary in C (it is in C++)

thats a copy/paste from iproute get code. will remove it and post v2, thx

  reply	other threads:[~2019-09-28 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  4:48 [PATCH iproute2 net-next 0/2] support for bridge fdb and neigh get Roopa Prabhu
2019-09-28  4:48 ` [PATCH iproute2 net-next 1/2] bridge: fdb get support Roopa Prabhu
2019-09-28 15:46   ` Stephen Hemminger
2019-09-28 20:20     ` Roopa Prabhu [this message]
2019-09-28  4:48 ` [PATCH iproute2 net-next 2/2] ipneigh: neigh " Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJieiUie-C39YRXKNBsLoRze6C+hCx4yheLivuXqtc5edUD6fQ@mail.gmail.com \
    --to=roopa@cumulusnetworks.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.