From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 232F9C10F0E for ; Mon, 15 Apr 2019 08:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8167206BA for ; Mon, 15 Apr 2019 08:09:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KiYHgGfF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbfDOIJX (ORCPT ); Mon, 15 Apr 2019 04:09:23 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:42846 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfDOIJX (ORCPT ); Mon, 15 Apr 2019 04:09:23 -0400 Received: by mail-yw1-f68.google.com with SMTP id e76so5692811ywa.9; Mon, 15 Apr 2019 01:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5FF98CIqtyE2Fy2k0bmkw2sa4GHJCZnGCxNLUt2DcAI=; b=KiYHgGfFv/KEzp1wWWwS0FbtdSCM5TpXwUpMmPbbQALgB9guG85e7+4W8Nittb+uRy PQ5cED9u5g8ZPMB1g/3QQgqFJukJKpj773r0XdES9gbnZ65s9k5S8KRd02CTL2XVRl7A IrjSDmQE3cRcOXS/CIN9VhiGRmVAk5YzJh6p9kzWS9f48QoVxqwmfmNaNu99QOh5uBbG laGIADRcGjcjAYA8inTtONueJUA4bSJ7JKMaRle3bqXkUBbBhpf8ORkqRVQAQP7L7gXe +CO4QVTorn/LgEDqt0oD4LXLRsISm2pzF9EUy/OiqtUlOtrVuOOoAl1RZkWfatmTpgAR 0BZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5FF98CIqtyE2Fy2k0bmkw2sa4GHJCZnGCxNLUt2DcAI=; b=Agf41Pyt5yyC0wBjvHKdPhTwOhxhFmPjjy1Ha+CjdQXe4cnCVUxqN/1OWwmbWyqTF3 p12W0jvkI9F6yihMuaT7mvRPGV+VhOPFATMr43ZqhkwUnlLeGrQFUIsFiT7ReIARa3N+ zxaS8OHQdSrS7k2MC8Fk+/PfkqNbBPTOBuKf49pc7LSLNyssnWESXCBPyme8crvOnoms /15as3dwZp4MrSV9oWqSxiZk6DYzWopp7AiGKd8482GDvDCXJSZCG/JFM+JlgaTXRGS+ LgW89ebq3gyAdGPTDKR8lznytDwVMdvRKliW9vyY2MAisc8Unoq/Lp4nbJ24r4/OTjNH n0/A== X-Gm-Message-State: APjAAAWFu3rkjnsXrCUMGmm98NgbuEfgTNymkEfRA3npoy9PTihYvEEY 8U9zevmrt5ZeWWUK55Uq4SZ7D77fR0ubNLKMNsQ= X-Google-Smtp-Source: APXvYqzhRrgNvHwN+eFuyBuzU6nIw9T1nkKQCMzCejwF4UoN95UKAGf9TwhVoAtboaG40hO56RWJkFwQvdhv3pTW5NY= X-Received: by 2002:a0d:d645:: with SMTP id y66mr58420161ywd.459.1555315762517; Mon, 15 Apr 2019 01:09:22 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> In-Reply-To: <20190415080443.frubh4ln4agrdsfe@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 15 Apr 2019 10:09:11 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , Jernej Skrabec , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, 15 Apr 2019 at 10:04, Maxime Ripard wro= te: > > Hi, > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > size and the possibility to output the master clock. > > However it's still compatible with the already existing driver for > > Allwiner H3. > > > > Add this compatible in the device-tree bindings documentation. > > How was this tested? Using Alsa utils on a Beelink GS1 and I check correct output sound on my home cinema. > > After looking at the datasheet, it looks like it's still significantly > different. In particular: > > - The MCLK divider isn't at the same offset We don't use the MCLK > - The bits to flush the FIFO aren't at the same offset > - The FIFO trigger levels aren't at the same offset > - The FIFO status register layout is almost entirely different We use DMA not FIFO Clement > > So it doesn't really look compatible to me > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Date: Mon, 15 Apr 2019 10:09:11 +0200 Message-ID: References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> Reply-To: peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190415080443.frubh4ln4agrdsfe@flea> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , Jernej Skrabec , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org Hi, On Mon, 15 Apr 2019 at 10:04, Maxime Ripard wro= te: > > Hi, > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > size and the possibility to output the master clock. > > However it's still compatible with the already existing driver for > > Allwiner H3. > > > > Add this compatible in the device-tree bindings documentation. > > How was this tested? Using Alsa utils on a Beelink GS1 and I check correct output sound on my home cinema. > > After looking at the datasheet, it looks like it's still significantly > different. In particular: > > - The MCLK divider isn't at the same offset We don't use the MCLK > - The bits to flush the FIFO aren't at the same offset > - The FIFO trigger levels aren't at the same offset > - The FIFO status register layout is almost entirely different We use DMA not FIFO Clement > > So it doesn't really look compatible to me > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3491FC10F0E for ; Mon, 15 Apr 2019 08:09:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6F2A206BA for ; Mon, 15 Apr 2019 08:09:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pklg0+uQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KiYHgGfF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6F2A206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=flrpleeygC6aTR9HrvM/JVSqEj3rC3OiKzLlu3HrNCI=; b=pklg0+uQapcPWX h+s+8vMfxljdcNFdntnvk7rToo6DE6ZbdFlNRSQ+p7InRKLgczUX20kK3hZ5L8OCgZuwWu2+w6WAV Mjw/O9vEXQ/+S5esYphumtLyb/PGMoRrAoqeWA1IsfzFtMI0qnFsEQrxnvzTMIbR15UGzqMYqO2O5 hWIhNgCXrb19HJmqlE5+2fAUjabp1CpcrXwaoqBJcFTGjR1pcwQANHfCLt4ExJTz6BY6kwuBiG5Mf JbWWVXYGuxxZ3sETra1jjavihwS5sgs4lxvvtSb7LxH+xNLa9eDMvvrO7Xm2G9glDwfaudJZSHpB8 GPm62gK1BbE120I6J1lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFwgA-0002a8-IQ; Mon, 15 Apr 2019 08:09:26 +0000 Received: from mail-yw1-xc43.google.com ([2607:f8b0:4864:20::c43]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFwg8-0002Zd-32 for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 08:09:25 +0000 Received: by mail-yw1-xc43.google.com with SMTP id m207so5696685ywd.5 for ; Mon, 15 Apr 2019 01:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5FF98CIqtyE2Fy2k0bmkw2sa4GHJCZnGCxNLUt2DcAI=; b=KiYHgGfFv/KEzp1wWWwS0FbtdSCM5TpXwUpMmPbbQALgB9guG85e7+4W8Nittb+uRy PQ5cED9u5g8ZPMB1g/3QQgqFJukJKpj773r0XdES9gbnZ65s9k5S8KRd02CTL2XVRl7A IrjSDmQE3cRcOXS/CIN9VhiGRmVAk5YzJh6p9kzWS9f48QoVxqwmfmNaNu99QOh5uBbG laGIADRcGjcjAYA8inTtONueJUA4bSJ7JKMaRle3bqXkUBbBhpf8ORkqRVQAQP7L7gXe +CO4QVTorn/LgEDqt0oD4LXLRsISm2pzF9EUy/OiqtUlOtrVuOOoAl1RZkWfatmTpgAR 0BZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5FF98CIqtyE2Fy2k0bmkw2sa4GHJCZnGCxNLUt2DcAI=; b=OMKYiI5KVKbZ5ztylx55YrXW1PKrazg8d4hOKRSUHlWXHRolME6g+yG6vRX0JHb/mm mUBopvFEfpFZsx5Qe6U/5wreorVMQ3ujqbCldD5LTO89K9xmSgMUsB2+GCyx71MONXI9 5kVtKfS0zgUJPVR59KnbohizI1XzY2Fdv7Bpmb+VKkMts1SHyXDyVxZv6VlxOjtI/nhj Maz50gTSlFrnOXZeIQU8aui8dhHFmp6xj/Gb+rsKUtUmPHQTbSdUXY4fjmIGg2YAIO0W Ni+lbU7jZZaqmquE0iykmcwZsvTQyaf4FIfwEmiXyQOVUR+TV23auT7kUBk7rkqH2WYo IL6A== X-Gm-Message-State: APjAAAVfskyqDHgNIPLw5+/F4ae85diBCGTEd0nXgd3QhHRzW9dIbi4n PFrbIAecuhwRc/rmSq5XN+qebvid+r9owtYzwYU= X-Google-Smtp-Source: APXvYqzhRrgNvHwN+eFuyBuzU6nIw9T1nkKQCMzCejwF4UoN95UKAGf9TwhVoAtboaG40hO56RWJkFwQvdhv3pTW5NY= X-Received: by 2002:a0d:d645:: with SMTP id y66mr58420161ywd.459.1555315762517; Mon, 15 Apr 2019 01:09:22 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> In-Reply-To: <20190415080443.frubh4ln4agrdsfe@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 15 Apr 2019 10:09:11 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_010924_129666_D8C8BF2C X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , linux-sunxi , linux-kernel , Chen-Yu Tsai , Rob Herring , Jagan Teki , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBNb24sIDE1IEFwciAyMDE5IGF0IDEwOjA0LCBNYXhpbWUgUmlwYXJkIDxtYXhpbWUu cmlwYXJkQGJvb3RsaW4uY29tPiB3cm90ZToKPgo+IEhpLAo+Cj4gT24gVGh1LCBBcHIgMTEsIDIw MTkgYXQgMTE6NDQ6MTlQTSArMDIwMCwgQ2zDqW1lbnQgUMOpcm9uIHdyb3RlOgo+ID4gQWxsd2lu bmVyIEg2IGhhcyBhIFNQRElGIGNvbnRyb2xsZXIgd2l0aCBhbiBpbmNyZWFzZSBvZiB0aGUgZmlm bwo+ID4gc2l6ZSBhbmQgdGhlIHBvc3NpYmlsaXR5IHRvIG91dHB1dCB0aGUgbWFzdGVyIGNsb2Nr Lgo+ID4gSG93ZXZlciBpdCdzIHN0aWxsIGNvbXBhdGlibGUgd2l0aCB0aGUgYWxyZWFkeSBleGlz dGluZyBkcml2ZXIgZm9yCj4gPiBBbGx3aW5lciBIMy4KPiA+Cj4gPiBBZGQgdGhpcyBjb21wYXRp YmxlIGluIHRoZSBkZXZpY2UtdHJlZSBiaW5kaW5ncyBkb2N1bWVudGF0aW9uLgo+Cj4gSG93IHdh cyB0aGlzIHRlc3RlZD8KClVzaW5nIEFsc2EgdXRpbHMgb24gYSBCZWVsaW5rIEdTMSBhbmQgSSBj aGVjayBjb3JyZWN0IG91dHB1dCBzb3VuZCBvbgpteSBob21lIGNpbmVtYS4KPgo+IEFmdGVyIGxv b2tpbmcgYXQgdGhlIGRhdGFzaGVldCwgaXQgbG9va3MgbGlrZSBpdCdzIHN0aWxsIHNpZ25pZmlj YW50bHkKPiBkaWZmZXJlbnQuIEluIHBhcnRpY3VsYXI6Cj4KPiAgIC0gVGhlIE1DTEsgZGl2aWRl ciBpc24ndCBhdCB0aGUgc2FtZSBvZmZzZXQKV2UgZG9uJ3QgdXNlIHRoZSBNQ0xLCj4gICAtIFRo ZSBiaXRzIHRvIGZsdXNoIHRoZSBGSUZPIGFyZW4ndCBhdCB0aGUgc2FtZSBvZmZzZXQKPiAgIC0g VGhlIEZJRk8gdHJpZ2dlciBsZXZlbHMgYXJlbid0IGF0IHRoZSBzYW1lIG9mZnNldAo+ICAgLSBU aGUgRklGTyBzdGF0dXMgcmVnaXN0ZXIgbGF5b3V0IGlzIGFsbW9zdCBlbnRpcmVseSBkaWZmZXJl bnQKV2UgdXNlIERNQSBub3QgRklGTwoKQ2xlbWVudAo+Cj4gU28gaXQgZG9lc24ndCByZWFsbHkg bG9vayBjb21wYXRpYmxlIHRvIG1lCj4KPiBNYXhpbWUKPgo+IC0tCj4gTWF4aW1lIFJpcGFyZCwg Qm9vdGxpbgo+IEVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKPiBodHRwczov L2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==