From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: Ethernet on my CycloneV broke since 4.9.124 Date: Wed, 31 Oct 2018 16:36:28 +0100 Message-ID: References: <61e0ddf2-a2b5-189a-06bc-ee0cd7bfd8b5@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org To: Dinh Nguyen Return-path: Received: from mail-yb1-f174.google.com ([209.85.219.174]:36014 "EHLO mail-yb1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbeKAAfL (ORCPT ); Wed, 31 Oct 2018 20:35:11 -0400 Received: by mail-yb1-f174.google.com with SMTP id w16-v6so6799857ybp.3 for ; Wed, 31 Oct 2018 08:36:40 -0700 (PDT) In-Reply-To: <61e0ddf2-a2b5-189a-06bc-ee0cd7bfd8b5@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: Hi Dinh, On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen wrote: > > Hi Clement, > > On 10/31/2018 08:01 AM, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi, > > > > The patch "net: stmmac: socfpga: add additional ocp reset line for > > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV > > board. > > > > When I boot i have this issue : > > > > socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2 > > socfpga-dwmac: probe of ff702000.ethernet failed with error -2 > > > > Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the= issue. > > > > Are you sure? I just booted v4.9.124 and did not see any errors. The > error should not appear because the commit is using > devm_reset_control_get_optional(). I'm booting on 4.9.130 actually, Agree with you that devm_reset_control_get_optional should not failed but checking other usage of this helper https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv6= 4xxx.c#L824 https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/su= n4i-ss-core.c#L259 Show that they don't check for errors except for PROBE_DEFER Thanks, Clement > > Dinh