From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C576AC46460 for ; Thu, 23 May 2019 14:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 956652133D for ; Thu, 23 May 2019 14:02:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S0WIOvfh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730863AbfEWOCk (ORCPT ); Thu, 23 May 2019 10:02:40 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:33989 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730323AbfEWOCk (ORCPT ); Thu, 23 May 2019 10:02:40 -0400 Received: by mail-yb1-f194.google.com with SMTP id v78so2319570ybv.1; Thu, 23 May 2019 07:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sqmYovtDH2Cha2ixUIjp55v47f+tfN+Y/9nD/H0oaXU=; b=S0WIOvfhxfwfAv7ibPxBjD1HBQmHhdi/cM0k2xwZ5e8ECTMVUNqunHYdnAhuKwbDjN Xu8BiJho9SPuTk4wu04jroQpaoDnl0YqNbEBdkaBe0laaCkOz5PxNJYrP4byiu9iu+Ni eV4lSa657lsml6+XQgvFORwIB0LQsbP42cOpgFiECUEFMVbmejiHv41dxvs0CX90H/zU eO/mQkOQphWmY9HEo7Bhr0TaEcA4QYzakZtp2LXeixe/zuJ9XD/QjJrLOVSYQGCPuHv6 dIknKspngjhSiFsIIKxxDn6P2LsfxGt8rRbCGnUedOOG7Y5tW1z4iLSqn1Ik8Fr5CK/9 SiTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sqmYovtDH2Cha2ixUIjp55v47f+tfN+Y/9nD/H0oaXU=; b=FM2P4M8e1PAahJdGlYeyKtF0lacsyWsmdRMgRPY6dtsr7hhbMg7+oUk4z8B5yjgJeL 5XMrO+xK5qxwu2w9N4saWItPJ2StW60capq3MBk+xCEx7+mVwxid/wJ+06P/b6Hu8VN7 ZHK+hgav1d8AZ29hTxcOwEY5MPFV0je6YXVcDo67DEhO8C21uYmRmG4l8TrkdB0Wj0ey HOd8O4kA4F5yckfSvOiCXm4DBbpPXjQwaosxC8EPGXIilLwGGM/zckfGjX/XC4b73bmE MawLdOm7HIyxun1C5gqQj8CutNx+YddZmskGsH4oPGecEZWc08/zWFKatlK5KOBR0Ony g3RA== X-Gm-Message-State: APjAAAWpUszFfhl+CzyoIgT7Fn0O8OH7kmHJDjlkC39kaIFnX7RZdJcG 7mvA4tpgait4j1a+BFxqIkLlJBZl9M/etCXcrMc= X-Google-Smtp-Source: APXvYqxgIVauTGVCqLlR4n4GbP/KO2TXbfyg5FKYwg7m799qm8qa/AQBMYaFifalBrQB2p3zYAor1U7RqgV1eyk1QRs= X-Received: by 2002:a25:340e:: with SMTP id b14mr4677744yba.82.1558620159194; Thu, 23 May 2019 07:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20190521160330.28402-1-peron.clem@gmail.com> <20190521160330.28402-4-peron.clem@gmail.com> <20190522103243.mmrfato5p2mhtf4j@flea> <20190523125716.g4euwplfsvw4vqzl@flea> In-Reply-To: <20190523125716.g4euwplfsvw4vqzl@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 23 May 2019 16:02:28 +0200 Message-ID: Subject: Re: [PATCH v4 3/5] dt-bindings: watchdog: add Allwinner H6 r_watchdog To: Maxime Ripard Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-watchdog@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 May 2019 at 14:57, Maxime Ripard wro= te: > > On Wed, May 22, 2019 at 06:15:26PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi Maxime, > > > > On Wed, 22 May 2019 at 12:32, Maxime Ripard = wrote: > > > > > > On Tue, May 21, 2019 at 06:03:28PM +0200, Cl=C3=A9ment P=C3=A9ron wro= te: > > > > Allwinner H6 has a second watchdog on the r-blocks which is > > > > compatible with the A31. > > > > > > > > This commit add the H6 compatible for the r_watchdog. > > > > > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > > > Unless you have some evidence that the two blocks are different, then > > > you should just reuse the same one. > > > > I have no evidence it's different nor identical, it's not documented > > in the user manual. > > I thought it would better to have separate bindings in case there is a > > difference. > > Than don't have and find later that we have to introduce one. > > It's a tradeoff. Pushing your logic to the limit, we would have a > compatible for each controller embedded in an SoC. > > This would be unmaintainable, and slightly useless since that case is > very unlikely. > > However, having differences between SoCs is quite common, hence why we > have different compatibles for each SoC. Yes, that make sense, I will send a new version soon, Thanks for the review, Cl=C3=A9ment > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3A6C282DD for ; Thu, 23 May 2019 14:02:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 096B92133D for ; Thu, 23 May 2019 14:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IjtiIOCJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S0WIOvfh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 096B92133D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j4qE92Oh6nt9pl5fHGR3lbD6Pg6mRMCYd2vVM1pkD88=; b=IjtiIOCJoABqBr bEu62m3j24C3Q5xf7sVHuhCw1M4SCoREN6IujQEinJFpSiw8Av6XWkbThFpyJftJ7r8jIUUOzVUJc 20cJ7Ud6SlvMWQEKcc9hGTQD07HDWW4oPDm+H5JRtIjfFUts0NF570IbH9B2P7gDKqLmBb+BO/TwC EvhmCt6yaykxnTmplYNmZH47lriBqtDgufbRfSbSirFEVC4VZ4VSEqC7paqm4Y2GlePOaBaA8bSW+ YyraNGWCRKW0aWanpSw+VWWL7q2hyoaxpq4DOaX1aaRaG5xKAfmeWeCEV4SQctn9JWDUtK9oRR+zR eXqZRWMp05m11d6wv0hg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hToIu-0006yx-Bq; Thu, 23 May 2019 14:02:44 +0000 Received: from mail-yb1-xb41.google.com ([2607:f8b0:4864:20::b41]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hToIq-0006vn-T2 for linux-arm-kernel@lists.infradead.org; Thu, 23 May 2019 14:02:42 +0000 Received: by mail-yb1-xb41.google.com with SMTP id w127so440023yba.0 for ; Thu, 23 May 2019 07:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sqmYovtDH2Cha2ixUIjp55v47f+tfN+Y/9nD/H0oaXU=; b=S0WIOvfhxfwfAv7ibPxBjD1HBQmHhdi/cM0k2xwZ5e8ECTMVUNqunHYdnAhuKwbDjN Xu8BiJho9SPuTk4wu04jroQpaoDnl0YqNbEBdkaBe0laaCkOz5PxNJYrP4byiu9iu+Ni eV4lSa657lsml6+XQgvFORwIB0LQsbP42cOpgFiECUEFMVbmejiHv41dxvs0CX90H/zU eO/mQkOQphWmY9HEo7Bhr0TaEcA4QYzakZtp2LXeixe/zuJ9XD/QjJrLOVSYQGCPuHv6 dIknKspngjhSiFsIIKxxDn6P2LsfxGt8rRbCGnUedOOG7Y5tW1z4iLSqn1Ik8Fr5CK/9 SiTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sqmYovtDH2Cha2ixUIjp55v47f+tfN+Y/9nD/H0oaXU=; b=UFL1JXrDdxDh+Cw9UtZtpUb7K4FPoYhjpblQZz/HhJ+vIRpl3XzinK7OgjEMqGanfW Sb24VFAPJm6F9ao6TdKvWVm2HPAfsbwHEy6tpqQf/6pFNC/ITHPPIpC/uQCmJBcix+hg P1t2yxLeaaySyZldruYiTTRwzVJVlqT+aPWhxsXmeykhRvpNxtAcGRvXXjBY2CBiAuJU 0R3uBCEmEBXDPs8VgesIBNCqhZoSIU0AWg4BZvW+W3lbO0G7/yPSWSaK73hDeuz3zb4f i5LKXnYYZM3OUEJuOi78dCukFach0AbOwu2Qa/TR+WLJBdrfFQX03HNTWo/TQmmU7OzS h4rA== X-Gm-Message-State: APjAAAWXY7tKKUc1cMrXEENCc3HyyM1bBWXhQ6bxA6J7WbTBcDwWDktn /wkESYkcBoGYZFgu/1oD68rKiWgR4nMvNbbR1Is= X-Google-Smtp-Source: APXvYqxgIVauTGVCqLlR4n4GbP/KO2TXbfyg5FKYwg7m799qm8qa/AQBMYaFifalBrQB2p3zYAor1U7RqgV1eyk1QRs= X-Received: by 2002:a25:340e:: with SMTP id b14mr4677744yba.82.1558620159194; Thu, 23 May 2019 07:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20190521160330.28402-1-peron.clem@gmail.com> <20190521160330.28402-4-peron.clem@gmail.com> <20190522103243.mmrfato5p2mhtf4j@flea> <20190523125716.g4euwplfsvw4vqzl@flea> In-Reply-To: <20190523125716.g4euwplfsvw4vqzl@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 23 May 2019 16:02:28 +0200 Message-ID: Subject: Re: [PATCH v4 3/5] dt-bindings: watchdog: add Allwinner H6 r_watchdog To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_070241_129251_A239B61A X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-watchdog@vger.kernel.org, linux-kernel , Chen-Yu Tsai , Rob Herring , linux-arm-kernel , Wim Van Sebroeck , Guenter Roeck Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMyBNYXkgMjAxOSBhdCAxNDo1NywgTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFy ZEBib290bGluLmNvbT4gd3JvdGU6Cj4KPiBPbiBXZWQsIE1heSAyMiwgMjAxOSBhdCAwNjoxNToy NlBNICswMjAwLCBDbMOpbWVudCBQw6lyb24gd3JvdGU6Cj4gPiBIaSBNYXhpbWUsCj4gPgo+ID4g T24gV2VkLCAyMiBNYXkgMjAxOSBhdCAxMjozMiwgTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFy ZEBib290bGluLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFR1ZSwgTWF5IDIxLCAyMDE5IGF0 IDA2OjAzOjI4UE0gKzAyMDAsIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+ID4gPiBBbGx3aW5u ZXIgSDYgaGFzIGEgc2Vjb25kIHdhdGNoZG9nIG9uIHRoZSByLWJsb2NrcyB3aGljaCBpcwo+ID4g PiA+IGNvbXBhdGlibGUgd2l0aCB0aGUgQTMxLgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBjb21taXQg YWRkIHRoZSBINiBjb21wYXRpYmxlIGZvciB0aGUgcl93YXRjaGRvZy4KPiA+ID4gPgo+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IENsw6ltZW50IFDDqXJvbiA8cGVyb24uY2xlbUBnbWFpbC5jb20+Cj4g PiA+Cj4gPiA+IFVubGVzcyB5b3UgaGF2ZSBzb21lIGV2aWRlbmNlIHRoYXQgdGhlIHR3byBibG9j a3MgYXJlIGRpZmZlcmVudCwgdGhlbgo+ID4gPiB5b3Ugc2hvdWxkIGp1c3QgcmV1c2UgdGhlIHNh bWUgb25lLgo+ID4KPiA+IEkgaGF2ZSBubyBldmlkZW5jZSBpdCdzIGRpZmZlcmVudCBub3IgaWRl bnRpY2FsLCBpdCdzIG5vdCBkb2N1bWVudGVkCj4gPiBpbiB0aGUgdXNlciBtYW51YWwuCj4gPiBJ IHRob3VnaHQgaXQgd291bGQgYmV0dGVyIHRvIGhhdmUgc2VwYXJhdGUgYmluZGluZ3MgaW4gY2Fz ZSB0aGVyZSBpcyBhCj4gPiBkaWZmZXJlbmNlLgo+ID4gVGhhbiBkb24ndCBoYXZlIGFuZCBmaW5k IGxhdGVyIHRoYXQgd2UgaGF2ZSB0byBpbnRyb2R1Y2Ugb25lLgo+Cj4gSXQncyBhIHRyYWRlb2Zm LiBQdXNoaW5nIHlvdXIgbG9naWMgdG8gdGhlIGxpbWl0LCB3ZSB3b3VsZCBoYXZlIGEKPiBjb21w YXRpYmxlIGZvciBlYWNoIGNvbnRyb2xsZXIgZW1iZWRkZWQgaW4gYW4gU29DLgo+Cj4gVGhpcyB3 b3VsZCBiZSB1bm1haW50YWluYWJsZSwgYW5kIHNsaWdodGx5IHVzZWxlc3Mgc2luY2UgdGhhdCBj YXNlIGlzCj4gdmVyeSB1bmxpa2VseS4KPgo+IEhvd2V2ZXIsIGhhdmluZyBkaWZmZXJlbmNlcyBi ZXR3ZWVuIFNvQ3MgaXMgcXVpdGUgY29tbW9uLCBoZW5jZSB3aHkgd2UKPiBoYXZlIGRpZmZlcmVu dCBjb21wYXRpYmxlcyBmb3IgZWFjaCBTb0MuClllcywgdGhhdCBtYWtlIHNlbnNlLCBJIHdpbGwg c2VuZCBhIG5ldyB2ZXJzaW9uIHNvb24sCgpUaGFua3MgZm9yIHRoZSByZXZpZXcsCkNsw6ltZW50 Cgo+Cj4gTWF4aW1lCj4KPiAtLQo+IE1heGltZSBSaXBhcmQsIEJvb3RsaW4KPiBFbWJlZGRlZCBM aW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCj4gaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=