From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Subject: Re: Ethernet on my CycloneV broke since 4.9.124
Date: Thu, 15 Nov 2018 16:50:18 +0100
Message-ID: <CAJiuCcdWwifb8gtzcOj+afp5e4DNKviyPjLDaPjjACErSvdfVQ@mail.gmail.com>
References: <CAJiuCcdgU=6K5iFTBucrFHmFP6VNBt4fX_OJ1NaJ7qdAMi2Tkg@mail.gmail.com>
 <61e0ddf2-a2b5-189a-06bc-ee0cd7bfd8b5@kernel.org> <CAJiuCccpJwa+Png72Lg6wp0NrXWUQDOWuDBRP=RwtHF_yKyxEg@mail.gmail.com>
 <d1029588-e181-b804-d2f7-cc9990f6bf70@kernel.org> <CAJiuCcf+brAVmVTXKb5vMuOReLo3ByVq9iJxM1yWOfM4HHvv0A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org
To: Dinh Nguyen <dinguyen@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-yw1-f66.google.com ([209.85.161.66]:45193 "EHLO
        mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727434AbeKPB6x (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 15 Nov 2018 20:58:53 -0500
Received: by mail-yw1-f66.google.com with SMTP id p18-v6so8809451ywg.12
        for <netdev@vger.kernel.org>; Thu, 15 Nov 2018 07:50:30 -0800 (PST)
In-Reply-To: <CAJiuCcf+brAVmVTXKb5vMuOReLo3ByVq9iJxM1yWOfM4HHvv0A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Dinh,

Did you upstream the patch on linux-stable ?

Thanks,
Clement
On Fri, 2 Nov 2018 at 11:02, Cl=C3=A9ment P=C3=A9ron <peron.clem@gmail.com>=
 wrote:
>
> Hi Dinh,
>
> On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen <dinguyen@kernel.org> wrote:
> >
> > Hi Clement,
> >
> > On 10/31/2018 10:36 AM, Cl=C3=A9ment P=C3=A9ron wrote:
> > > Hi Dinh,
> > >
> > > On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@kernel.org> wrote=
:
> > >>
> > >> Hi Clement,
> > >>
> > >> On 10/31/2018 08:01 AM, Cl=C3=A9ment P=C3=A9ron wrote:
> > >>> Hi,
> > >>>
> > >>> The patch "net: stmmac: socfpga: add additional ocp reset line for
> > >>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
> > >>> board.
> > >>>
> > >>> When I boot i have this issue :
> > >>>
> > >>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp=
 -2
> > >>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2
> > >>>
> > >>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix=
 the issue.
> > >>>
> > >>
> > >> Are you sure? I just booted v4.9.124 and did not see any errors. The
> > >> error should not appear because the commit is using
> > >> devm_reset_control_get_optional().
> > >
> > > I'm booting on 4.9.130 actually, Agree with you that
> > > devm_reset_control_get_optional should not failed but checking other
> > > usage of this helper
> > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i=
2c-mv64xxx.c#L824
> > > https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi=
-ss/sun4i-ss-core.c#L259
> > > Show that they don't check for errors except for PROBE_DEFER
> > >
> >
> > I made a mistake, I was booting linux-next. I am seeing the error with
> > v4.9.124. It's due to this commit not getting backported:
> >
> > "bb475230b8e59a reset: make optional functions really optional"
> >
> > I have backported the patch and is available here if you like to take a
> > look:
>
> Thanks, works fine on my board too.
> Regards,
> Clement
>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/=
?h=3Dv4.9.124_optional_reset
> >
> > Dinh