From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F27C10F13 for ; Tue, 16 Apr 2019 08:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 963192087C for ; Tue, 16 Apr 2019 08:31:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="unclPDCb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728832AbfDPIbK (ORCPT ); Tue, 16 Apr 2019 04:31:10 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:38342 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728717AbfDPIbK (ORCPT ); Tue, 16 Apr 2019 04:31:10 -0400 Received: by mail-yw1-f68.google.com with SMTP id m207so7008577ywd.5; Tue, 16 Apr 2019 01:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eEQlaTx6a1IPdLBFUL3ec/4/KOcVjAAWb+qjQ9zGK6o=; b=unclPDCbaqBZ9Iifn/XUyMiM32ZaskXphXsggrN9YgRk9CHhWkosTO7G62ax+/sUx3 9f3OAzbtAG7p1Su36iQ3NwUzGbANiZYwUJJZpccAQCl66I6H2rgzuGeTD6AhNVBw/YLY e0b1bP3nH6IhAaQaKb+lfpAAGLeAN9R3ScwnvEiMS9dz7hGprgHT4Ebjk8c5S6GtDtqf 1VLTWKjpMPlbttTs1qMhQbIKX813hYvnqt/Nuj5XgEDv4Vx0qVc/PWYFFLYazFA0QKg5 aucDiiB5X4i9D0DJogzQaNS8doTw/coZcXilc5P/KwOybLu9Luz7LEuHGfUlxDH8xK2X /nRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eEQlaTx6a1IPdLBFUL3ec/4/KOcVjAAWb+qjQ9zGK6o=; b=TSXzNLYDzDBYq9hfLuBFz3hgY9G4IdiqyWPibwtWmrZRNVRGVNvMBvTRvlYtp+ZSAO 3b6ldU9Pgh2YHs7bvS8OvRqW5sdJA6PGxgQezWlyFqCQc7/vfXoZx/YTAwQ3dkibGAlB UhLtGzyPJQcAxdCBAN4fqwCh10As/JJ6OzRGJEu7W1ayHaCPVRq2A8UkJDOFfi7Z2MtL vv+JFev3cWDYAgzEL13hpk3v1uaoZtl5NyW84nBriXyWXzRkJ57N2UE0WaF5eFBv5cHa PmrnPsUA9Ulap7DXAZs54VVuLg5gZya4uqeIyuQ7z9VibhbaC/2G4Kz5UaSB6xZBn5om kOeg== X-Gm-Message-State: APjAAAVkL/OlwKAEJRLD5eC9hpM/DWbMYZEgJvQsQVdYP3WF1ANvTBau AdZCYkDn8oGrZM/p5ZNYTD7NP8g9UZoMjrD9k/U/NEakkK4= X-Google-Smtp-Source: APXvYqyxB4ImeU4B6QxiA4vY6IOIKSax8gnqSPIvfOjJ9SVtgtxsRssrvYiT2u4CBIsFGDXzQqUHmBsM7qjW0muKa2k= X-Received: by 2002:a81:7895:: with SMTP id t143mr63428396ywc.156.1555403468795; Tue, 16 Apr 2019 01:31:08 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> <20190415081816.2pay4pioc5d4mojf@flea> <20190415145135.fjbcaldwy7w3eqcs@flea> <20190416073449.qzl3uyjgvjgd3tai@flea> In-Reply-To: <20190416073449.qzl3uyjgvjgd3tai@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Tue, 16 Apr 2019 10:30:58 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , Jernej Skrabec , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 16 Apr 2019 at 09:34, Maxime Ripard wro= te: > > On Mon, Apr 15, 2019 at 06:30:10PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > > > I didn't change the driver and the SPDIF is working what's irreleva= nt > > > > in declaring the driver as compatible ? > > > > > > It's working by accident. > > > > > > This won't work for example: > > > https://elixir.bootlin.com/linux/latest/source/sound/soc/sunxi/sun4i-= spdif.c#L181 > > > > > > > If some feature are missing they can be introduce later as there is= a > > > > special binding for H6 no ? > > > > > > Again, that's irrelevant. The only question you need to ask yourself > > > is whether, if you take an imaginary source code that would support > > > all the H3 SPDIF features and run it on an H6, it works just as well. > > > > > > The examples above that it's not the case, so you can't claim that th= e > > > device is compatible. > > > > Is it ok if I fix the TX Fifo flush bit and remove the compatible with = H3 ? > > (Looking at the driver this is the only bit used that is incompatible w= ith H6) > > Sure > > > Or should I send a new driver with the correct mapping ? > > No, we definitely don't want to duplicate a driver just for a single > bit offset that changes. Thanks for the advice, I will try to submit a new version with this fix. Clement > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18E4C10F14 for ; Tue, 16 Apr 2019 08:31:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F15A2073F for ; Tue, 16 Apr 2019 08:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j5sSTM05"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="unclPDCb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F15A2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQAkq9KpTHqz0hqz7Rzsyb6oQo0royf5lRm7GUWiUMU=; b=j5sSTM05vUVLDL s+8ei6AA6XqjDvtaASswnBgFuvwCQa4g0nj8lmfeFmROLjOpJorxiKyhkMu+IMOaBCWHr6Tr3lxxs mVG230+vF4p1qyY47HxXVdilZCZc00Lcz23plOxuE9hZwAX8P9pHS81IlCq7XbFUzQkQ3SgJmhFg3 NPoiKqpae84DDvodtmaaJ0KXj3LnEjpJxCygObvEHwfTGJUDKo6Zf4UVUy59OaIiL3kvjDOTD7KCv g0SbHLsJWK9eDF4uwq4f1PTPFU9IdiKD1iaoXkR5uPpxwqEckfsG7zQKEZ4aFD7u/69Lksi7X9mD8 kAuLLnkh8xFrvZOwu21Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGJUw-0007HI-8o; Tue, 16 Apr 2019 08:31:22 +0000 Received: from mail-yw1-xc42.google.com ([2607:f8b0:4864:20::c42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGJUk-00073f-Sj for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 08:31:12 +0000 Received: by mail-yw1-xc42.google.com with SMTP id z9so7011535ywd.6 for ; Tue, 16 Apr 2019 01:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eEQlaTx6a1IPdLBFUL3ec/4/KOcVjAAWb+qjQ9zGK6o=; b=unclPDCbaqBZ9Iifn/XUyMiM32ZaskXphXsggrN9YgRk9CHhWkosTO7G62ax+/sUx3 9f3OAzbtAG7p1Su36iQ3NwUzGbANiZYwUJJZpccAQCl66I6H2rgzuGeTD6AhNVBw/YLY e0b1bP3nH6IhAaQaKb+lfpAAGLeAN9R3ScwnvEiMS9dz7hGprgHT4Ebjk8c5S6GtDtqf 1VLTWKjpMPlbttTs1qMhQbIKX813hYvnqt/Nuj5XgEDv4Vx0qVc/PWYFFLYazFA0QKg5 aucDiiB5X4i9D0DJogzQaNS8doTw/coZcXilc5P/KwOybLu9Luz7LEuHGfUlxDH8xK2X /nRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eEQlaTx6a1IPdLBFUL3ec/4/KOcVjAAWb+qjQ9zGK6o=; b=dtwomahNr2Tn30VGGJS5iwScfGNPTdzjj8SQpHz+N/1LGlyH23b4fZUvLWlGR49E/q S6yuXzO/wQGtTHR1YjMg9cf49GneXOB8FMQBztK5KaLGwBGQUs9xovyHzV/kv3J1Vx4b vC1yuM9KFL7LE1nM5sk/f9uLipvb0srSBGIhpLYwqjsM2JVaxK8ehEqVy7/NMoGLmrHp dVgO+66lrYdokAvOopt/9iAB7YBHDC1HL/4+/fgO0BACqk35i1PNILSrxskycndu2iRW 0BCkWO7pa3R9tOJmCFiKalAwtHMWG2L5kBtmjXpZObpk6qZQA9abKHnzigNGakNtUs/k wawA== X-Gm-Message-State: APjAAAWHUHIa3C6nUTfq+OmXxdFp1myE0Lwt7mmHvM/fzHgbbFiUf3y3 jfaiKnezTqQvGlS2OqeJXi9igwSQTKDHCuIN1a0= X-Google-Smtp-Source: APXvYqyxB4ImeU4B6QxiA4vY6IOIKSax8gnqSPIvfOjJ9SVtgtxsRssrvYiT2u4CBIsFGDXzQqUHmBsM7qjW0muKa2k= X-Received: by 2002:a81:7895:: with SMTP id t143mr63428396ywc.156.1555403468795; Tue, 16 Apr 2019 01:31:08 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> <20190415081816.2pay4pioc5d4mojf@flea> <20190415145135.fjbcaldwy7w3eqcs@flea> <20190416073449.qzl3uyjgvjgd3tai@flea> In-Reply-To: <20190416073449.qzl3uyjgvjgd3tai@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Tue, 16 Apr 2019 10:30:58 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_013110_924337_390DFC28 X-CRM114-Status: GOOD ( 23.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , linux-sunxi , linux-kernel , Chen-Yu Tsai , Rob Herring , Jagan Teki , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUdWUsIDE2IEFwciAyMDE5IGF0IDA5OjM0LCBNYXhpbWUgUmlwYXJkIDxtYXhpbWUu cmlwYXJkQGJvb3RsaW4uY29tPiB3cm90ZToKPgo+IE9uIE1vbiwgQXByIDE1LCAyMDE5IGF0IDA2 OjMwOjEwUE0gKzAyMDAsIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+ID4gPiBJIGRpZG4ndCBj aGFuZ2UgdGhlIGRyaXZlciBhbmQgdGhlIFNQRElGIGlzIHdvcmtpbmcgd2hhdCdzIGlycmVsZXZh bnQKPiA+ID4gPiBpbiBkZWNsYXJpbmcgdGhlIGRyaXZlciBhcyBjb21wYXRpYmxlID8KPiA+ID4K PiA+ID4gSXQncyB3b3JraW5nIGJ5IGFjY2lkZW50Lgo+ID4gPgo+ID4gPiBUaGlzIHdvbid0IHdv cmsgZm9yIGV4YW1wbGU6Cj4gPiA+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xh dGVzdC9zb3VyY2Uvc291bmQvc29jL3N1bnhpL3N1bjRpLXNwZGlmLmMjTDE4MQo+ID4gPgo+ID4g PiA+IElmIHNvbWUgZmVhdHVyZSBhcmUgbWlzc2luZyB0aGV5IGNhbiBiZSBpbnRyb2R1Y2UgbGF0 ZXIgYXMgdGhlcmUgaXMgYQo+ID4gPiA+IHNwZWNpYWwgYmluZGluZyBmb3IgSDYgbm8gPwo+ID4g Pgo+ID4gPiBBZ2FpbiwgdGhhdCdzIGlycmVsZXZhbnQuIFRoZSBvbmx5IHF1ZXN0aW9uIHlvdSBu ZWVkIHRvIGFzayB5b3Vyc2VsZgo+ID4gPiBpcyB3aGV0aGVyLCBpZiB5b3UgdGFrZSBhbiBpbWFn aW5hcnkgc291cmNlIGNvZGUgdGhhdCB3b3VsZCBzdXBwb3J0Cj4gPiA+IGFsbCB0aGUgSDMgU1BE SUYgZmVhdHVyZXMgYW5kIHJ1biBpdCBvbiBhbiBINiwgaXQgd29ya3MganVzdCBhcyB3ZWxsLgo+ ID4gPgo+ID4gPiBUaGUgZXhhbXBsZXMgYWJvdmUgdGhhdCBpdCdzIG5vdCB0aGUgY2FzZSwgc28g eW91IGNhbid0IGNsYWltIHRoYXQgdGhlCj4gPiA+IGRldmljZSBpcyBjb21wYXRpYmxlLgo+ID4K PiA+IElzIGl0IG9rIGlmIEkgZml4IHRoZSBUWCBGaWZvIGZsdXNoIGJpdCBhbmQgcmVtb3ZlIHRo ZSBjb21wYXRpYmxlIHdpdGggSDMgPwo+ID4gKExvb2tpbmcgYXQgdGhlIGRyaXZlciB0aGlzIGlz IHRoZSBvbmx5IGJpdCB1c2VkIHRoYXQgaXMgaW5jb21wYXRpYmxlIHdpdGggSDYpCj4KPiBTdXJl Cj4KPiA+IE9yIHNob3VsZCBJIHNlbmQgYSBuZXcgZHJpdmVyIHdpdGggdGhlIGNvcnJlY3QgbWFw cGluZyA/Cj4KPiBObywgd2UgZGVmaW5pdGVseSBkb24ndCB3YW50IHRvIGR1cGxpY2F0ZSBhIGRy aXZlciBqdXN0IGZvciBhIHNpbmdsZQo+IGJpdCBvZmZzZXQgdGhhdCBjaGFuZ2VzLgoKVGhhbmtz IGZvciB0aGUgYWR2aWNlLCBJIHdpbGwgdHJ5IHRvIHN1Ym1pdCBhIG5ldyB2ZXJzaW9uIHdpdGgg dGhpcyBmaXguCkNsZW1lbnQKCj4KPiBNYXhpbWUKPgo+IC0tCj4gTWF4aW1lIFJpcGFyZCwgQm9v dGxpbgo+IEVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKPiBodHRwczovL2Jv b3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==