Re: [meta-arm] [PATCH] gator: Add new package

["Clément Péron" <peron.clem@gmail.com>]

Hi Ross,

I will send a v2.

On Tue, 8 Jun 2021 at 16:05, Ross Burton <ross@burtonini.com> wrote:
>
> Good news: that patch is now merged upstream.
>
> Do you plan on sending a revised gator recipe?
>
> Ross
>
> On Mon, 10 May 2021 at 18:14, Ross Burton <ross@burtonini.com> wrote:
> >
> > On Sat, 1 May 2021 at 19:53, Clément Péron <peron.clem@gmail.com> wrote:
> > > +SUMMARY = "DS-5 Streamine Gator daemon"
> >
> > Typo in "Streamline"
> >
> > > +DESCRIPTION = "Target-side daemon gathering data for ARM Streamline \
> > > +Performance Analyzer. Note that Gator uses the Linux Perf API for \
> > > +most of its data collection. Check that your Kernel follow the \
> > > +configuration requirement specified here: \
> > > +https://github.com/ARM-software/gator#kernel-configuration"
> >
> > Far too verbose a DESCRIPTION, the first sentence is sufficient. You
> > can put the kernel configuration in a comment in the recipe.
> >
> > >SRC_URI = "git://github.com/ARM-software/gator.git;protocol=http;branch=master \
> > >. file://0001-gator-don-t-strip-debug.patch;patchdir=.. \
> > >. "
> >
> > There's a mix of spaces and tabs on the line with the patch, just spaces please.
> >
> > > EXTRA_OEMAKE = "'CFLAGS=${CFLAGS} ${TARGET_CC_ARCH} -D_DEFAULT_SOURCE -DETCDIR=\"${sysconfdir}\"' \
> >
> > Also pass V=1 so the build log is verbose.
> >
> > I'm guessing this doesn't work on x86-64 hosts?  If so add
> > COMPATIBLE_HOST = "aarch64.*-linux" to make that explicit (as
> > otherwise a world build with meta-arm present will try to build it).
> >
> > As this is just the daemon, should the recipe be gator-daemon? Or do
> > you plan to add the rest of the tools in the future?

I don't plan for the moment to add the rest of the tools but maybe someone will.
For the package name up to you, what do you prefer?

Clement

> >
> > Ross