From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36636C17461 for ; Tue, 5 Nov 2019 12:58:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBDC721D71 for ; Tue, 5 Nov 2019 12:58:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZEcu9xz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388816AbfKEM6r (ORCPT ); Tue, 5 Nov 2019 07:58:47 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42185 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388678AbfKEM6q (ORCPT ); Tue, 5 Nov 2019 07:58:46 -0500 Received: by mail-wr1-f67.google.com with SMTP id a15so21234346wrf.9; Tue, 05 Nov 2019 04:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EbBVKTp3TAv641EyIKDqjqojRLx2ND1gdrPY2el5f7g=; b=VZEcu9xz9shvIsdGNSkSlsc2gfEgSSDku4HPpaR2nVZkeVS653tgcsFFeM+1PwScLP uFIfYRckoWBrGJj/vWEjitpWe1bSL/OrJuw3+IyUnQDUgQbv/Y2sSrm0SgHZMPoZhhGm t7L5sg80wT4jnLt3T3v0zzSvJqTYMq6YyTkr5ricx/VwzvdHFQ8cSyBmXRsrwGMR1O9q by6C/ug3oECowAguTc27m1SuyN9noC0lEEnQ99DqN+i/81ztkaXjcpGXGj7YAw6/8MeU +DxuWdodANOT+5MbUrtYDb6Tepg1inwTLNxSgy+5OBhXGRK1TrUpTW1gsM5f86B7+Tf9 1SdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EbBVKTp3TAv641EyIKDqjqojRLx2ND1gdrPY2el5f7g=; b=dINNP0GVLmIypH2qi+A7/DeZasE0Msz0cNOr/AtWewZI3KdaOiKqQU72KJgF7pkUwi UUm4fJkeK0E11LI9hXdX7Vqn+CJMKDRvMI3W1WFz42l7CcfYJILWNzzK0j8Z2fuyxPo8 GoJMl37h1O3SkwEb1uBoLPtVYhhBHzNzBMHhXLVYFQ0UZdWKkasv2e4BOPP7cer7iSIZ mYQuxcK86yLicXrBl4PM2ET4lguApwYOgTzoqDDHyl1bmyvlFbx3i3raSjVj3ylRqoVo mB/p/tneYYQgNdOtMKTD3zE6zvDfIq8E++gcyvQLy2HBxzsnxqE7TCiL9RRgFU8vTTL6 qdlw== X-Gm-Message-State: APjAAAXD1Ca26wOyEIW3Zn7Wx4eiOuQvB6veqI+FB4KcqeywKUnDNcWX ct/h79NKvZcfdSeFa3ECLnaEb0YWDnAEACxfbV8= X-Google-Smtp-Source: APXvYqzXcIldjXyqcQeNIUogKwZf4MmDYxHvGPy9t8BV0gGj8v8HgjgDjpF+P0vtdFNp+pJ5lsj4oW7eNcIaJp/y7q0= X-Received: by 2002:a5d:69c8:: with SMTP id s8mr28130527wrw.167.1572958722979; Tue, 05 Nov 2019 04:58:42 -0800 (PST) MIME-Version: 1.0 References: <20191103203334.10539-1-peron.clem@gmail.com> <20191103203334.10539-5-peron.clem@gmail.com> <20191104083835.m2pd4fvhn2ze6bjt@pengutronix.de> <20191105072922.rku2of3cfphpfirq@pengutronix.de> In-Reply-To: <20191105072922.rku2of3cfphpfirq@pengutronix.de> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Tue, 5 Nov 2019 13:58:31 +0100 Message-ID: Subject: Re: [PATCH v2 4/7] pwm: sun4i: Add support to output source clock directly To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Thierry Reding , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , linux-pwm@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel , Jernej Skrabec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On Tue, 5 Nov 2019 at 08:29, Uwe Kleine-K=C3=B6nig wrote: > > Hi Cl=C3=A9ment, > > On Mon, Nov 04, 2019 at 10:28:54PM +0100, Cl=C3=A9ment P=C3=A9ron wrote: > > On Mon, 4 Nov 2019 at 09:38, Uwe Kleine-K=C3=B6nig > > wrote: > > > On Sun, Nov 03, 2019 at 09:33:31PM +0100, Cl=C3=A9ment P=C3=A9ron wro= te: > > > > From: Jernej Skrabec > > > > > > > > PWM core has an option to bypass whole logic and output unchanged s= ource > > > > clock as PWM output. This is achieved by enabling bypass bit. > > > > > > > > Note that when bypass is enabled, no other setting has any meaning,= not > > > > even enable bit. > > > > > > > > This mode of operation is needed to achieve high enough frequency t= o > > > > serve as clock source for AC200 chip, which is integrated into same > > > > package as H6 SoC. > > > > > > I think the , should be dropped. > > > > > > > Signed-off-by: Jernej Skrabec > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > --- > > > > drivers/pwm/pwm-sun4i.c | 39 +++++++++++++++++++++++++++++++++++++= +- > > > > 1 file changed, 38 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > > > index b5e7ac364f59..2441574674d9 100644 > > > > --- a/drivers/pwm/pwm-sun4i.c > > > > +++ b/drivers/pwm/pwm-sun4i.c > > > > @@ -3,6 +3,10 @@ > > > > * Driver for Allwinner sun4i Pulse Width Modulation Controller > > > > * > > > > * Copyright (C) 2014 Alexandre Belloni > > > > + * > > > > + * Limitations: > > > > + * - When outputing the source clock directly, the PWM logic will = be bypassed > > > > + * and the currently running period is not guaranted to be compl= eted > > > > > > Typo: guaranted -> guaranteed > > > > > > > */ > > > > > > > > #include > > > > @@ -73,6 +77,7 @@ static const u32 prescaler_table[] =3D { > > > > > > > > struct sun4i_pwm_data { > > > > bool has_prescaler_bypass; > > > > + bool has_direct_mod_clk_output; > > > > unsigned int npwm; > > > > }; > > > > > > > > @@ -118,6 +123,20 @@ static void sun4i_pwm_get_state(struct pwm_chi= p *chip, > > > > > > > > val =3D sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); > > > > > > > > + /* > > > > + * PWM chapter in H6 manual has a diagram which explains that= if bypass > > > > + * bit is set, no other setting has any meaning. Even more, e= xperiment > > > > + * proved that also enable bit is ignored in this case. > > > > + */ > > > > + if ((val & BIT_CH(PWM_BYPASS, pwm->hwpwm)) && > > > > + data->has_direct_mod_clk_output) { > > > > + state->period =3D DIV_ROUND_CLOSEST_ULL(NSEC_PER_SEC,= clk_rate); > > > > + state->duty_cycle =3D state->period / 2; > > > > + state->polarity =3D PWM_POLARITY_NORMAL; > > > > + state->enabled =3D true; > > > > + return; > > > > + } > > > > > > Not sure how the rest of sun4i_pwm_get_state behaves, but I would pre= fer > > > to let .get_state() round up which together with .apply_state() round= ing > > > down yields sound behaviour. > > Ok > > > > > > > + > > > > if ((PWM_REG_PRESCAL(val, pwm->hwpwm) =3D=3D PWM_PRESCAL_MASK= ) && > > > > sun4i_pwm->data->has_prescaler_bypass) > > > > prescaler =3D 1; > > > > @@ -203,7 +222,8 @@ static int sun4i_pwm_apply(struct pwm_chip *chi= p, struct pwm_device *pwm, > > > > { > > > > struct sun4i_pwm_chip *sun4i_pwm =3D to_sun4i_pwm_chip(chip); > > > > struct pwm_state cstate; > > > > - u32 ctrl; > > > > + u32 ctrl, clk_rate; > > > > + bool bypass; > > > > int ret; > > > > unsigned int delay_us; > > > > unsigned long now; > > > > @@ -218,6 +238,16 @@ static int sun4i_pwm_apply(struct pwm_chip *ch= ip, struct pwm_device *pwm, > > > > } > > > > } > > > > > > > > + /* > > > > + * Although it would make much more sense to check for bypass= in > > > > + * sun4i_pwm_calculate(), value of bypass bit also depends on= "enabled". > > > > + * Period is allowed to be rounded up or down. > > > > + */ > > > > + clk_rate =3D clk_get_rate(sun4i_pwm->clk); > > > > + bypass =3D ((state->period * clk_rate >=3D NSEC_PER_SEC && > > > > + state->period * clk_rate < NSEC_PER_SEC + clk_rate= ) && > > > > + state->enabled); > > > > > > I guess the compiler is smart enough here, but checking for > > > state->enabled is cheaper than the other checks, so putting this at t= he > > > start of the expression seems sensible. > > > > > > The comment doesn't match the code. You don't round up state->period. > > > (This is good, please fix the comment.) I think dropping the check > > > > > > state->period * clk_rate < NSEC_PER_SEC + clk_rate > > > > > > would be fine, too. > > Ok > > > > > > > > I'd like to have a check for > > > > > > state->duty_cycle * clk_rate >=3D NSEC_PER_SEC / 2 && > > > state->duty_cycle * clk_rate < NSEC_PER_SEC > > > > > > here. If this isn't true rather disable the PWM or output a 100% duty > > > cycle with a larger period. > > > > Why not just having the duty_cycle is 50% only ? > > state->duty_cycle * 2 =3D=3D state->period; > > Yeah, for the bypass case you can only provide a 50% duty cycle. The > problem you have to address is that you cannot rely on your consumer to > request only 50% duty cycles. So you have to implement some behaviour if > your consumer requests period =3D 1 / clk_rate and 20% duty cycle. So you request to add a new patch in this series for fixing the actual PWM behavior at corner case? This series just want to add a new device and a new bypass functionality and I can't measure the output of PWM and testing it properly. Can this be done in another patch/series ? Regards, Cl=C3=A9ment > > Where I want to get the pwm framework as a whole is to let lowlevel > drivers round down both duty_cycle and period to the next possible values > in their .apply callback to be able to provide a more uniform behaviour > for consumers. So here this would mean: > > - 1 / clk_rate <=3D state->period < smallest value without bypass && > 0 <=3D state->duty_cycle < state->period / 2 > =3D> provide a constant 0 > > - 1 / clk_rate <=3D state->period < smallest value without bypass && > state->period / 2 <=3D state->duty_cycle < state->period > =3D> use bypass mode providing 50% duty cycle > > - 1 / clk_rate <=3D state->period < smallest value without bypass && > state->period =3D=3D state->duty_cycle > =3D> provide a constant 1 > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | > Industrial Linux Solutions | http://www.pengutronix.de/ = | From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v2 4/7] pwm: sun4i: Add support to output source clock directly Date: Tue, 5 Nov 2019 13:58:31 +0100 Message-ID: References: <20191103203334.10539-1-peron.clem@gmail.com> <20191103203334.10539-5-peron.clem@gmail.com> <20191104083835.m2pd4fvhn2ze6bjt@pengutronix.de> <20191105072922.rku2of3cfphpfirq@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191105072922.rku2of3cfphpfirq@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Mark Rutland , linux-pwm@vger.kernel.org, Jernej Skrabec , devicetree , linux-kernel , Maxime Ripard , Rob Herring , Chen-Yu Tsai , Thierry Reding , linux-arm-kernel List-Id: linux-pwm@vger.kernel.org SGkgVXdlLAoKT24gVHVlLCA1IE5vdiAyMDE5IGF0IDA4OjI5LCBVd2UgS2xlaW5lLUvDtm5pZwo8 dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPgo+IEhpIENsw6ltZW50LAo+ Cj4gT24gTW9uLCBOb3YgMDQsIDIwMTkgYXQgMTA6Mjg6NTRQTSArMDEwMCwgQ2zDqW1lbnQgUMOp cm9uIHdyb3RlOgo+ID4gT24gTW9uLCA0IE5vdiAyMDE5IGF0IDA5OjM4LCBVd2UgS2xlaW5lLUvD tm5pZwo+ID4gPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4gPiA+IE9u IFN1biwgTm92IDAzLCAyMDE5IGF0IDA5OjMzOjMxUE0gKzAxMDAsIENsw6ltZW50IFDDqXJvbiB3 cm90ZToKPiA+ID4gPiBGcm9tOiBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAc2lvbC5u ZXQ+Cj4gPiA+ID4KPiA+ID4gPiBQV00gY29yZSBoYXMgYW4gb3B0aW9uIHRvIGJ5cGFzcyB3aG9s ZSBsb2dpYyBhbmQgb3V0cHV0IHVuY2hhbmdlZCBzb3VyY2UKPiA+ID4gPiBjbG9jayBhcyBQV00g b3V0cHV0LiBUaGlzIGlzIGFjaGlldmVkIGJ5IGVuYWJsaW5nIGJ5cGFzcyBiaXQuCj4gPiA+ID4K PiA+ID4gPiBOb3RlIHRoYXQgd2hlbiBieXBhc3MgaXMgZW5hYmxlZCwgbm8gb3RoZXIgc2V0dGlu ZyBoYXMgYW55IG1lYW5pbmcsIG5vdAo+ID4gPiA+IGV2ZW4gZW5hYmxlIGJpdC4KPiA+ID4gPgo+ ID4gPiA+IFRoaXMgbW9kZSBvZiBvcGVyYXRpb24gaXMgbmVlZGVkIHRvIGFjaGlldmUgaGlnaCBl bm91Z2ggZnJlcXVlbmN5IHRvCj4gPiA+ID4gc2VydmUgYXMgY2xvY2sgc291cmNlIGZvciBBQzIw MCBjaGlwLCB3aGljaCBpcyBpbnRlZ3JhdGVkIGludG8gc2FtZQo+ID4gPiA+IHBhY2thZ2UgYXMg SDYgU29DLgo+ID4gPgo+ID4gPiBJIHRoaW5rIHRoZSAsIHNob3VsZCBiZSBkcm9wcGVkLgo+ID4g Pgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEplcm5laiBTa3JhYmVjIDxqZXJuZWouc2tyYWJlY0Bz aW9sLm5ldD4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNs ZW1AZ21haWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL3B3bS9wd20tc3VuNGku YyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gPiA+ICAx IGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+Cj4g PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcHdtL3B3bS1zdW40aS5jIGIvZHJpdmVycy9wd20v cHdtLXN1bjRpLmMKPiA+ID4gPiBpbmRleCBiNWU3YWMzNjRmNTkuLjI0NDE1NzQ2NzRkOSAxMDA2 NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwo+ID4gPiA+ICsrKyBiL2Ry aXZlcnMvcHdtL3B3bS1zdW40aS5jCj4gPiA+ID4gQEAgLTMsNiArMywxMCBAQAo+ID4gPiA+ICAg KiBEcml2ZXIgZm9yIEFsbHdpbm5lciBzdW40aSBQdWxzZSBXaWR0aCBNb2R1bGF0aW9uIENvbnRy b2xsZXIKPiA+ID4gPiAgICoKPiA+ID4gPiAgICogQ29weXJpZ2h0IChDKSAyMDE0IEFsZXhhbmRy ZSBCZWxsb25pIDxhbGV4YW5kcmUuYmVsbG9uaUBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gPiA+ID4g KyAqCj4gPiA+ID4gKyAqIExpbWl0YXRpb25zOgo+ID4gPiA+ICsgKiAtIFdoZW4gb3V0cHV0aW5n IHRoZSBzb3VyY2UgY2xvY2sgZGlyZWN0bHksIHRoZSBQV00gbG9naWMgd2lsbCBiZSBieXBhc3Nl ZAo+ID4gPiA+ICsgKiAgIGFuZCB0aGUgY3VycmVudGx5IHJ1bm5pbmcgcGVyaW9kIGlzIG5vdCBn dWFyYW50ZWQgdG8gYmUgY29tcGxldGVkCj4gPiA+Cj4gPiA+IFR5cG86IGd1YXJhbnRlZCAgLT4g Z3VhcmFudGVlZAo+ID4gPgo+ID4gPiA+ICAgKi8KPiA+ID4gPgo+ID4gPiA+ICAjaW5jbHVkZSA8 bGludXgvYml0b3BzLmg+Cj4gPiA+ID4gQEAgLTczLDYgKzc3LDcgQEAgc3RhdGljIGNvbnN0IHUz MiBwcmVzY2FsZXJfdGFibGVbXSA9IHsKPiA+ID4gPgo+ID4gPiA+ICBzdHJ1Y3Qgc3VuNGlfcHdt X2RhdGEgewo+ID4gPiA+ICAgICAgIGJvb2wgaGFzX3ByZXNjYWxlcl9ieXBhc3M7Cj4gPiA+ID4g KyAgICAgYm9vbCBoYXNfZGlyZWN0X21vZF9jbGtfb3V0cHV0Owo+ID4gPiA+ICAgICAgIHVuc2ln bmVkIGludCBucHdtOwo+ID4gPiA+ICB9Owo+ID4gPiA+Cj4gPiA+ID4gQEAgLTExOCw2ICsxMjMs MjAgQEAgc3RhdGljIHZvaWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNo aXAsCj4gPiA+ID4KPiA+ID4gPiAgICAgICB2YWwgPSBzdW40aV9wd21fcmVhZGwoc3VuNGlfcHdt LCBQV01fQ1RSTF9SRUcpOwo+ID4gPiA+Cj4gPiA+ID4gKyAgICAgLyoKPiA+ID4gPiArICAgICAg KiBQV00gY2hhcHRlciBpbiBINiBtYW51YWwgaGFzIGEgZGlhZ3JhbSB3aGljaCBleHBsYWlucyB0 aGF0IGlmIGJ5cGFzcwo+ID4gPiA+ICsgICAgICAqIGJpdCBpcyBzZXQsIG5vIG90aGVyIHNldHRp bmcgaGFzIGFueSBtZWFuaW5nLiBFdmVuIG1vcmUsIGV4cGVyaW1lbnQKPiA+ID4gPiArICAgICAg KiBwcm92ZWQgdGhhdCBhbHNvIGVuYWJsZSBiaXQgaXMgaWdub3JlZCBpbiB0aGlzIGNhc2UuCj4g PiA+ID4gKyAgICAgICovCj4gPiA+ID4gKyAgICAgaWYgKCh2YWwgJiBCSVRfQ0goUFdNX0JZUEFT UywgcHdtLT5od3B3bSkpICYmCj4gPiA+ID4gKyAgICAgICAgIGRhdGEtPmhhc19kaXJlY3RfbW9k X2Nsa19vdXRwdXQpIHsKPiA+ID4gPiArICAgICAgICAgICAgIHN0YXRlLT5wZXJpb2QgPSBESVZf Uk9VTkRfQ0xPU0VTVF9VTEwoTlNFQ19QRVJfU0VDLCBjbGtfcmF0ZSk7Cj4gPiA+ID4gKyAgICAg ICAgICAgICBzdGF0ZS0+ZHV0eV9jeWNsZSA9IHN0YXRlLT5wZXJpb2QgLyAyOwo+ID4gPiA+ICsg ICAgICAgICAgICAgc3RhdGUtPnBvbGFyaXR5ID0gUFdNX1BPTEFSSVRZX05PUk1BTDsKPiA+ID4g PiArICAgICAgICAgICAgIHN0YXRlLT5lbmFibGVkID0gdHJ1ZTsKPiA+ID4gPiArICAgICAgICAg ICAgIHJldHVybjsKPiA+ID4gPiArICAgICB9Cj4gPiA+Cj4gPiA+IE5vdCBzdXJlIGhvdyB0aGUg cmVzdCBvZiBzdW40aV9wd21fZ2V0X3N0YXRlIGJlaGF2ZXMsIGJ1dCBJIHdvdWxkIHByZWZlcgo+ ID4gPiB0byBsZXQgLmdldF9zdGF0ZSgpIHJvdW5kIHVwIHdoaWNoIHRvZ2V0aGVyIHdpdGggLmFw cGx5X3N0YXRlKCkgcm91bmRpbmcKPiA+ID4gZG93biB5aWVsZHMgc291bmQgYmVoYXZpb3VyLgo+ ID4gT2sKPiA+ID4KPiA+ID4gPiArCj4gPiA+ID4gICAgICAgaWYgKChQV01fUkVHX1BSRVNDQUwo dmFsLCBwd20tPmh3cHdtKSA9PSBQV01fUFJFU0NBTF9NQVNLKSAmJgo+ID4gPiA+ICAgICAgICAg ICBzdW40aV9wd20tPmRhdGEtPmhhc19wcmVzY2FsZXJfYnlwYXNzKQo+ID4gPiA+ICAgICAgICAg ICAgICAgcHJlc2NhbGVyID0gMTsKPiA+ID4gPiBAQCAtMjAzLDcgKzIyMiw4IEBAIHN0YXRpYyBp bnQgc3VuNGlfcHdtX2FwcGx5KHN0cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3bV9kZXZp Y2UgKnB3bSwKPiA+ID4gPiAgewo+ID4gPiA+ICAgICAgIHN0cnVjdCBzdW40aV9wd21fY2hpcCAq c3VuNGlfcHdtID0gdG9fc3VuNGlfcHdtX2NoaXAoY2hpcCk7Cj4gPiA+ID4gICAgICAgc3RydWN0 IHB3bV9zdGF0ZSBjc3RhdGU7Cj4gPiA+ID4gLSAgICAgdTMyIGN0cmw7Cj4gPiA+ID4gKyAgICAg dTMyIGN0cmwsIGNsa19yYXRlOwo+ID4gPiA+ICsgICAgIGJvb2wgYnlwYXNzOwo+ID4gPiA+ICAg ICAgIGludCByZXQ7Cj4gPiA+ID4gICAgICAgdW5zaWduZWQgaW50IGRlbGF5X3VzOwo+ID4gPiA+ ICAgICAgIHVuc2lnbmVkIGxvbmcgbm93Owo+ID4gPiA+IEBAIC0yMTgsNiArMjM4LDE2IEBAIHN0 YXRpYyBpbnQgc3VuNGlfcHdtX2FwcGx5KHN0cnVjdCBwd21fY2hpcCAqY2hpcCwgc3RydWN0IHB3 bV9kZXZpY2UgKnB3bSwKPiA+ID4gPiAgICAgICAgICAgICAgIH0KPiA+ID4gPiAgICAgICB9Cj4g PiA+ID4KPiA+ID4gPiArICAgICAvKgo+ID4gPiA+ICsgICAgICAqIEFsdGhvdWdoIGl0IHdvdWxk IG1ha2UgbXVjaCBtb3JlIHNlbnNlIHRvIGNoZWNrIGZvciBieXBhc3MgaW4KPiA+ID4gPiArICAg ICAgKiBzdW40aV9wd21fY2FsY3VsYXRlKCksIHZhbHVlIG9mIGJ5cGFzcyBiaXQgYWxzbyBkZXBl bmRzIG9uICJlbmFibGVkIi4KPiA+ID4gPiArICAgICAgKiBQZXJpb2QgaXMgYWxsb3dlZCB0byBi ZSByb3VuZGVkIHVwIG9yIGRvd24uCj4gPiA+ID4gKyAgICAgICovCj4gPiA+ID4gKyAgICAgY2xr X3JhdGUgPSBjbGtfZ2V0X3JhdGUoc3VuNGlfcHdtLT5jbGspOwo+ID4gPiA+ICsgICAgIGJ5cGFz cyA9ICgoc3RhdGUtPnBlcmlvZCAqIGNsa19yYXRlID49IE5TRUNfUEVSX1NFQyAmJgo+ID4gPiA+ ICsgICAgICAgICAgICAgICAgc3RhdGUtPnBlcmlvZCAqIGNsa19yYXRlIDwgTlNFQ19QRVJfU0VD ICsgY2xrX3JhdGUpICYmCj4gPiA+ID4gKyAgICAgICAgICAgICAgIHN0YXRlLT5lbmFibGVkKTsK PiA+ID4KPiA+ID4gSSBndWVzcyB0aGUgY29tcGlsZXIgaXMgc21hcnQgZW5vdWdoIGhlcmUsIGJ1 dCBjaGVja2luZyBmb3IKPiA+ID4gc3RhdGUtPmVuYWJsZWQgaXMgY2hlYXBlciB0aGFuIHRoZSBv dGhlciBjaGVja3MsIHNvIHB1dHRpbmcgdGhpcyBhdCB0aGUKPiA+ID4gc3RhcnQgb2YgdGhlIGV4 cHJlc3Npb24gc2VlbXMgc2Vuc2libGUuCj4gPiA+Cj4gPiA+IFRoZSBjb21tZW50IGRvZXNuJ3Qg bWF0Y2ggdGhlIGNvZGUuIFlvdSBkb24ndCByb3VuZCB1cCBzdGF0ZS0+cGVyaW9kLgo+ID4gPiAo VGhpcyBpcyBnb29kLCBwbGVhc2UgZml4IHRoZSBjb21tZW50LikgSSB0aGluayBkcm9wcGluZyB0 aGUgY2hlY2sKPiA+ID4KPiA+ID4gICAgICAgICBzdGF0ZS0+cGVyaW9kICogY2xrX3JhdGUgPCBO U0VDX1BFUl9TRUMgKyBjbGtfcmF0ZQo+ID4gPgo+ID4gPiB3b3VsZCBiZSBmaW5lLCB0b28uCj4g PiBPawo+ID4KPiA+ID4KPiA+ID4gSSdkIGxpa2UgdG8gaGF2ZSBhIGNoZWNrIGZvcgo+ID4gPgo+ ID4gPiAgICAgICAgIHN0YXRlLT5kdXR5X2N5Y2xlICogY2xrX3JhdGUgPj0gTlNFQ19QRVJfU0VD IC8gMiAmJgo+ID4gPiAgICAgICAgIHN0YXRlLT5kdXR5X2N5Y2xlICogY2xrX3JhdGUgPCBOU0VD X1BFUl9TRUMKPiA+ID4KPiA+ID4gaGVyZS4gSWYgdGhpcyBpc24ndCB0cnVlIHJhdGhlciBkaXNh YmxlIHRoZSBQV00gb3Igb3V0cHV0IGEgMTAwJSBkdXR5Cj4gPiA+IGN5Y2xlIHdpdGggYSBsYXJn ZXIgcGVyaW9kLgo+ID4KPiA+IFdoeSBub3QganVzdCBoYXZpbmcgdGhlIGR1dHlfY3ljbGUgaXMg NTAlIG9ubHkgPwo+ID4gc3RhdGUtPmR1dHlfY3ljbGUgKiAyID09IHN0YXRlLT5wZXJpb2Q7Cj4K PiBZZWFoLCBmb3IgdGhlIGJ5cGFzcyBjYXNlIHlvdSBjYW4gb25seSBwcm92aWRlIGEgNTAlIGR1 dHkgY3ljbGUuIFRoZQo+IHByb2JsZW0geW91IGhhdmUgdG8gYWRkcmVzcyBpcyB0aGF0IHlvdSBj YW5ub3QgcmVseSBvbiB5b3VyIGNvbnN1bWVyIHRvCj4gcmVxdWVzdCBvbmx5IDUwJSBkdXR5IGN5 Y2xlcy4gU28geW91IGhhdmUgdG8gaW1wbGVtZW50IHNvbWUgYmVoYXZpb3VyIGlmCj4geW91ciBj b25zdW1lciByZXF1ZXN0cyBwZXJpb2QgPSAxIC8gY2xrX3JhdGUgYW5kIDIwJSBkdXR5IGN5Y2xl LgoKU28geW91IHJlcXVlc3QgdG8gYWRkIGEgbmV3IHBhdGNoIGluIHRoaXMgc2VyaWVzIGZvciBm aXhpbmcgdGhlIGFjdHVhbApQV00gYmVoYXZpb3IgYXQgY29ybmVyIGNhc2U/CgpUaGlzIHNlcmll cyBqdXN0IHdhbnQgdG8gYWRkIGEgbmV3IGRldmljZSBhbmQgYSBuZXcgYnlwYXNzCmZ1bmN0aW9u YWxpdHkgYW5kIEkgY2FuJ3QgbWVhc3VyZSB0aGUgb3V0cHV0IG9mIFBXTSBhbmQgdGVzdGluZyBp dApwcm9wZXJseS4KQ2FuIHRoaXMgYmUgZG9uZSBpbiBhbm90aGVyIHBhdGNoL3NlcmllcyA/CgpS ZWdhcmRzLApDbMOpbWVudAoKPgo+IFdoZXJlIEkgd2FudCB0byBnZXQgdGhlIHB3bSBmcmFtZXdv cmsgYXMgYSB3aG9sZSBpcyB0byBsZXQgbG93bGV2ZWwKPiBkcml2ZXJzIHJvdW5kIGRvd24gYm90 aCBkdXR5X2N5Y2xlIGFuZCBwZXJpb2QgdG8gdGhlIG5leHQgcG9zc2libGUgdmFsdWVzCj4gaW4g dGhlaXIgLmFwcGx5IGNhbGxiYWNrIHRvIGJlIGFibGUgdG8gcHJvdmlkZSBhIG1vcmUgdW5pZm9y bSBiZWhhdmlvdXIKPiBmb3IgY29uc3VtZXJzLiBTbyBoZXJlIHRoaXMgd291bGQgbWVhbjoKPgo+ ICAtIDEgLyBjbGtfcmF0ZSA8PSBzdGF0ZS0+cGVyaW9kIDwgc21hbGxlc3QgdmFsdWUgd2l0aG91 dCBieXBhc3MgJiYKPiAgICAwIDw9IHN0YXRlLT5kdXR5X2N5Y2xlIDwgc3RhdGUtPnBlcmlvZCAv IDIKPiAgICAgICAgID0+IHByb3ZpZGUgYSBjb25zdGFudCAwCj4KPiAgLSAxIC8gY2xrX3JhdGUg PD0gc3RhdGUtPnBlcmlvZCA8IHNtYWxsZXN0IHZhbHVlIHdpdGhvdXQgYnlwYXNzICYmCj4gICAg c3RhdGUtPnBlcmlvZCAvIDIgPD0gc3RhdGUtPmR1dHlfY3ljbGUgPCBzdGF0ZS0+cGVyaW9kCj4g ICAgICAgICA9PiB1c2UgYnlwYXNzIG1vZGUgcHJvdmlkaW5nIDUwJSBkdXR5IGN5Y2xlCj4KPiAg LSAxIC8gY2xrX3JhdGUgPD0gc3RhdGUtPnBlcmlvZCA8IHNtYWxsZXN0IHZhbHVlIHdpdGhvdXQg YnlwYXNzICYmCj4gICAgc3RhdGUtPnBlcmlvZCA9PSBzdGF0ZS0+ZHV0eV9jeWNsZQo+ICAgICAg ICAgPT4gcHJvdmlkZSBhIGNvbnN0YW50IDEKPgo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+Cj4gLS0K PiBQZW5ndXRyb25peCBlLksuICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBVd2UgS2xlaW5l LUvDtm5pZyAgICAgICAgICAgIHwKPiBJbmR1c3RyaWFsIExpbnV4IFNvbHV0aW9ucyAgICAgICAg ICAgICAgICAgfCBodHRwOi8vd3d3LnBlbmd1dHJvbml4LmRlLyAgfAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=