From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08A4C072A4 for ; Mon, 20 May 2019 08:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85FF620656 for ; Mon, 20 May 2019 08:21:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R5Z+Rjbq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730761AbfETIVy (ORCPT ); Mon, 20 May 2019 04:21:54 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:43363 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfETIVx (ORCPT ); Mon, 20 May 2019 04:21:53 -0400 Received: by mail-yw1-f68.google.com with SMTP id t5so5513022ywf.10; Mon, 20 May 2019 01:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qhO6B8/Z9D9GEePABEHToMQA2Zs+IWYeC8mEzi25YY=; b=R5Z+RjbqwZV78P9ToAX8cdQxWCGGQYpG1b6umNEBYkosWgExwZSU1q71Zp4WbGmGoc op/1g+RlSnWhVDVr7/H45rTEmKBCB4wb688alowDLxBL6pV0XbRjLU5Gi0BBFccrvmuC Ec1i+bsCKfe4Jteg4849yH84Lki5NlCEColC4Uzgr5WhH+nycTgaEI+nX2cHyWddzsQD Ah42AhDZoAVxhulQEcfV5SywwNSXTT2ZWi0y+ciBePITT9EpBXPKtYwiolfHgVgnAOtY ElcQ2Lke+RZepMdrTWaQJ1sKMR0IW4Kp9HSZYG0YbaY/IR1g+Qw6Ji1ngvrX8u6KIBlW Obhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qhO6B8/Z9D9GEePABEHToMQA2Zs+IWYeC8mEzi25YY=; b=MF0TauXYXnZ7rru9kywuNuX7ShJye0MQ5zq+U1mwNAvVgurnU9ZcG/M/0lsBU28EKp NFn5AN2J1O6zlMLpJMbrOQCx0hZcnvEUg4qukJWqx2ZjeFvgq83avTLrKjG9eu7EKjUW 6OCyFfqlyrnEKRUVkVwDX+7p7pIPAtm7xLHkB3kY+txbkOQwRu/k4fhoPA9GlXKAEaih RQ055wYFNwUUDF7VcTJyq73pRZwGU7xmVdy1RzlC+knuBIzxMcTbYKd4cn5GVZ/XdeHS vb3xbtnv18RiQNIybf2vbJU2/YVwKOCkFFYYO51cUMWA7mjkyJuS6nJTxmIb0M1QHjg1 883A== X-Gm-Message-State: APjAAAWz/rmjwNdi2TwL0wUXDyAI2RLzl7Fqjh505nddKQHgXep+Kj9G waKggtBYWgtXWQxYJFUH+amoKY6jHU5TTXJ5DBTNeVoF X-Google-Smtp-Source: APXvYqxTV7Y4TX39GVp8m3uUIqRHuAd4Xg7evnIjykjVPrMlj+RftBbiQ1AZDp3Zzok2g/gdO2GsZt9sT8nrTtl+3xE= X-Received: by 2002:a81:59c2:: with SMTP id n185mr33786741ywb.21.1558340511959; Mon, 20 May 2019 01:21:51 -0700 (PDT) MIME-Version: 1.0 References: <20190518152355.11134-1-peron.clem@gmail.com> <20190518152355.11134-3-peron.clem@gmail.com> <20190520073652.itk452vrpnicta5v@flea> In-Reply-To: <20190520073652.itk452vrpnicta5v@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 20 May 2019 10:21:40 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node To: Maxime Ripard Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-watchdog@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, 20 May 2019 at 09:36, Maxime Ripard wro= te: > > On Sat, May 18, 2019 at 05:23:53PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > Allwinner H6 has a watchog node which seems broken > > on some boards. > > > > Test has been performed on several boards. > > > > Chen-Yu Tsai boards: > > Pine H64 - H6448BA 7782 =3D> OK > > OrangePi Lite 2 - H8068BA 61C2 =3D> KO > > > > Martin Ayotte boards: > > Pine H64 - H8069BA 6892 =3D> OK > > OrangePi 3 - HA047BA 69W2 =3D> KO > > OrangePi One Plus - H7310BA 6842 =3D> KO > > OrangePi Lite2 - H6448BA 6662 =3D> KO > > > > Cl=C3=A9ment P=C3=A9ron board: > > Beelink GS1 - H7309BA 6842 =3D> KO > > > > As it seems not fixable for now, declare the node > > but leave it disable with a comment. > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > If it doesn't work most boards, then why do we need to merge that > patch in the first place? My personnal opinion, is that having the IP declared and disabled with a comment saying "it's broken on some boards" in the device-tree is better than not having at all. This will explicit say "the IP exist but don't use it!". Maybe some people with a functionnal board would like to explicitly use it on their dts. Again just my personnal opinion, Thanks for the review, Cl=C3=A9ment > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5CDC04AAF for ; Mon, 20 May 2019 08:22:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2093A20656 for ; Mon, 20 May 2019 08:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LvcEvvq6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R5Z+Rjbq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2093A20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NrwCEr3oyCFPShwcQU+MWqCHyYLPQUV3tgmNXO3vWO4=; b=LvcEvvq64K02ul vtJXaYf7NbPH/hkHL0A00aidy2SsQ8G1WxdR/4iUxPFr8R+s1azY42J5bu2WocbVaQrbimSEbJxmS ViLuWZR07jbJJO9UKEXUa7Cr5Z/QWyY2jQv1mR384Z5QD19kMCokQeJUzbVGE9Mz7y7/02mOSl0cp lu96/1jhYOJup8HO3qsCHSkymSjAJ5WLCyoWo6tg/Yvn7nVcGEeQkFVm6BHVQz/EM8Et7Sup+vA3u 4+VskH/HoqghAnApph79N24Ef3OfS9YwREF1ydx84FI3NzDBiv4DD5LsPsPLNhZ1PE5AA4fro3eSU Tv4ZjAJAqjEnPILwn8RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSdYT-0006Ok-8r; Mon, 20 May 2019 08:21:57 +0000 Received: from mail-yw1-xc42.google.com ([2607:f8b0:4864:20::c42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSdYP-0006Nu-Oh for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2019 08:21:55 +0000 Received: by mail-yw1-xc42.google.com with SMTP id e68so5532267ywf.3 for ; Mon, 20 May 2019 01:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qhO6B8/Z9D9GEePABEHToMQA2Zs+IWYeC8mEzi25YY=; b=R5Z+RjbqwZV78P9ToAX8cdQxWCGGQYpG1b6umNEBYkosWgExwZSU1q71Zp4WbGmGoc op/1g+RlSnWhVDVr7/H45rTEmKBCB4wb688alowDLxBL6pV0XbRjLU5Gi0BBFccrvmuC Ec1i+bsCKfe4Jteg4849yH84Lki5NlCEColC4Uzgr5WhH+nycTgaEI+nX2cHyWddzsQD Ah42AhDZoAVxhulQEcfV5SywwNSXTT2ZWi0y+ciBePITT9EpBXPKtYwiolfHgVgnAOtY ElcQ2Lke+RZepMdrTWaQJ1sKMR0IW4Kp9HSZYG0YbaY/IR1g+Qw6Ji1ngvrX8u6KIBlW Obhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qhO6B8/Z9D9GEePABEHToMQA2Zs+IWYeC8mEzi25YY=; b=hhiqVlwP/Lk6gBJdxpL0M4W6KV2EngCIJ1dFp3wFf7ap6kz5A9nDstQy7YpROoejkB cT/yQimbahgwFu/gxDgaqOmGsSZvOIVcdjGnYLfVZSHhQeNmNwxGMAWrH5cINWlkcaOS j+aCUJhnvpVnm7QArMZS1FWZUO4mOfvgocu7zQ3NvqyZfiB9z9Thw36GNpb0gTnYj0bO 3dgjjWtNAvoBtfNMqGk1LfJ6tfamLUIrqSfsrDdINhFCYAn4OlynPxv1WESNJKHzQAwO rZ2ZibDizI7Xn/TvUTXbwIRii1VTuR6SqrzVYBYUW8e0Ze3+hUzH4NilTiMCb4fWbChG F0+g== X-Gm-Message-State: APjAAAVKGXX0R+OpZm/GLS2V32rHL4j1nF35S5oZ336fJ5L5ARGOhIht pen6Pb3Kjle5GR1Fek5vbDPeUaBei/PPVjuQCp8= X-Google-Smtp-Source: APXvYqxTV7Y4TX39GVp8m3uUIqRHuAd4Xg7evnIjykjVPrMlj+RftBbiQ1AZDp3Zzok2g/gdO2GsZt9sT8nrTtl+3xE= X-Received: by 2002:a81:59c2:: with SMTP id n185mr33786741ywb.21.1558340511959; Mon, 20 May 2019 01:21:51 -0700 (PDT) MIME-Version: 1.0 References: <20190518152355.11134-1-peron.clem@gmail.com> <20190518152355.11134-3-peron.clem@gmail.com> <20190520073652.itk452vrpnicta5v@flea> In-Reply-To: <20190520073652.itk452vrpnicta5v@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 20 May 2019 10:21:40 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_012153_850508_203A4B9B X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-watchdog@vger.kernel.org, linux-kernel , Chen-Yu Tsai , Rob Herring , linux-arm-kernel , Wim Van Sebroeck , Guenter Roeck Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBNb24sIDIwIE1heSAyMDE5IGF0IDA5OjM2LCBNYXhpbWUgUmlwYXJkIDxtYXhpbWUu cmlwYXJkQGJvb3RsaW4uY29tPiB3cm90ZToKPgo+IE9uIFNhdCwgTWF5IDE4LCAyMDE5IGF0IDA1 OjIzOjUzUE0gKzAyMDAsIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+IEFsbHdpbm5lciBINiBo YXMgYSB3YXRjaG9nIG5vZGUgd2hpY2ggc2VlbXMgYnJva2VuCj4gPiBvbiBzb21lIGJvYXJkcy4K PiA+Cj4gPiBUZXN0IGhhcyBiZWVuIHBlcmZvcm1lZCBvbiBzZXZlcmFsIGJvYXJkcy4KPiA+Cj4g PiBDaGVuLVl1IFRzYWkgYm9hcmRzOgo+ID4gUGluZSBINjQgLSBINjQ0OEJBIDc3ODIgPT4gT0sK PiA+IE9yYW5nZVBpIExpdGUgMiAtIEg4MDY4QkEgNjFDMiA9PiBLTwo+ID4KPiA+IE1hcnRpbiBB eW90dGUgYm9hcmRzOgo+ID4gUGluZSBINjQgLSBIODA2OUJBIDY4OTIgPT4gT0sKPiA+IE9yYW5n ZVBpIDMgLSBIQTA0N0JBIDY5VzIgPT4gS08KPiA+IE9yYW5nZVBpIE9uZSBQbHVzIC0gSDczMTBC QSA2ODQyID0+IEtPCj4gPiBPcmFuZ2VQaSBMaXRlMiAtIEg2NDQ4QkEgNjY2MiA9PiBLTwo+ID4K PiA+IENsw6ltZW50IFDDqXJvbiBib2FyZDoKPiA+IEJlZWxpbmsgR1MxIC0gSDczMDlCQSA2ODQy ID0+IEtPCj4gPgo+ID4gQXMgaXQgc2VlbXMgbm90IGZpeGFibGUgZm9yIG5vdywgZGVjbGFyZSB0 aGUgbm9kZQo+ID4gYnV0IGxlYXZlIGl0IGRpc2FibGUgd2l0aCBhIGNvbW1lbnQuCj4gPgo+ID4g U2lnbmVkLW9mZi1ieTogQ2zDqW1lbnQgUMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPgo+ IElmIGl0IGRvZXNuJ3Qgd29yayBtb3N0IGJvYXJkcywgdGhlbiB3aHkgZG8gd2UgbmVlZCB0byBt ZXJnZSB0aGF0Cj4gcGF0Y2ggaW4gdGhlIGZpcnN0IHBsYWNlPwoKTXkgcGVyc29ubmFsIG9waW5p b24sIGlzIHRoYXQgaGF2aW5nIHRoZSBJUCBkZWNsYXJlZCBhbmQgZGlzYWJsZWQgd2l0aAphIGNv bW1lbnQgc2F5aW5nICJpdCdzIGJyb2tlbiBvbiBzb21lIGJvYXJkcyIgaW4gdGhlIGRldmljZS10 cmVlIGlzCmJldHRlciB0aGFuIG5vdCBoYXZpbmcgYXQgYWxsLgoKVGhpcyB3aWxsIGV4cGxpY2l0 IHNheSAidGhlIElQIGV4aXN0IGJ1dCBkb24ndCB1c2UgaXQhIi4KTWF5YmUgc29tZSBwZW9wbGUg d2l0aCBhIGZ1bmN0aW9ubmFsIGJvYXJkIHdvdWxkIGxpa2UgdG8gZXhwbGljaXRseQp1c2UgaXQg b24gdGhlaXIgZHRzLgoKQWdhaW4ganVzdCBteSBwZXJzb25uYWwgb3BpbmlvbiwKVGhhbmtzIGZv ciB0aGUgcmV2aWV3LApDbMOpbWVudAoKPgo+IE1heGltZQo+Cj4gLS0KPiBNYXhpbWUgUmlwYXJk LCBCb290bGluCj4gRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwo+IGh0dHBz Oi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK