From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6687DC2BA80 for ; Mon, 6 Apr 2020 08:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30B7E206C3 for ; Mon, 6 Apr 2020 08:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bn+gVHDE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbgDFI7A (ORCPT ); Mon, 6 Apr 2020 04:59:00 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:45468 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgDFI66 (ORCPT ); Mon, 6 Apr 2020 04:58:58 -0400 Received: by mail-io1-f68.google.com with SMTP id y14so14883882iol.12; Mon, 06 Apr 2020 01:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UPqDv8CeYx1N0Rja5HT63eK8rvmvj33Sn4Tfxap3WTc=; b=Bn+gVHDErL8xA6WvQFL200iyfcEdk15R4pwg/hQTYqbdp4UqOFrBDKJ5VSmq9u6+Rb /DeDXlLbydHymHVCAbiurUQlc/aa5I1KkdZN8F1w/r27hlxr8Y+XXn8YY1WNgUt6aKKH 3TI0b2RGGTqLFpZcVy1vBm006yak8uN/7KFeq1Qx6OMqw5h13Y7pNa1lrTPq1YvGMCCJ mqlycyqCwA1qrYb6bqKQeD7+4BE1bpPfWGBOKFb5QI1zlOxGGOxxkm1jc26mL2QWWFDU 92ng5DI/gdutvOEEHZdUwjA3nBbiLRPEUZYO2k7spgJmJOr8alCTYOeGY0aVi3EdYyXP pIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UPqDv8CeYx1N0Rja5HT63eK8rvmvj33Sn4Tfxap3WTc=; b=BDBkshVZ1g98rpR+KbcOGYg3eCwlq8APS6mT/u6HRnU6/yGqjlESsnbFRwrqRa3nVL cSJE6aBqPvpVlvcgOry6fs4p8kyIy31uEfzrzoFbRj07+LyIRIe2ORrR9OGQRpKZosh6 5zuYhA6Q6SPvvL4Rjhh3wfye5XByh0OoQTmtKdGGgdCkgjynBAyILtsbx6AiBr86mtpo TU9vPqX5GmayiAtZLYuTiPAWnJ4JXQGgmf7re0uDp05mJL9HvMnarKjrommRe1jP0KT7 HNHXQ/oXzOivjt2/UUhh+f3JSyAnjbZme9gaVuMOr6h05W9lJNGx9sgae51jUsf09vJl a1RA== X-Gm-Message-State: AGi0PuZN6qZb7kKoSl2r6quw9dEpzzGLbVKjzwMLzRk9VtqbBTWICbRf wBUzuopKfKJpYTK0hGOqro4XljGQdB5+55W0u58= X-Google-Smtp-Source: APiQypKzF6+d+kvaHfqUmiZUENYlrMoUP8gCIkosLWjyIQWyWGDfhXe0uF0V+iawQs6++52+4Lv1JVXLmh6NX2xx8IY= X-Received: by 2002:a05:6638:53:: with SMTP id a19mr19157348jap.144.1586163535745; Mon, 06 Apr 2020 01:58:55 -0700 (PDT) MIME-Version: 1.0 References: <20200405173601.24331-1-peron.clem@gmail.com> <20200405173601.24331-5-peron.clem@gmail.com> <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> In-Reply-To: <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 6 Apr 2020 10:58:44 +0200 Message-ID: Subject: Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Mon, 6 Apr 2020 at 10:16, Maxime Ripard wrote: > > On Sun, Apr 05, 2020 at 07:35:58PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > Add an Operating Performance Points table for the GPU to > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > --- > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dts= i > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arc= h/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > new file mode 100644 > > index 000000000000..4a1814844fe0 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > @@ -0,0 +1,74 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +// Copyright (C) 2020 Cl=C3=A9ment P=C3=A9ron > > + > > +/ { > > + gpu_opp_table: opp_table1 { > > A node name is supposed to be a generic description, so what about > using gpu-opp-table (and cpu-opp-table) instead? > > > + compatible =3D "operating-points-v2"; > > + > > + opp@756000000 { > > + opp-hz =3D /bits/ 64 <756000000>; > > + opp-microvolt =3D <1040000>; > > + }; > > + opp@624000000 { > > + opp-hz =3D /bits/ 64 <624000000>; > > + opp-microvolt =3D <950000>; > > + }; > > Ordering by ascending frequency would be great here. Indeed will fix it. > > Also, why did you need to create a new DTSI for it? Is there some > downside to enabling it for all the users? I didn't want to enable it for all boards as I can't test them and not all = board have a dedicated regulator for VDD-GPU. Hence my question in the cover, But with Jernej =C5=A0krabec test on Tanix TX6 I think it can be safely enable on all boards. Regards, Clement > > Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E07C2BA2B for ; Mon, 6 Apr 2020 08:59:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BB28206F8 for ; Mon, 6 Apr 2020 08:59:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KvY4qw33"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bn+gVHDE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BB28206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xONkJlubRXtqJ8F0eZCy2NKh/APrjiBfWKGWD6fscvw=; b=KvY4qw33Kh551Z V+MrpZwBZpGWIg9WLC6EUObeHA+4DLFlYurNuavZzgw5fycP8iYHQ6e3p848cLDCr1NdqC8UT1c7Q xn7QJtO3UBXvC46sPu9uZGXkMpD30ATowlcHNQeHPoVGhogEeobbj9yW8leGtByRCrEr81XgNcrkd 4x09P0XZU/LFFacuavsCc7fkfDYC9fKJfGZa5Gg6j/fSizRs/FImVOjK8pcZclIKanJDPvnBEkvVW 7wsZfTkoMxrJsZkSLQcy5x2LFhAn/K6+a0XS/f9nZD2EJzEcV9PqUChmAKp8rOC1Rd2NHPP7so1fv aEJTceGxx+4U7vwBGqOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLNau-0005Jo-9g; Mon, 06 Apr 2020 08:59:00 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLNar-0005Ix-6H for linux-arm-kernel@lists.infradead.org; Mon, 06 Apr 2020 08:58:58 +0000 Received: by mail-io1-xd42.google.com with SMTP id s15so14927187ioj.7 for ; Mon, 06 Apr 2020 01:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UPqDv8CeYx1N0Rja5HT63eK8rvmvj33Sn4Tfxap3WTc=; b=Bn+gVHDErL8xA6WvQFL200iyfcEdk15R4pwg/hQTYqbdp4UqOFrBDKJ5VSmq9u6+Rb /DeDXlLbydHymHVCAbiurUQlc/aa5I1KkdZN8F1w/r27hlxr8Y+XXn8YY1WNgUt6aKKH 3TI0b2RGGTqLFpZcVy1vBm006yak8uN/7KFeq1Qx6OMqw5h13Y7pNa1lrTPq1YvGMCCJ mqlycyqCwA1qrYb6bqKQeD7+4BE1bpPfWGBOKFb5QI1zlOxGGOxxkm1jc26mL2QWWFDU 92ng5DI/gdutvOEEHZdUwjA3nBbiLRPEUZYO2k7spgJmJOr8alCTYOeGY0aVi3EdYyXP pIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UPqDv8CeYx1N0Rja5HT63eK8rvmvj33Sn4Tfxap3WTc=; b=Yt4+DKmOjWYPPA2T+bjUo/0B8/4q7rbVejwMaGr3SBdwkO0KkLsd3URzBFFOONsUVY yDtMgiiyl7onAR/MKbO9M9Vhr6e6wcmODPJwSjiNHkpG/sk0V4o6AHISt9wKKu1MFUNL W3kesxyK6K9ZvfqbtsWKP65pIeaC3fFVfKA81DgHZt2Kue12KwIMsnfY6ZYSBFz06jjE XLN3tQwQ4dIQotk/B6HBj1BBeWKcXtQFLD5oRFDsoJI42SgR0wcMpVrFu2ABzKTnab5G G9zNu6d1tQdduU4l90hoyK/yuiReRZB5epSzw+y0EJkPg6F2UdKlKX2rBAeEzQlZJ45A OWaA== X-Gm-Message-State: AGi0PubEzojlMdRRCuQWnDHtNB4krnTF1fm0lGsMZtJSPn6UoytX92Oh sCiRTW6dXEmn+WtIQBKrM3BZIYUdmPpsyemYh70= X-Google-Smtp-Source: APiQypKzF6+d+kvaHfqUmiZUENYlrMoUP8gCIkosLWjyIQWyWGDfhXe0uF0V+iawQs6++52+4Lv1JVXLmh6NX2xx8IY= X-Received: by 2002:a05:6638:53:: with SMTP id a19mr19157348jap.144.1586163535745; Mon, 06 Apr 2020 01:58:55 -0700 (PDT) MIME-Version: 1.0 References: <20200405173601.24331-1-peron.clem@gmail.com> <20200405173601.24331-5-peron.clem@gmail.com> <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> In-Reply-To: <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 6 Apr 2020 10:58:44 +0200 Message-ID: Subject: Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200406_015857_258390_8280F705 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Chen-Yu Tsai , linux-kernel , linux-sunxi , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWF4aW1lLAoKT24gTW9uLCA2IEFwciAyMDIwIGF0IDEwOjE2LCBNYXhpbWUgUmlwYXJkIDxt YXhpbWVAY2Vybm8udGVjaD4gd3JvdGU6Cj4KPiBPbiBTdW4sIEFwciAwNSwgMjAyMCBhdCAwNzoz NTo1OFBNICswMjAwLCBDbMOpbWVudCBQw6lyb24gd3JvdGU6Cj4gPiBBZGQgYW4gT3BlcmF0aW5n IFBlcmZvcm1hbmNlIFBvaW50cyB0YWJsZSBmb3IgdGhlIEdQVSB0bwo+ID4gZW5hYmxlIER5bmFt aWMgVm9sdGFnZSAmIEZyZXF1ZW5jeSBTY2FsaW5nIG9uIHRoZSBINi4KPiA+Cj4gPiBTaWduZWQt b2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29tPgo+ID4gLS0tCj4g PiAgLi4uL2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGktaDYtZ3B1LW9wcC5kdHNpIHwgNzQgKysr KysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspCj4g PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUw aS1oNi1ncHUtb3BwLmR0c2kKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0 cy9hbGx3aW5uZXIvc3VuNTBpLWg2LWdwdS1vcHAuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMv YWxsd2lubmVyL3N1bjUwaS1oNi1ncHUtb3BwLmR0c2kKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0 Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjRhMTgxNDg0NGZlMAo+ID4gLS0tIC9kZXYvbnVsbAo+ ID4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWg2LWdwdS1vcHAu ZHRzaQo+ID4gQEAgLTAsMCArMSw3NCBAQAo+ID4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVy OiAoR1BMLTIuMCsgT1IgTUlUKQo+ID4gKy8vIENvcHlyaWdodCAoQykgMjAyMCBDbMOpbWVudCBQ w6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29tPgo+ID4gKwo+ID4gKy8gewo+ID4gKyAgICAgZ3B1 X29wcF90YWJsZTogb3BwX3RhYmxlMSB7Cj4KPiBBIG5vZGUgbmFtZSBpcyBzdXBwb3NlZCB0byBi ZSBhIGdlbmVyaWMgZGVzY3JpcHRpb24sIHNvIHdoYXQgYWJvdXQKPiB1c2luZyBncHUtb3BwLXRh YmxlIChhbmQgY3B1LW9wcC10YWJsZSkgaW5zdGVhZD8KPgo+ID4gKyAgICAgICAgICAgICBjb21w YXRpYmxlID0gIm9wZXJhdGluZy1wb2ludHMtdjIiOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICBv cHBANzU2MDAwMDAwIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8g NjQgPDc1NjAwMDAwMD47Cj4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9 IDwxMDQwMDAwPjsKPiA+ICsgICAgICAgICAgICAgfTsKPiA+ICsgICAgICAgICAgICAgb3BwQDYy NDAwMDAwMCB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw2 MjQwMDAwMDA+Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8OTUw MDAwPjsKPiA+ICsgICAgICAgICAgICAgfTsKPgo+IE9yZGVyaW5nIGJ5IGFzY2VuZGluZyBmcmVx dWVuY3kgd291bGQgYmUgZ3JlYXQgaGVyZS4KSW5kZWVkIHdpbGwgZml4IGl0LgoKPgo+IEFsc28s IHdoeSBkaWQgeW91IG5lZWQgdG8gY3JlYXRlIGEgbmV3IERUU0kgZm9yIGl0PyBJcyB0aGVyZSBz b21lCj4gZG93bnNpZGUgdG8gZW5hYmxpbmcgaXQgZm9yIGFsbCB0aGUgdXNlcnM/CgpJIGRpZG4n dCB3YW50IHRvIGVuYWJsZSBpdCBmb3IgYWxsIGJvYXJkcyBhcyBJIGNhbid0IHRlc3QgdGhlbSBh bmQgbm90IGFsbCBib2FyZApoYXZlIGEgZGVkaWNhdGVkIHJlZ3VsYXRvciBmb3IgVkRELUdQVS4K SGVuY2UgbXkgcXVlc3Rpb24gaW4gdGhlIGNvdmVyLApCdXQgd2l0aCBKZXJuZWogxaBrcmFiZWMg dGVzdCBvbiBUYW5peCBUWDYgSSB0aGluayBpdCBjYW4gYmUgc2FmZWx5CmVuYWJsZSBvbiBhbGwg Ym9hcmRzLgoKUmVnYXJkcywKQ2xlbWVudAoKPgo+IE1heGltZQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=