From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBAEC10F0E for ; Mon, 15 Apr 2019 08:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93879206BA for ; Mon, 15 Apr 2019 08:11:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5ChPBE5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbfDOILv (ORCPT ); Mon, 15 Apr 2019 04:11:51 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:41843 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfDOILv (ORCPT ); Mon, 15 Apr 2019 04:11:51 -0400 Received: by mail-yb1-f194.google.com with SMTP id a13so3114874ybl.8; Mon, 15 Apr 2019 01:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=u1XZE73tZD/pQnKVYQTbqH9e5x6SoTO9CAWo5zHYJ14=; b=B5ChPBE5M8JwD754egxMPrbTDuc77w6mwRHbc78vZZ9iAMOlW4TJMBqWNUgRYnCbjP 1XEoZYqYRZP/gZlg6+CmoAain7wHYr9urHiTRdRFPmh7HDvCvubi/lTkJb5aYTaJVs+L DkP4cLM83qK23Mzm3uJAxxPlplCN/vapxzAAZy1fhaNGk24RdLw1M9Hi6OotuzkIjm25 wlwuio9Yf6vscvlkeZhQaL6M+uTuzqHF7lcmej55GmgW0AdGD6UbElNooaITve/+9yHZ D9SWv567NpeAwvhI9d3Xc2ZSRTVrc9KzKU9F4SmCqWyZmn/0GR+LY4ah5/AAdNjeTLwl iU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u1XZE73tZD/pQnKVYQTbqH9e5x6SoTO9CAWo5zHYJ14=; b=g2v0ysNJBG9whzkcd+Ba+2W7obOycJWjuJcQmLIz6mUxftr8cN4hlctJy3jdjjYqFc ZC8JU80BZfJX1cEf4HfdEUr8jDKku+ZOtGyzI2Pa0ah47aaZn8xHjEPl0JP6HqTKzeba gFndIY8PeelYwsGN8KUyc7xdxWxV36/BrBuK38AOLeR6i06Sejglsqj3Ke6tyC29ETfF 6fwNyu7dFDO2za2tcn0EpV3nYvKnHNNokmqRyAGOTs/r3O9yAwdUzwtqBO8Wq6icSfdJ 5mwfXgEeYLQSo1I/Hbe59gWxhcnCNOx+8HLvOXKqE0sHFkbanG0HioQBLh8SUaDtAm8e Yp+g== X-Gm-Message-State: APjAAAXauEQetEHpPcAt6HxrxiaXaHmHCwhgikNkYH7wv7aGm+aD5cDs uLxy7DT8ie/iNrQnzN2pCXlBC6tHk3UtdqD9VVg= X-Google-Smtp-Source: APXvYqxX7S4JpXuPFz31xhNEso/fghnMJz6nRca0KzARERBEC3qICHVn2fh2sXAACfh11r0Zi3AoHAw0chfG/v75ke4= X-Received: by 2002:a25:c9c7:: with SMTP id z190mr59797546ybf.234.1555315910039; Mon, 15 Apr 2019 01:11:50 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 15 Apr 2019 10:11:38 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , Jernej Skrabec , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Apr 2019 at 10:09, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi, > > On Mon, 15 Apr 2019 at 10:04, Maxime Ripard w= rote: > > > > Hi, > > > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Cl=C3=A9ment P=C3=A9ron wrote= : > > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > > size and the possibility to output the master clock. > > > However it's still compatible with the already existing driver for > > > Allwiner H3. > > > > > > Add this compatible in the device-tree bindings documentation. > > > > How was this tested? > > Using Alsa utils on a Beelink GS1 and I check correct output sound on > my home cinema. > > > > After looking at the datasheet, it looks like it's still significantly > > different. In particular: > > > > - The MCLK divider isn't at the same offset > We don't use the MCLK > > - The bits to flush the FIFO aren't at the same offset > > - The FIFO trigger levels aren't at the same offset > > - The FIFO status register layout is almost entirely different > We use DMA not FIFO And also only SPDIF Tx has been tested. > > Clement > > > > So it doesn't really look compatible to me > > > > Maxime > > > > -- > > Maxime Ripard, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAC7C10F0E for ; Mon, 15 Apr 2019 08:11:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B12E4206BA for ; Mon, 15 Apr 2019 08:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Phen0aRY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5ChPBE5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B12E4206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R1yxm3dvJWCtpvW5BBCvtb/k4rx6ccp6GVJOlH6Nxt4=; b=Phen0aRY8l6GBI S58hpEw9bNmD4YudEkLTE31fINb93PFdybuGjpsXDLKj4l3KvDXEp+23TM4cnYcJOvAgNKI3YzaWH Pb/38ozCFS3q5mMQgZbtZ1CmyvLJTF/5kCOIncD9lUQwcDdKUH0c4yrC9Lm2YqSFQFbEseXOKeko9 uTZPeiPx+tqlCRm/qUEEqnTWuH/Sh7urK5UFOxRHDMKzbe9y8UoD9hkBZmHW99cFsTL+1QNpm1Xsy Q2pzWBkn3MuPslKdIiZ4LgTsgQYbssxDvc8KRa8ae+isQEFvPN3LeZ1UrSIiQEdfNiY92zA53Kd+5 1h1ZDDLWnwH7nr1zkLbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFwiY-0004Ap-Be; Mon, 15 Apr 2019 08:11:54 +0000 Received: from mail-yb1-xb42.google.com ([2607:f8b0:4864:20::b42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFwiV-0004A8-7E for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 08:11:52 +0000 Received: by mail-yb1-xb42.google.com with SMTP id u187so6045702ybg.11 for ; Mon, 15 Apr 2019 01:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=u1XZE73tZD/pQnKVYQTbqH9e5x6SoTO9CAWo5zHYJ14=; b=B5ChPBE5M8JwD754egxMPrbTDuc77w6mwRHbc78vZZ9iAMOlW4TJMBqWNUgRYnCbjP 1XEoZYqYRZP/gZlg6+CmoAain7wHYr9urHiTRdRFPmh7HDvCvubi/lTkJb5aYTaJVs+L DkP4cLM83qK23Mzm3uJAxxPlplCN/vapxzAAZy1fhaNGk24RdLw1M9Hi6OotuzkIjm25 wlwuio9Yf6vscvlkeZhQaL6M+uTuzqHF7lcmej55GmgW0AdGD6UbElNooaITve/+9yHZ D9SWv567NpeAwvhI9d3Xc2ZSRTVrc9KzKU9F4SmCqWyZmn/0GR+LY4ah5/AAdNjeTLwl iU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u1XZE73tZD/pQnKVYQTbqH9e5x6SoTO9CAWo5zHYJ14=; b=XvaQFLVufUEmI1oL7LhIkzcoO/M62Q1/PkVprySZJDVcDVlm7MDLZ45+FHBIVUh82u PRMZGem8nXmVgfgAX2/pul9Wk0gX++Twij5QkgtAy/fp79Y5R3Y1lMf4Ws0GwIo0v6Zl l0PcZlsMIJubCjzgdfGjIzlSG0X7fKBgQbMo8DxG5Fcf7dl9TWMJBnL+BHqQLAbuW96r UNfM1G6zViwoNufuL2c+6W1vtabc+5LwpFhp104154JrMOsJpmBt+A+lNhjuvxlbk1D9 rWk+ACUBeTfhMnZ21KoqLozlmNVL/x7NVvEnw4VRVax7F1Z5F2cw5hGi7MNTFkH8ymzA I5/A== X-Gm-Message-State: APjAAAVlKAVUQPX4q1k6FndaijyC8SYCJT66vxooZszc0Xjq/TkHo056 iLI+JXkK1u+Fu4kNfmoXbrTLhf9oZ9ititawV2s= X-Google-Smtp-Source: APXvYqxX7S4JpXuPFz31xhNEso/fghnMJz6nRca0KzARERBEC3qICHVn2fh2sXAACfh11r0Zi3AoHAw0chfG/v75ke4= X-Received: by 2002:a25:c9c7:: with SMTP id z190mr59797546ybf.234.1555315910039; Mon, 15 Apr 2019 01:11:50 -0700 (PDT) MIME-Version: 1.0 References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> <20190415080443.frubh4ln4agrdsfe@flea> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 15 Apr 2019 10:11:38 +0200 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_011151_270272_6F007EC7 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , linux-sunxi , linux-kernel , Chen-Yu Tsai , Rob Herring , Jagan Teki , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxNSBBcHIgMjAxOSBhdCAxMDowOSwgQ2zDqW1lbnQgUMOpcm9uIDxwZXJvbi5jbGVt QGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBIaSwKPgo+IE9uIE1vbiwgMTUgQXByIDIwMTkgYXQgMTA6 MDQsIE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4K PiA+IEhpLAo+ID4KPiA+IE9uIFRodSwgQXByIDExLCAyMDE5IGF0IDExOjQ0OjE5UE0gKzAyMDAs IENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+ID4gQWxsd2lubmVyIEg2IGhhcyBhIFNQRElGIGNv bnRyb2xsZXIgd2l0aCBhbiBpbmNyZWFzZSBvZiB0aGUgZmlmbwo+ID4gPiBzaXplIGFuZCB0aGUg cG9zc2liaWxpdHkgdG8gb3V0cHV0IHRoZSBtYXN0ZXIgY2xvY2suCj4gPiA+IEhvd2V2ZXIgaXQn cyBzdGlsbCBjb21wYXRpYmxlIHdpdGggdGhlIGFscmVhZHkgZXhpc3RpbmcgZHJpdmVyIGZvcgo+ ID4gPiBBbGx3aW5lciBIMy4KPiA+ID4KPiA+ID4gQWRkIHRoaXMgY29tcGF0aWJsZSBpbiB0aGUg ZGV2aWNlLXRyZWUgYmluZGluZ3MgZG9jdW1lbnRhdGlvbi4KPiA+Cj4gPiBIb3cgd2FzIHRoaXMg dGVzdGVkPwo+Cj4gVXNpbmcgQWxzYSB1dGlscyBvbiBhIEJlZWxpbmsgR1MxIGFuZCBJIGNoZWNr IGNvcnJlY3Qgb3V0cHV0IHNvdW5kIG9uCj4gbXkgaG9tZSBjaW5lbWEuCj4gPgo+ID4gQWZ0ZXIg bG9va2luZyBhdCB0aGUgZGF0YXNoZWV0LCBpdCBsb29rcyBsaWtlIGl0J3Mgc3RpbGwgc2lnbmlm aWNhbnRseQo+ID4gZGlmZmVyZW50LiBJbiBwYXJ0aWN1bGFyOgo+ID4KPiA+ICAgLSBUaGUgTUNM SyBkaXZpZGVyIGlzbid0IGF0IHRoZSBzYW1lIG9mZnNldAo+IFdlIGRvbid0IHVzZSB0aGUgTUNM Swo+ID4gICAtIFRoZSBiaXRzIHRvIGZsdXNoIHRoZSBGSUZPIGFyZW4ndCBhdCB0aGUgc2FtZSBv ZmZzZXQKPiA+ICAgLSBUaGUgRklGTyB0cmlnZ2VyIGxldmVscyBhcmVuJ3QgYXQgdGhlIHNhbWUg b2Zmc2V0Cj4gPiAgIC0gVGhlIEZJRk8gc3RhdHVzIHJlZ2lzdGVyIGxheW91dCBpcyBhbG1vc3Qg ZW50aXJlbHkgZGlmZmVyZW50Cj4gV2UgdXNlIERNQSBub3QgRklGTwoKQW5kIGFsc28gb25seSBT UERJRiBUeCBoYXMgYmVlbiB0ZXN0ZWQuCgo+Cj4gQ2xlbWVudAo+ID4KPiA+IFNvIGl0IGRvZXNu J3QgcmVhbGx5IGxvb2sgY29tcGF0aWJsZSB0byBtZQo+ID4KPiA+IE1heGltZQo+ID4KPiA+IC0t Cj4gPiBNYXhpbWUgUmlwYXJkLCBCb290bGluCj4gPiBFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVs IGVuZ2luZWVyaW5nCj4gPiBodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==