From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E5EC388F9 for ; Fri, 30 Oct 2020 12:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54C7B206FA for ; Fri, 30 Oct 2020 12:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBlLv1td" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgJ3M6W (ORCPT ); Fri, 30 Oct 2020 08:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgJ3M6T (ORCPT ); Fri, 30 Oct 2020 08:58:19 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0056C0613CF; Fri, 30 Oct 2020 05:58:18 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id h21so7370212iob.10; Fri, 30 Oct 2020 05:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=HBlLv1td8ZGbbQpa0MJPMXQx1wDSoEh19ueH+HpLQn7HCeunMObf8TyVowEs6h3R1m iO4vu+D+ag+gypjHMSJ/h5TbRu/++9EMN4/xsfsDdMPaUZtE4oFglwtgR08CcW2G2AdX UmlQm9AfRndgv1zsgN3sTlb+QByMJzLQycWwoPdDgQWPlOLC+3cw/yAxHS9xGEcsfk25 oL5Gr2GsEfDIMPaQ/3v0cjoZYemL+EIxWgI9EmA1QEc1Kc55bB7q7X6z5rvkgrdV8Wln YUSHz2U73sjUjSPC7fP0Cum01fYXKZPtnwqJrgS23oaIaaD/6+9OjVGgGaguXxagZ3Lq 1xAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=EOHe3djSOCTuYt7jKFKoVMSvjUaO7l16O6M0jH9Difv6Wj7i4dqcGRbOWPGFbKMbOY GF4s+LdYuMzpyZHagCL/H68jaF7r0LaQCAQEOaenUfbd5BHyxpNxU4D9bOOYP0eEgIWA OO0DKzz1o/25/RdgWBjPSGqE/BtnM6X3besT2MOMiweyXwxvcgoQ9FDGX2ycTgae0bgy tLDzJE3LMIuyHO4qegzE3VtM+3/FCZf1ofebkxQ0rcTFUHqdEcB3jncNKQbmsSoIrg/X HdPf4K8m5oXpHhbSRLcjGBaKodwzKD6zTfWk7aidQv9u6N62wQBu0AB8VyOYIFwdXKUv yxxg== X-Gm-Message-State: AOAM5338qPaJy+A571akTDSoS2cVyE3yUdANhhCEIO1C8n9+q1mEs2BZ x1zmXUtB9XZk/8yvcCMvYuvQDtcJXcBFIuigCMg= X-Google-Smtp-Source: ABdhPJzgAY6KtKOPC6tfzKmvA8QQMoxhHFJsZyDBWBxynYs54LG5exJnFVce2ePcyXh7zbs+RcwK2Q1VsHbq+C9CSvQ= X-Received: by 2002:a05:6638:1351:: with SMTP id u17mr1911170jad.120.1604062698162; Fri, 30 Oct 2020 05:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20201027183149.145165-1-peron.clem@gmail.com> <20201027183149.145165-2-peron.clem@gmail.com> <01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com> <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> In-Reply-To: <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Fri, 30 Oct 2020 13:58:07 +0100 Message-ID: Subject: Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Samuel Holland Cc: Pierre-Louis Bossart , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Brown , Liam Girdwood , devicetree , Jernej Skrabec , Linux-ALSA , linux-kernel , Takashi Iwai , Marcus Cooper , linux-sunxi , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Samuel On Fri, 30 Oct 2020 at 02:20, Samuel Holland wrote: > > On 10/27/20 4:43 PM, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi Pierre-Louis, > > > > On Tue, 27 Oct 2020 at 19:59, Pierre-Louis Bossart > > wrote: > >> > >> > >>> @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct = sun4i_i2s *i2s, > >>> case SND_SOC_DAIFMT_DSP_B: > >>> case SND_SOC_DAIFMT_LEFT_J: > >>> case SND_SOC_DAIFMT_RIGHT_J: > >>> - lrck_period =3D params_physical_width(params) * slots; > >>> + lrck_period =3D slot_width * slots; > >>> break; > >>> > >>> case SND_SOC_DAIFMT_I2S: > >>> - lrck_period =3D params_physical_width(params); > >>> + lrck_period =3D slot_width; > >>> break; > >> > >> Aren't I2S, LEFT_J and RIGHT_J pretty much the same in terms of lrclk > >> rate/period? the only thing that can change is the polarity, no? > >> > >> Not sure why it's handled differently here? > > > > I just had a look at the User Manual for H3 and H6 and I didn't find > > any reason why LEFT_J and RIGHT_J should be computed in a different > > way as I2S. > > Yes, and the manual explicitly groups LEFT_J and RIGHT_J with I2S when > describing this field: > > PCM Mode: Number of BCLKs within (Left + Right) channel width. > I2S/Left-Justified/Right-Justified Mode: Number of BCLKs within each > individual channel width(Left or Right) > > So I agree that the code is wrong here. Thanks, I will send a fix in the v10. Regards, Clement > > Regards, > Samuel > > > Also the commit introducing this doesn't mention it. > > 7ae7834ec446 ("ASoC: sun4i-i2s: Add support for DSP formats") > > > > I can't test it with my board but if nobody complains about it, I will > > introduce a fix for this in the next version and change this also for > > H6. > > > > Thanks for your review, > > Clement > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D4CC4363A for ; Fri, 30 Oct 2020 12:59:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3385A20725 for ; Fri, 30 Oct 2020 12:59:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="cfOSqsP2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBlLv1td" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3385A20725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ED9B11612; Fri, 30 Oct 2020 13:58:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ED9B11612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604062760; bh=PD8IIz3xmHes+6xizscwPFxY6dVUIKHCcvv7yodn2cY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cfOSqsP23fzSDOLieC0DWAaAAKi44gqE2XavPcHMwRrYwJN9NAirr0peM/ocSUdPL jESnq8XUIGB0YKxSIG0KA/vvUozDMq970gpg4oC8rmpfjtresIp2fIEB7LgspspVTX 1e60+186Yw5OdB7JAKYaNwnyjq3AU0hvqeSxLccU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B17CF800FF; Fri, 30 Oct 2020 13:58:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E555DF80212; Fri, 30 Oct 2020 13:58:27 +0100 (CET) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 75D96F800FF for ; Fri, 30 Oct 2020 13:58:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 75D96F800FF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBlLv1td" Received: by mail-io1-xd43.google.com with SMTP id r9so7368257ioo.7 for ; Fri, 30 Oct 2020 05:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=HBlLv1td8ZGbbQpa0MJPMXQx1wDSoEh19ueH+HpLQn7HCeunMObf8TyVowEs6h3R1m iO4vu+D+ag+gypjHMSJ/h5TbRu/++9EMN4/xsfsDdMPaUZtE4oFglwtgR08CcW2G2AdX UmlQm9AfRndgv1zsgN3sTlb+QByMJzLQycWwoPdDgQWPlOLC+3cw/yAxHS9xGEcsfk25 oL5Gr2GsEfDIMPaQ/3v0cjoZYemL+EIxWgI9EmA1QEc1Kc55bB7q7X6z5rvkgrdV8Wln YUSHz2U73sjUjSPC7fP0Cum01fYXKZPtnwqJrgS23oaIaaD/6+9OjVGgGaguXxagZ3Lq 1xAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=LLoW836qjnp/suJOwDlhwgxCo6a61sMY00kCmlouEBMf0cgoLMXPrp0h3/9kPF8ZKN RcGfoRvPFcjudOkv6Cw2Lfm7Dk6PiVSmcOnSW2rPEdBT/cJXznp/X+j9AkSIIRbkUF35 T5KtAiv59fYF77PyWZ/vtzOnQugrw4L+wZi1QwMfXc4UmFCgnltrB0jHuiOUmzuPmDUE N8oz+TPWOaBIlYUZm6C66xz5LmnJHmiQx3Qy5o/K79In4EzJOrzuk1cdYo4ggdKPyDDz zVUTpBk7KUxe3q5i23K2ygU92RZhi7tlMgwnl+Ta0F8sHWEwmCiMaMw/66ExTy3UxoXB gGUA== X-Gm-Message-State: AOAM531eBXYea2/0vnqVDLZEMh7oBxLIcKVPK6vWZmT1YGhlYDga5Bqd d5kABqLvmAKMmd/RPQCAk4iHi3ycksfnRI9gn3o= X-Google-Smtp-Source: ABdhPJzgAY6KtKOPC6tfzKmvA8QQMoxhHFJsZyDBWBxynYs54LG5exJnFVce2ePcyXh7zbs+RcwK2Q1VsHbq+C9CSvQ= X-Received: by 2002:a05:6638:1351:: with SMTP id u17mr1911170jad.120.1604062698162; Fri, 30 Oct 2020 05:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20201027183149.145165-1-peron.clem@gmail.com> <20201027183149.145165-2-peron.clem@gmail.com> <01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com> <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> In-Reply-To: <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Fri, 30 Oct 2020 13:58:07 +0100 Message-ID: Subject: Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Samuel Holland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Jernej Skrabec , linux-sunxi , Linux-ALSA , linux-kernel , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , Maxime Ripard , Liam Girdwood , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Samuel On Fri, 30 Oct 2020 at 02:20, Samuel Holland wrote: > > On 10/27/20 4:43 PM, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi Pierre-Louis, > > > > On Tue, 27 Oct 2020 at 19:59, Pierre-Louis Bossart > > wrote: > >> > >> > >>> @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct = sun4i_i2s *i2s, > >>> case SND_SOC_DAIFMT_DSP_B: > >>> case SND_SOC_DAIFMT_LEFT_J: > >>> case SND_SOC_DAIFMT_RIGHT_J: > >>> - lrck_period =3D params_physical_width(params) * slots; > >>> + lrck_period =3D slot_width * slots; > >>> break; > >>> > >>> case SND_SOC_DAIFMT_I2S: > >>> - lrck_period =3D params_physical_width(params); > >>> + lrck_period =3D slot_width; > >>> break; > >> > >> Aren't I2S, LEFT_J and RIGHT_J pretty much the same in terms of lrclk > >> rate/period? the only thing that can change is the polarity, no? > >> > >> Not sure why it's handled differently here? > > > > I just had a look at the User Manual for H3 and H6 and I didn't find > > any reason why LEFT_J and RIGHT_J should be computed in a different > > way as I2S. > > Yes, and the manual explicitly groups LEFT_J and RIGHT_J with I2S when > describing this field: > > PCM Mode: Number of BCLKs within (Left + Right) channel width. > I2S/Left-Justified/Right-Justified Mode: Number of BCLKs within each > individual channel width(Left or Right) > > So I agree that the code is wrong here. Thanks, I will send a fix in the v10. Regards, Clement > > Regards, > Samuel > > > Also the commit introducing this doesn't mention it. > > 7ae7834ec446 ("ASoC: sun4i-i2s: Add support for DSP formats") > > > > I can't test it with my board but if nobody complains about it, I will > > introduce a fix for this in the next version and change this also for > > H6. > > > > Thanks for your review, > > Clement > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2862CC4363A for ; Fri, 30 Oct 2020 12:59:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95FE520725 for ; Fri, 30 Oct 2020 12:59:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ARTHthM9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBlLv1td" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FE520725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xMD8SkWzQGUzwDoqZnhICpPjxiKDAsAqg4N+qD2f+7Q=; b=ARTHthM9Tm6bIkUlMJPoDF+Y0 i1nR99t4NMpOE33ZEZPM3w7sIxi7esjGhcqBhw/CmRFjJDJy3m27U2YMwFps3S30IeNI4Qm9s2XCX rBfYEkiK3a2oL1CWgmrHDpBssL78lf7z2zZCR74olDewINqXVKoCFrHUdHa+0HDF4d1hTQzS587KV 7wgqfwirzS+dLgjialeokPwXg8K6pz6JPq7ECgHA3xbPz1/dK3JCP/lmUZF6y9lze0CiVYWWPdG29 irwMK/2bk8UeVdeDDM6pnyfQo60hzAlMjhb3aMNByRAKgeVkj5zZY38KX0DNqA3ZNrYIPwfihBsfi lskIvDStg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYTz6-0005x5-0I; Fri, 30 Oct 2020 12:58:24 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYTz3-0005wP-HH for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 12:58:22 +0000 Received: by mail-io1-xd42.google.com with SMTP id k21so7359855ioa.9 for ; Fri, 30 Oct 2020 05:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=HBlLv1td8ZGbbQpa0MJPMXQx1wDSoEh19ueH+HpLQn7HCeunMObf8TyVowEs6h3R1m iO4vu+D+ag+gypjHMSJ/h5TbRu/++9EMN4/xsfsDdMPaUZtE4oFglwtgR08CcW2G2AdX UmlQm9AfRndgv1zsgN3sTlb+QByMJzLQycWwoPdDgQWPlOLC+3cw/yAxHS9xGEcsfk25 oL5Gr2GsEfDIMPaQ/3v0cjoZYemL+EIxWgI9EmA1QEc1Kc55bB7q7X6z5rvkgrdV8Wln YUSHz2U73sjUjSPC7fP0Cum01fYXKZPtnwqJrgS23oaIaaD/6+9OjVGgGaguXxagZ3Lq 1xAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DEjwCz6RYcTNQfWnCWPDSlK+EiMHXu1I2qKUPcY2Sh4=; b=BKpgziOlkzA3XZnAcmrW9u8EuwKgFR0ogqRjSxyVnvDNNwVl+N9HwT82gt9y+cJx78 51k2CXi09OdW7O/EwQlsJMNJBiLmQlPrByOLHrsY98jlblQCR/2/pZVqQHTb1nALgFl0 lVkB4IYaBbv7NoBatSX0JvtTcqznXDUhc+XTeUTfqH/yeoQbPLfd6dgrJMUbE4iPjO05 WR5Sr+bz+s/hHWRrQkXXwIB/1AD+BEnwgbBQe8l6OoNOVN6Vk2xm7EkqZJD9C8WLbFee F0oMjwespVJOvdfeMyjIckbmfHwgw4tasIryh1zvXt4YcAD+Bh2Bp2um/DlViFsCrTZQ MNcg== X-Gm-Message-State: AOAM533LHCDV7Zjig1u+Bj2lgV062JEP5lUyd+DasSYmb/i5p1XHJ0fn ktJjyo9UUydph/EG/GUN9CKMZJCUihVkiFuStPU= X-Google-Smtp-Source: ABdhPJzgAY6KtKOPC6tfzKmvA8QQMoxhHFJsZyDBWBxynYs54LG5exJnFVce2ePcyXh7zbs+RcwK2Q1VsHbq+C9CSvQ= X-Received: by 2002:a05:6638:1351:: with SMTP id u17mr1911170jad.120.1604062698162; Fri, 30 Oct 2020 05:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20201027183149.145165-1-peron.clem@gmail.com> <20201027183149.145165-2-peron.clem@gmail.com> <01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com> <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> In-Reply-To: <3f0c46e2-24a4-b6ee-1ea2-9de5344cfb9d@sholland.org> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Fri, 30 Oct 2020 13:58:07 +0100 Message-ID: Subject: Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Samuel Holland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_085821_594589_8F8B5074 X-CRM114-Status: GOOD ( 23.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , linux-sunxi , Linux-ALSA , linux-kernel , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , Maxime Ripard , Liam Girdwood , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2FtdWVsCgpPbiBGcmksIDMwIE9jdCAyMDIwIGF0IDAyOjIwLCBTYW11ZWwgSG9sbGFuZCA8 c2FtdWVsQHNob2xsYW5kLm9yZz4gd3JvdGU6Cj4KPiBPbiAxMC8yNy8yMCA0OjQzIFBNLCBDbMOp bWVudCBQw6lyb24gd3JvdGU6Cj4gPiBIaSBQaWVycmUtTG91aXMsCj4gPgo+ID4gT24gVHVlLCAy NyBPY3QgMjAyMCBhdCAxOTo1OSwgUGllcnJlLUxvdWlzIEJvc3NhcnQKPiA+IDxwaWVycmUtbG91 aXMuYm9zc2FydEBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+Cj4gPj4KPiA+Pj4gQEAgLTQ1 MiwxMSArNDU0LDExIEBAIHN0YXRpYyBpbnQgc3VuOGlfaTJzX3NldF9jaGFuX2NmZyhjb25zdCBz dHJ1Y3Qgc3VuNGlfaTJzICppMnMsCj4gPj4+ICAgICAgIGNhc2UgU05EX1NPQ19EQUlGTVRfRFNQ X0I6Cj4gPj4+ICAgICAgIGNhc2UgU05EX1NPQ19EQUlGTVRfTEVGVF9KOgo+ID4+PiAgICAgICBj YXNlIFNORF9TT0NfREFJRk1UX1JJR0hUX0o6Cj4gPj4+IC0gICAgICAgICAgICAgbHJja19wZXJp b2QgPSBwYXJhbXNfcGh5c2ljYWxfd2lkdGgocGFyYW1zKSAqIHNsb3RzOwo+ID4+PiArICAgICAg ICAgICAgIGxyY2tfcGVyaW9kID0gc2xvdF93aWR0aCAqIHNsb3RzOwo+ID4+PiAgICAgICAgICAg ICAgIGJyZWFrOwo+ID4+Pgo+ID4+PiAgICAgICBjYXNlIFNORF9TT0NfREFJRk1UX0kyUzoKPiA+ Pj4gLSAgICAgICAgICAgICBscmNrX3BlcmlvZCA9IHBhcmFtc19waHlzaWNhbF93aWR0aChwYXJh bXMpOwo+ID4+PiArICAgICAgICAgICAgIGxyY2tfcGVyaW9kID0gc2xvdF93aWR0aDsKPiA+Pj4g ICAgICAgICAgICAgICBicmVhazsKPiA+Pgo+ID4+IEFyZW4ndCBJMlMsIExFRlRfSiBhbmQgUklH SFRfSiBwcmV0dHkgbXVjaCB0aGUgc2FtZSBpbiB0ZXJtcyBvZiBscmNsawo+ID4+IHJhdGUvcGVy aW9kPyB0aGUgb25seSB0aGluZyB0aGF0IGNhbiBjaGFuZ2UgaXMgdGhlIHBvbGFyaXR5LCBubz8K PiA+Pgo+ID4+IE5vdCBzdXJlIHdoeSBpdCdzIGhhbmRsZWQgZGlmZmVyZW50bHkgaGVyZT8KPiA+ Cj4gPiBJIGp1c3QgaGFkIGEgbG9vayBhdCB0aGUgVXNlciBNYW51YWwgZm9yIEgzIGFuZCBINiBh bmQgSSBkaWRuJ3QgZmluZAo+ID4gYW55IHJlYXNvbiB3aHkgTEVGVF9KIGFuZCBSSUdIVF9KIHNo b3VsZCBiZSBjb21wdXRlZCBpbiBhIGRpZmZlcmVudAo+ID4gd2F5IGFzIEkyUy4KPgo+IFllcywg YW5kIHRoZSBtYW51YWwgZXhwbGljaXRseSBncm91cHMgTEVGVF9KIGFuZCBSSUdIVF9KIHdpdGgg STJTIHdoZW4KPiBkZXNjcmliaW5nIHRoaXMgZmllbGQ6Cj4KPiAgICBQQ00gTW9kZTogTnVtYmVy IG9mIEJDTEtzIHdpdGhpbiAoTGVmdCArIFJpZ2h0KSBjaGFubmVsIHdpZHRoLgo+ICAgIEkyUy9M ZWZ0LUp1c3RpZmllZC9SaWdodC1KdXN0aWZpZWQgTW9kZTogTnVtYmVyIG9mIEJDTEtzIHdpdGhp biBlYWNoCj4gaW5kaXZpZHVhbCBjaGFubmVsIHdpZHRoKExlZnQgb3IgUmlnaHQpCj4KPiBTbyBJ IGFncmVlIHRoYXQgdGhlIGNvZGUgaXMgd3JvbmcgaGVyZS4KClRoYW5rcywgSSB3aWxsIHNlbmQg YSBmaXggaW4gdGhlIHYxMC4KClJlZ2FyZHMsCkNsZW1lbnQKCj4KPiBSZWdhcmRzLAo+IFNhbXVl bAo+Cj4gPiBBbHNvIHRoZSBjb21taXQgaW50cm9kdWNpbmcgdGhpcyBkb2Vzbid0IG1lbnRpb24g aXQuCj4gPiA3YWU3ODM0ZWM0NDYgKCJBU29DOiBzdW40aS1pMnM6IEFkZCBzdXBwb3J0IGZvciBE U1AgZm9ybWF0cyIpCj4gPgo+ID4gSSBjYW4ndCB0ZXN0IGl0IHdpdGggbXkgYm9hcmQgYnV0IGlm IG5vYm9keSBjb21wbGFpbnMgYWJvdXQgaXQsIEkgd2lsbAo+ID4gaW50cm9kdWNlIGEgZml4IGZv ciB0aGlzIGluIHRoZSBuZXh0IHZlcnNpb24gYW5kIGNoYW5nZSB0aGlzIGFsc28gZm9yCj4gPiBI Ni4KPiA+Cj4gPiBUaGFua3MgZm9yIHlvdXIgcmV2aWV3LAo+ID4gQ2xlbWVudAo+ID4KPgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=