From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70A8C4741F for ; Mon, 28 Sep 2020 14:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8059321D7F for ; Mon, 28 Sep 2020 14:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZaF2CtE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbgI1Osd (ORCPT ); Mon, 28 Sep 2020 10:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbgI1Osd (ORCPT ); Mon, 28 Sep 2020 10:48:33 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CB4C061755; Mon, 28 Sep 2020 07:48:33 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id e5so1494837ilr.8; Mon, 28 Sep 2020 07:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=OZaF2CtEYFnNkMyOeRvFckPCRRkEvcgqI67p4VJ2nRQ+vdrZBAapya5VQMhVGqa0Pc xM1jN+mltbWDKKk8popL015Sl6sfWqKh+D66ChLMhLuVJu8V5hAQbzLrwIwlkOHBrsAU hCeIuDm/Baedvbmnv5KQQfsTPj+vjenjt6PX1yPbszShovNQ8uAPEDS5tGTRhk6A5GXA dGsUTLxW9XdXjuLFzEnYTHoCDKph1NapO6746XVw6TL/NCQDzntdVyRLLYVZRdbyf3JA QbYIb0ekb+W3b7D/H1r1wCOfVvs2HAQiNWqq1npY7QSVhPe8ILYg21nWzt7uf+PO2zMs q1Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=Bnmk54xQNba9qFZBAQ9eLiU54ao+8CZ0PZvN8+64tvKh1iSKy3wqppw0qNmwywDXQp j3FbDH+TAGr6QMEdDjZxqe9nSRpiNal9wt5TbdRrUVgYrys2I+0a1WEC7Gl+vsMGlf94 orLDvW8v1u2BfdAN8i0vTU1lo9jE8krd/Gng3pElfUEjk9+Zxm096kFSZn77dyImMK2v TQE9VAZEx0/bWGBI0Bj8qE/78UFKgEpY8bP4B8nR4pNwxChD4IVSbkYYZTzvxZF9H+TO z3GRUoWuABNNsBkcUuHcN79ZFAkSEa8YrdAITu5wCQGoufBzTr07AyKSGGyT6Mm9n7c4 hjww== X-Gm-Message-State: AOAM533LwKd19SiCiD3XFWAFic7oZznJlzZYHXEeFQIojW6TrcE+Y20f rK6gG3pidcYujM+dsh0uskshl7sYTgcAn+7Va1o= X-Google-Smtp-Source: ABdhPJyzQtJ4Wq6iMS79WrUFhP9745qmyzAStclm/SXxrx+gsno8hRzUha9nYwTBHlnwHYeP91NhtWzAzwbYb+tVqNc= X-Received: by 2002:a92:217:: with SMTP id 23mr1544245ilc.118.1601304512241; Mon, 28 Sep 2020 07:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-3-peron.clem@gmail.com> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 28 Sep 2020 16:48:21 +0200 Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Chen-Yu Tsai Cc: Maxime Ripard , Rob Herring , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Marcus Cooper , Jernej Skrabec , Linux-ALSA , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi , Samuel Holland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, On Mon, 28 Sep 2020 at 07:00, Chen-Yu Tsai wrote: > > On Mon, Sep 28, 2020 at 3:29 AM Cl=C3=A9ment P=C3=A9ron wrote: > > > > As slots and slot_width can be overwritter in case set_tdm() is > > called. Avoid to have this logic in set_chan_cfg(). > > It doesn't seem that set_tdm_slot() would get called concurrently > with hw_params(), at least not for the simple-card family. If so > then we'd have more problems like mismatched slots/slot-width > due to no serialization when interacting with those values. Sorry maybe the commit log is not clear. I was not talking about a concurrent effect but more if the slot_width is s= etted then we don't properly use it later. > > > Instead pass the required values as params to set_chan_cfg(). > > > > This will also avoid a bug when we will enable 20/24bits support, > > i2s->slot_width is not actually used in the lrck_period computation. > > > > Suggested-by: Samuel Holland > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > --- > > sound/soc/sunxi/sun4i-i2s.c | 36 ++++++++++++++---------------------- > > 1 file changed, 14 insertions(+), 22 deletions(-) > > > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > > index 2baf6c276280..0633b9fba3d7 100644 > > --- a/sound/soc/sunxi/sun4i-i2s.c > > +++ b/sound/soc/sunxi/sun4i-i2s.c > > @@ -177,8 +177,9 @@ struct sun4i_i2s_quirks { > > unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *)= ; > > s8 (*get_sr)(const struct sun4i_i2s *, int); > > s8 (*get_wss)(const struct sun4i_i2s *, int); > > - int (*set_chan_cfg)(const struct sun4i_i2s *, > > - const struct snd_pcm_hw_params *); > > + int (*set_chan_cfg)(const struct sun4i_i2s *i2s, > > + unsigned int channels, unsigned int sl= ots, > > + unsigned int slot_width); > > int (*set_fmt)(const struct sun4i_i2s *, unsigned int); > > }; > > > > @@ -414,10 +415,9 @@ static s8 sun8i_i2s_get_sr_wss(const struct sun4i_= i2s *i2s, int width) > > } > > > > static int sun4i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > > - const struct snd_pcm_hw_params *param= s) > > + unsigned int channels, unsigned int s= lots, > > + unsigned int slot_width) > > { > > - unsigned int channels =3D params_channels(params); > > - > > /* Map the channels for playback and capture */ > > regmap_write(i2s->regmap, SUN4I_I2S_TX_CHAN_MAP_REG, 0x76543210= ); > > regmap_write(i2s->regmap, SUN4I_I2S_RX_CHAN_MAP_REG, 0x00003210= ); > > @@ -434,15 +434,11 @@ static int sun4i_i2s_set_chan_cfg(const struct su= n4i_i2s *i2s, > > } > > > > static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > > - const struct snd_pcm_hw_params *param= s) > > + unsigned int channels, unsigned int s= lots, > > + unsigned int slot_width) > > { > > - unsigned int channels =3D params_channels(params); > > - unsigned int slots =3D channels; > > unsigned int lrck_period; > > > > - if (i2s->slots) > > - slots =3D i2s->slots; > > - > > Based on the bug you highlighted in your expanded commit log, the simpler= fix > would be to look at i2s->slot_width in addition to i2s->slots, and replac= e > params_physical_width(params) accordingly. That's what I did in the first version but was pointed out by Samuel that the same logic was done several times. As I can avoid it by passing the correct params it's simpler. > > Also, I would put fixes (even preparatory ones) before patches that intro= duce > support for new features and hardware. That makes them easier to backport= if > needed. I will wait for Maxime to comment on this. Regarding the doc fixes tag should only be used to fix a previous commit. This will make the fixes commit a bit more complicated for stable kernel team. Thanks for your review :) Regards Clement > > > ChenYu > > > > /* Map the channels for playback and capture */ > > regmap_write(i2s->regmap, SUN8I_I2S_TX_CHAN_MAP_REG, 0x76543210= ); > > regmap_write(i2s->regmap, SUN8I_I2S_RX_CHAN_MAP_REG, 0x76543210= ); > > @@ -467,11 +463,11 @@ static int sun8i_i2s_set_chan_cfg(const struct su= n4i_i2s *i2s, > > case SND_SOC_DAIFMT_DSP_B: > > case SND_SOC_DAIFMT_LEFT_J: > > case SND_SOC_DAIFMT_RIGHT_J: > > - lrck_period =3D params_physical_width(params) * slots; > > + lrck_period =3D slot_width * slots; > > break; > > > > case SND_SOC_DAIFMT_I2S: > > - lrck_period =3D params_physical_width(params); > > + lrck_period =3D slot_width; > > break; > > > > default: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A425C2D0A8 for ; Mon, 28 Sep 2020 14:49:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61DBE21974 for ; Mon, 28 Sep 2020 14:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pZrWLHbU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZaF2CtE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61DBE21974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C5C1018D3; Mon, 28 Sep 2020 16:48:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C5C1018D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601304573; bh=lJpJGN/+62Nxv4FMKxF+98rPL2ohEYXv1OIIOFoRHcE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pZrWLHbU1o/arR/GTWLPDbpWkrBYVE9fsYmz4MeMJPAz47KtVRCNvBzDJiZWPj15D kgBj4fd8+mYc7NluBZioyRWYFTavWHpilgPnPWxh4h+iaysNpJqyYGQizwnnYHkEKz 4DRUJgFe4bqmQREYEjZblDTAdL/Aq+NQ5YK7PjNE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 23440F80115; Mon, 28 Sep 2020 16:48:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 94ADBF801ED; Mon, 28 Sep 2020 16:48:41 +0200 (CEST) Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4877AF800FD for ; Mon, 28 Sep 2020 16:48:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4877AF800FD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZaF2CtE" Received: by mail-il1-x143.google.com with SMTP id y2so1523089ila.0 for ; Mon, 28 Sep 2020 07:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=OZaF2CtEYFnNkMyOeRvFckPCRRkEvcgqI67p4VJ2nRQ+vdrZBAapya5VQMhVGqa0Pc xM1jN+mltbWDKKk8popL015Sl6sfWqKh+D66ChLMhLuVJu8V5hAQbzLrwIwlkOHBrsAU hCeIuDm/Baedvbmnv5KQQfsTPj+vjenjt6PX1yPbszShovNQ8uAPEDS5tGTRhk6A5GXA dGsUTLxW9XdXjuLFzEnYTHoCDKph1NapO6746XVw6TL/NCQDzntdVyRLLYVZRdbyf3JA QbYIb0ekb+W3b7D/H1r1wCOfVvs2HAQiNWqq1npY7QSVhPe8ILYg21nWzt7uf+PO2zMs q1Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=hUnqIYFQNjYqh0Reo7He+KC2dK7SUQLygN6RiwCj5b+brQKiF90192aHA9wkirRMDm eLTknEnDhYAKr1CZg9Rttl8yv3sOe+wUOqYlwFWR7F/FrwEQXaBafHVvveWzUupFSMHh neCWwu3ibPmTcvzLSLCH7/3w7p3jjmFSz9gh6HFqt+WlaP7h7cVBZKr9oZL8DEoFWxT6 f1GdDrFuMVrHb6pusLFWLCV1YNIrqJmPxD6ETix0bdozv3+OZB2BqbNK93iI2443l4C/ sZjKQs31xPt4TLYX6niiCz4sDdQwE5eV6cV39e/HRDGTxZ+wdwe73Yhmtze5PSeXdzXI vc/Q== X-Gm-Message-State: AOAM532Uh57nNPOTKmG1mHEyVmIN1YMbRWV9Uq2lhIccxVUCUSagU9jD DgVmAMAY2dMfxiBnnFpxazpdiBl9yHY0crFdUSc= X-Google-Smtp-Source: ABdhPJyzQtJ4Wq6iMS79WrUFhP9745qmyzAStclm/SXxrx+gsno8hRzUha9nYwTBHlnwHYeP91NhtWzAzwbYb+tVqNc= X-Received: by 2002:a92:217:: with SMTP id 23mr1544245ilc.118.1601304512241; Mon, 28 Sep 2020 07:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-3-peron.clem@gmail.com> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 28 Sep 2020 16:48:21 +0200 Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Jernej Skrabec , Linux-ALSA , Samuel Holland , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Chen-Yu, On Mon, 28 Sep 2020 at 07:00, Chen-Yu Tsai wrote: > > On Mon, Sep 28, 2020 at 3:29 AM Cl=C3=A9ment P=C3=A9ron wrote: > > > > As slots and slot_width can be overwritter in case set_tdm() is > > called. Avoid to have this logic in set_chan_cfg(). > > It doesn't seem that set_tdm_slot() would get called concurrently > with hw_params(), at least not for the simple-card family. If so > then we'd have more problems like mismatched slots/slot-width > due to no serialization when interacting with those values. Sorry maybe the commit log is not clear. I was not talking about a concurrent effect but more if the slot_width is s= etted then we don't properly use it later. > > > Instead pass the required values as params to set_chan_cfg(). > > > > This will also avoid a bug when we will enable 20/24bits support, > > i2s->slot_width is not actually used in the lrck_period computation. > > > > Suggested-by: Samuel Holland > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > --- > > sound/soc/sunxi/sun4i-i2s.c | 36 ++++++++++++++---------------------- > > 1 file changed, 14 insertions(+), 22 deletions(-) > > > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > > index 2baf6c276280..0633b9fba3d7 100644 > > --- a/sound/soc/sunxi/sun4i-i2s.c > > +++ b/sound/soc/sunxi/sun4i-i2s.c > > @@ -177,8 +177,9 @@ struct sun4i_i2s_quirks { > > unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *)= ; > > s8 (*get_sr)(const struct sun4i_i2s *, int); > > s8 (*get_wss)(const struct sun4i_i2s *, int); > > - int (*set_chan_cfg)(const struct sun4i_i2s *, > > - const struct snd_pcm_hw_params *); > > + int (*set_chan_cfg)(const struct sun4i_i2s *i2s, > > + unsigned int channels, unsigned int sl= ots, > > + unsigned int slot_width); > > int (*set_fmt)(const struct sun4i_i2s *, unsigned int); > > }; > > > > @@ -414,10 +415,9 @@ static s8 sun8i_i2s_get_sr_wss(const struct sun4i_= i2s *i2s, int width) > > } > > > > static int sun4i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > > - const struct snd_pcm_hw_params *param= s) > > + unsigned int channels, unsigned int s= lots, > > + unsigned int slot_width) > > { > > - unsigned int channels =3D params_channels(params); > > - > > /* Map the channels for playback and capture */ > > regmap_write(i2s->regmap, SUN4I_I2S_TX_CHAN_MAP_REG, 0x76543210= ); > > regmap_write(i2s->regmap, SUN4I_I2S_RX_CHAN_MAP_REG, 0x00003210= ); > > @@ -434,15 +434,11 @@ static int sun4i_i2s_set_chan_cfg(const struct su= n4i_i2s *i2s, > > } > > > > static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > > - const struct snd_pcm_hw_params *param= s) > > + unsigned int channels, unsigned int s= lots, > > + unsigned int slot_width) > > { > > - unsigned int channels =3D params_channels(params); > > - unsigned int slots =3D channels; > > unsigned int lrck_period; > > > > - if (i2s->slots) > > - slots =3D i2s->slots; > > - > > Based on the bug you highlighted in your expanded commit log, the simpler= fix > would be to look at i2s->slot_width in addition to i2s->slots, and replac= e > params_physical_width(params) accordingly. That's what I did in the first version but was pointed out by Samuel that the same logic was done several times. As I can avoid it by passing the correct params it's simpler. > > Also, I would put fixes (even preparatory ones) before patches that intro= duce > support for new features and hardware. That makes them easier to backport= if > needed. I will wait for Maxime to comment on this. Regarding the doc fixes tag should only be used to fix a previous commit. This will make the fixes commit a bit more complicated for stable kernel team. Thanks for your review :) Regards Clement > > > ChenYu > > > > /* Map the channels for playback and capture */ > > regmap_write(i2s->regmap, SUN8I_I2S_TX_CHAN_MAP_REG, 0x76543210= ); > > regmap_write(i2s->regmap, SUN8I_I2S_RX_CHAN_MAP_REG, 0x76543210= ); > > @@ -467,11 +463,11 @@ static int sun8i_i2s_set_chan_cfg(const struct su= n4i_i2s *i2s, > > case SND_SOC_DAIFMT_DSP_B: > > case SND_SOC_DAIFMT_LEFT_J: > > case SND_SOC_DAIFMT_RIGHT_J: > > - lrck_period =3D params_physical_width(params) * slots; > > + lrck_period =3D slot_width * slots; > > break; > > > > case SND_SOC_DAIFMT_I2S: > > - lrck_period =3D params_physical_width(params); > > + lrck_period =3D slot_width; > > break; > > > > default: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C79C2D0A8 for ; Mon, 28 Sep 2020 14:49:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 210F121941 for ; Mon, 28 Sep 2020 14:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jKQf7Oe2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZaF2CtE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 210F121941 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fs6OAf7x/n0ETJ0yQnvxd9SSyTBk/k0k24ECM8m6bfs=; b=jKQf7Oe2DPnQ4Fbf64sSFhV10 ZsV/YX1L66yTRuCgF0zwR+A76sldpSCw1SQE3sSqMB8MnKGqBKiVNAdEKb6Aic2JFSMHtgxVa9KNA TdCNL4Fup4H/4MPbqhg6d30eUyqsUyL0z04msbrvLm0ln5h0uAd7xcgPJamA4X8WYrSGeuCCVJvTY dESXJrwM0ZnQSckfFQkdBE+iqkcSWGNPTTnNI/EU2JOmNjxCxQLzUc+kUsCYyKtBsifx3Elx/toF4 uno+N64B89PqN7VjK18WGUu43oZhLCz6iQeLUHvctEkF1yBX7wUushe5225ncqzevBzWD6TF3bWQE MudRBgDSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMuSE-0008EO-8R; Mon, 28 Sep 2020 14:48:38 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMuSB-0008D1-VN for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 14:48:36 +0000 Received: by mail-il1-x142.google.com with SMTP id f15so1514901ilj.2 for ; Mon, 28 Sep 2020 07:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=OZaF2CtEYFnNkMyOeRvFckPCRRkEvcgqI67p4VJ2nRQ+vdrZBAapya5VQMhVGqa0Pc xM1jN+mltbWDKKk8popL015Sl6sfWqKh+D66ChLMhLuVJu8V5hAQbzLrwIwlkOHBrsAU hCeIuDm/Baedvbmnv5KQQfsTPj+vjenjt6PX1yPbszShovNQ8uAPEDS5tGTRhk6A5GXA dGsUTLxW9XdXjuLFzEnYTHoCDKph1NapO6746XVw6TL/NCQDzntdVyRLLYVZRdbyf3JA QbYIb0ekb+W3b7D/H1r1wCOfVvs2HAQiNWqq1npY7QSVhPe8ILYg21nWzt7uf+PO2zMs q1Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vQtXU3enAOb8a0F7LbFZw7wLpO431aR2A2CY3HJMkgQ=; b=aH9RvK9l0mBYrJMUW60p/oA4zDGcxTEJcMemboUJ1o8LHuCv7tNmYlyG94tvYHNTJ4 Zd/LVYTsAWRyZGQUX460S/urfvGKmaLyf01NR/uNKRE4IP6e2m8ob0eXc0z/AIroGH2T ji4zHEkzCXcMhTWt/XJPNrK1tS8zIT5+BD0iz8ZJDkYJSk4yFbC/5HCzwvKk6FVZxl7r Ej2nK7LE2pUSTCr/wbP73mO4PPuYNYYo7huYgAjhNjHAYhvA5cP4ny0QCgyv2ph+ygFL H1Vfn6Myhb8B4Oq+mQZcUtSs859UlEAdl7sJ5xXwrYNHfmgcYxw3E+GaKmuorx+BGAc8 PJ5Q== X-Gm-Message-State: AOAM530EaL9LdJTkh0++i+a8TrdPU2I5Cf1I5XUUg40NwWH/hSXeZI3J NQcu5R2PMYCZrFd8TMmJkm/fWX9WyXvC1qyQYOM= X-Google-Smtp-Source: ABdhPJyzQtJ4Wq6iMS79WrUFhP9745qmyzAStclm/SXxrx+gsno8hRzUha9nYwTBHlnwHYeP91NhtWzAzwbYb+tVqNc= X-Received: by 2002:a92:217:: with SMTP id 23mr1544245ilc.118.1601304512241; Mon, 28 Sep 2020 07:48:32 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-3-peron.clem@gmail.com> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 28 Sep 2020 16:48:21 +0200 Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params To: Chen-Yu Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_104836_022228_D8EC1DE0 X-CRM114-Status: GOOD ( 33.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Linux-ALSA , Samuel Holland , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2hlbi1ZdSwKCk9uIE1vbiwgMjggU2VwIDIwMjAgYXQgMDc6MDAsIENoZW4tWXUgVHNhaSA8 d2Vuc0Bjc2llLm9yZz4gd3JvdGU6Cj4KPiBPbiBNb24sIFNlcCAyOCwgMjAyMCBhdCAzOjI5IEFN IENsw6ltZW50IFDDqXJvbiA8cGVyb24uY2xlbUBnbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IEFz IHNsb3RzIGFuZCBzbG90X3dpZHRoIGNhbiBiZSBvdmVyd3JpdHRlciBpbiBjYXNlIHNldF90ZG0o KSBpcwo+ID4gY2FsbGVkLiBBdm9pZCB0byBoYXZlIHRoaXMgbG9naWMgaW4gc2V0X2NoYW5fY2Zn KCkuCj4KPiBJdCBkb2Vzbid0IHNlZW0gdGhhdCBzZXRfdGRtX3Nsb3QoKSB3b3VsZCBnZXQgY2Fs bGVkIGNvbmN1cnJlbnRseQo+IHdpdGggaHdfcGFyYW1zKCksIGF0IGxlYXN0IG5vdCBmb3IgdGhl IHNpbXBsZS1jYXJkIGZhbWlseS4gSWYgc28KPiB0aGVuIHdlJ2QgaGF2ZSBtb3JlIHByb2JsZW1z IGxpa2UgbWlzbWF0Y2hlZCBzbG90cy9zbG90LXdpZHRoCj4gZHVlIHRvIG5vIHNlcmlhbGl6YXRp b24gd2hlbiBpbnRlcmFjdGluZyB3aXRoIHRob3NlIHZhbHVlcy4KClNvcnJ5IG1heWJlIHRoZSBj b21taXQgbG9nIGlzIG5vdCBjbGVhci4KSSB3YXMgbm90IHRhbGtpbmcgYWJvdXQgYSBjb25jdXJy ZW50IGVmZmVjdCBidXQgbW9yZSBpZiB0aGUgc2xvdF93aWR0aCBpcyBzZXR0ZWQKdGhlbiB3ZSBk b24ndCBwcm9wZXJseSB1c2UgaXQgbGF0ZXIuCgo+Cj4gPiBJbnN0ZWFkIHBhc3MgdGhlIHJlcXVp cmVkIHZhbHVlcyBhcyBwYXJhbXMgdG8gc2V0X2NoYW5fY2ZnKCkuCj4gPgo+ID4gVGhpcyB3aWxs IGFsc28gYXZvaWQgYSBidWcgd2hlbiB3ZSB3aWxsIGVuYWJsZSAyMC8yNGJpdHMgc3VwcG9ydCwK PiA+IGkycy0+c2xvdF93aWR0aCBpcyBub3QgYWN0dWFsbHkgdXNlZCBpbiB0aGUgbHJja19wZXJp b2QgY29tcHV0YXRpb24uCj4gPgo+ID4gU3VnZ2VzdGVkLWJ5OiBTYW11ZWwgSG9sbGFuZCA8c2Ft dWVsQHNob2xsYW5kLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IENsw6ltZW50IFDDqXJvbiA8cGVy b24uY2xlbUBnbWFpbC5jb20+Cj4gPiAtLS0KPiA+ICBzb3VuZC9zb2Mvc3VueGkvc3VuNGktaTJz LmMgfCAzNiArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAt LWdpdCBhL3NvdW5kL3NvYy9zdW54aS9zdW40aS1pMnMuYyBiL3NvdW5kL3NvYy9zdW54aS9zdW40 aS1pMnMuYwo+ID4gaW5kZXggMmJhZjZjMjc2MjgwLi4wNjMzYjlmYmEzZDcgMTAwNjQ0Cj4gPiAt LS0gYS9zb3VuZC9zb2Mvc3VueGkvc3VuNGktaTJzLmMKPiA+ICsrKyBiL3NvdW5kL3NvYy9zdW54 aS9zdW40aS1pMnMuYwo+ID4gQEAgLTE3Nyw4ICsxNzcsOSBAQCBzdHJ1Y3Qgc3VuNGlfaTJzX3F1 aXJrcyB7Cj4gPiAgICAgICAgIHVuc2lnbmVkIGxvbmcgKCpnZXRfYmNsa19wYXJlbnRfcmF0ZSko Y29uc3Qgc3RydWN0IHN1bjRpX2kycyAqKTsKPiA+ICAgICAgICAgczggICAgICAoKmdldF9zciko Y29uc3Qgc3RydWN0IHN1bjRpX2kycyAqLCBpbnQpOwo+ID4gICAgICAgICBzOCAgICAgICgqZ2V0 X3dzcykoY29uc3Qgc3RydWN0IHN1bjRpX2kycyAqLCBpbnQpOwo+ID4gLSAgICAgICBpbnQgICAg ICgqc2V0X2NoYW5fY2ZnKShjb25zdCBzdHJ1Y3Qgc3VuNGlfaTJzICosCj4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBzbmRfcGNtX2h3X3BhcmFtcyAqKTsK PiA+ICsgICAgICAgaW50ICAgICAoKnNldF9jaGFuX2NmZykoY29uc3Qgc3RydWN0IHN1bjRpX2ky cyAqaTJzLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQg Y2hhbm5lbHMsICB1bnNpZ25lZCBpbnQgc2xvdHMsCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBzbG90X3dpZHRoKTsKPiA+ICAgICAgICAgaW50ICAgICAo KnNldF9mbXQpKGNvbnN0IHN0cnVjdCBzdW40aV9pMnMgKiwgdW5zaWduZWQgaW50KTsKPiA+ICB9 Owo+ID4KPiA+IEBAIC00MTQsMTAgKzQxNSw5IEBAIHN0YXRpYyBzOCBzdW44aV9pMnNfZ2V0X3Ny X3dzcyhjb25zdCBzdHJ1Y3Qgc3VuNGlfaTJzICppMnMsIGludCB3aWR0aCkKPiA+ICB9Cj4gPgo+ ID4gIHN0YXRpYyBpbnQgc3VuNGlfaTJzX3NldF9jaGFuX2NmZyhjb25zdCBzdHJ1Y3Qgc3VuNGlf aTJzICppMnMsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3Ry dWN0IHNuZF9wY21faHdfcGFyYW1zICpwYXJhbXMpCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdW5zaWduZWQgaW50IGNoYW5uZWxzLCB1bnNpZ25lZCBpbnQgc2xvdHMsCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNsb3Rfd2lk dGgpCj4gPiAgewo+ID4gLSAgICAgICB1bnNpZ25lZCBpbnQgY2hhbm5lbHMgPSBwYXJhbXNfY2hh bm5lbHMocGFyYW1zKTsKPiA+IC0KPiA+ICAgICAgICAgLyogTWFwIHRoZSBjaGFubmVscyBmb3Ig cGxheWJhY2sgYW5kIGNhcHR1cmUgKi8KPiA+ICAgICAgICAgcmVnbWFwX3dyaXRlKGkycy0+cmVn bWFwLCBTVU40SV9JMlNfVFhfQ0hBTl9NQVBfUkVHLCAweDc2NTQzMjEwKTsKPiA+ICAgICAgICAg cmVnbWFwX3dyaXRlKGkycy0+cmVnbWFwLCBTVU40SV9JMlNfUlhfQ0hBTl9NQVBfUkVHLCAweDAw MDAzMjEwKTsKPiA+IEBAIC00MzQsMTUgKzQzNCwxMSBAQCBzdGF0aWMgaW50IHN1bjRpX2kyc19z ZXRfY2hhbl9jZmcoY29uc3Qgc3RydWN0IHN1bjRpX2kycyAqaTJzLAo+ID4gIH0KPiA+Cj4gPiAg c3RhdGljIGludCBzdW44aV9pMnNfc2V0X2NoYW5fY2ZnKGNvbnN0IHN0cnVjdCBzdW40aV9pMnMg KmkycywKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg c25kX3BjbV9od19wYXJhbXMgKnBhcmFtcykKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBpbnQgY2hhbm5lbHMsIHVuc2lnbmVkIGludCBzbG90cywKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc2xvdF93aWR0aCkK PiA+ICB7Cj4gPiAtICAgICAgIHVuc2lnbmVkIGludCBjaGFubmVscyA9IHBhcmFtc19jaGFubmVs cyhwYXJhbXMpOwo+ID4gLSAgICAgICB1bnNpZ25lZCBpbnQgc2xvdHMgPSBjaGFubmVsczsKPiA+ ICAgICAgICAgdW5zaWduZWQgaW50IGxyY2tfcGVyaW9kOwo+ID4KPiA+IC0gICAgICAgaWYgKGky cy0+c2xvdHMpCj4gPiAtICAgICAgICAgICAgICAgc2xvdHMgPSBpMnMtPnNsb3RzOwo+ID4gLQo+ Cj4gQmFzZWQgb24gdGhlIGJ1ZyB5b3UgaGlnaGxpZ2h0ZWQgaW4geW91ciBleHBhbmRlZCBjb21t aXQgbG9nLCB0aGUgc2ltcGxlciBmaXgKPiB3b3VsZCBiZSB0byBsb29rIGF0IGkycy0+c2xvdF93 aWR0aCBpbiBhZGRpdGlvbiB0byBpMnMtPnNsb3RzLCBhbmQgcmVwbGFjZQo+IHBhcmFtc19waHlz aWNhbF93aWR0aChwYXJhbXMpIGFjY29yZGluZ2x5LgoKVGhhdCdzIHdoYXQgSSBkaWQgaW4gdGhl IGZpcnN0IHZlcnNpb24gYnV0IHdhcyBwb2ludGVkIG91dCBieSBTYW11ZWwKdGhhdCB0aGUgc2Ft ZSBsb2dpYwp3YXMgZG9uZSBzZXZlcmFsIHRpbWVzLiBBcyBJIGNhbiBhdm9pZCBpdCBieSBwYXNz aW5nIHRoZSBjb3JyZWN0CnBhcmFtcyBpdCdzIHNpbXBsZXIuCgo+Cj4gQWxzbywgSSB3b3VsZCBw dXQgZml4ZXMgKGV2ZW4gcHJlcGFyYXRvcnkgb25lcykgYmVmb3JlIHBhdGNoZXMgdGhhdCBpbnRy b2R1Y2UKPiBzdXBwb3J0IGZvciBuZXcgZmVhdHVyZXMgYW5kIGhhcmR3YXJlLiBUaGF0IG1ha2Vz IHRoZW0gZWFzaWVyIHRvIGJhY2twb3J0IGlmCj4gbmVlZGVkLgoKSSB3aWxsIHdhaXQgZm9yIE1h eGltZSB0byBjb21tZW50IG9uIHRoaXMuIFJlZ2FyZGluZyB0aGUgZG9jIGZpeGVzIHRhZwpzaG91 bGQgb25seSBiZSB1c2VkCnRvIGZpeCBhIHByZXZpb3VzIGNvbW1pdC4gVGhpcyB3aWxsIG1ha2Ug dGhlIGZpeGVzIGNvbW1pdCBhIGJpdCBtb3JlCmNvbXBsaWNhdGVkIGZvciBzdGFibGUga2VybmVs IHRlYW0uCgpUaGFua3MgZm9yIHlvdXIgcmV2aWV3IDopCgpSZWdhcmRzCkNsZW1lbnQKCgo+Cj4K PiBDaGVuWXUKPgo+Cj4gPiAgICAgICAgIC8qIE1hcCB0aGUgY2hhbm5lbHMgZm9yIHBsYXliYWNr IGFuZCBjYXB0dXJlICovCj4gPiAgICAgICAgIHJlZ21hcF93cml0ZShpMnMtPnJlZ21hcCwgU1VO OElfSTJTX1RYX0NIQU5fTUFQX1JFRywgMHg3NjU0MzIxMCk7Cj4gPiAgICAgICAgIHJlZ21hcF93 cml0ZShpMnMtPnJlZ21hcCwgU1VOOElfSTJTX1JYX0NIQU5fTUFQX1JFRywgMHg3NjU0MzIxMCk7 Cj4gPiBAQCAtNDY3LDExICs0NjMsMTEgQEAgc3RhdGljIGludCBzdW44aV9pMnNfc2V0X2NoYW5f Y2ZnKGNvbnN0IHN0cnVjdCBzdW40aV9pMnMgKmkycywKPiA+ICAgICAgICAgY2FzZSBTTkRfU09D X0RBSUZNVF9EU1BfQjoKPiA+ICAgICAgICAgY2FzZSBTTkRfU09DX0RBSUZNVF9MRUZUX0o6Cj4g PiAgICAgICAgIGNhc2UgU05EX1NPQ19EQUlGTVRfUklHSFRfSjoKPiA+IC0gICAgICAgICAgICAg ICBscmNrX3BlcmlvZCA9IHBhcmFtc19waHlzaWNhbF93aWR0aChwYXJhbXMpICogc2xvdHM7Cj4g PiArICAgICAgICAgICAgICAgbHJja19wZXJpb2QgPSBzbG90X3dpZHRoICogc2xvdHM7Cj4gPiAg ICAgICAgICAgICAgICAgYnJlYWs7Cj4gPgo+ID4gICAgICAgICBjYXNlIFNORF9TT0NfREFJRk1U X0kyUzoKPiA+IC0gICAgICAgICAgICAgICBscmNrX3BlcmlvZCA9IHBhcmFtc19waHlzaWNhbF93 aWR0aChwYXJhbXMpOwo+ID4gKyAgICAgICAgICAgICAgIGxyY2tfcGVyaW9kID0gc2xvdF93aWR0 aDsKPiA+ICAgICAgICAgICAgICAgICBicmVhazsKPiA+Cj4gPiAgICAgICAgIGRlZmF1bHQ6Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==