From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4C5FC47247 for ; Thu, 30 Apr 2020 14:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84DE9206D9 for ; Thu, 30 Apr 2020 14:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wxsmkjon" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbgD3OAa (ORCPT ); Thu, 30 Apr 2020 10:00:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728169AbgD3OA0 (ORCPT ); Thu, 30 Apr 2020 10:00:26 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2413CC035494; Thu, 30 Apr 2020 07:00:26 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id u11so1553494iow.4; Thu, 30 Apr 2020 07:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=WxsmkjonITcLJ97YhEvjgmBobJxYhdcS0FMYbI0ha9eAYIbOvVa++0B/N61OFuA+vq TZYJoOOK1ZCNtDRuUb0+F6GjgICAVNM5rw4vEuVnM80xd3VkxSFGCpu0bX2tf4mdswgH D8T/Hct4kccVa1z5uGmKgC3cbV8W5/BGPIlISHzo6yjyI6Yd84kp1sl1eFHyPTD6GGmH 0Q1F1IZODwzZhcHFUAcQpScBz+tK/gV6IwRa2pAu8aiuKxSgJ9XM9CrOeEgOUpJR6Mg0 6oYATFOQutPCYugnCrV+5/HZ8KiRd7lgTda3lkj13rjmdcAeGR16UBPZIBdRZZnJts6f Vuww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=CiwWFwshQdvP92w7Gq4UFxS8dWY/QB4VLzrv/Fv5WzUuF1H2+udlUzzN0oNB5PrCp5 JDfW7qpXlB1CfLHp3qNnE4cvwmmsuBlkxpaQVoO8+yZRBwn06HweZtXwQqgFq9wn+BAw OhlJrMN9hF7/l6YD7tafQx4xByBQiOIoMRE6cjfAS/r1pvKjWSINoPOxc6oQDceCvuWR mzcLvzCjGCZiIARbyWCnPwKK9atKLl/idujJjghzNVZCL8hRNNt6Omnqr52iP9zwSK/K XOKHuBDj+D/1LFSFE6rGaoGYK0Ffhf2HLrwX0zc5KLKIYjOwtnCbmhDbmSgKltqJmQMm slBw== X-Gm-Message-State: AGi0Pub3N2Cxo4L39iufmf9A8KhU1QiVU9tQA3+2VW80YrTnnsM9sWK7 +RvhIB1Z0Vo2Rng1TbwF4efWg3ph+A6IJRbcZk4= X-Google-Smtp-Source: APiQypL/hGXbUxNw4AVM3ITxY+bWgZQNGgI8BdvnXtQMrcBmjvMtXdgrG7Lhm8mMQi0TVyWgoYz+zdbaXKGpRu9prEA= X-Received: by 2002:a6b:b8d6:: with SMTP id i205mr2058871iof.123.1588255225316; Thu, 30 Apr 2020 07:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20200426104115.22630-1-peron.clem@gmail.com> <20200426104115.22630-4-peron.clem@gmail.com> <20200428081321.ht3el26yqhsnyfm4@gilmour.lan> <20200429123529.y24dpy63wxq7uvkt@gilmour.lan> <20200430084600.samghw4zxb5zdbez@gilmour.lan> In-Reply-To: <20200430084600.samghw4zxb5zdbez@gilmour.lan> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 30 Apr 2020 16:00:14 +0200 Message-ID: Subject: Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S To: Maxime Ripard Cc: Liam Girdwood , Mark Brown , Rob Herring , Chen-Yu Tsai , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , devicetree , linux-arm-kernel , linux-kernel , Jernej Skrabec , Marcus Cooper Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > Hi, > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Cl=C3=A9ment P=C3=A9ron wro= te: > > > > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s, > > > > > > + unsigned int fmt) > > > > > > > > > > The alignment is off here > > > > > > > > > > > +{ > > > > > > + u32 mode, val; > > > > > > + u8 offset; > > > > > > + > > > > > > + /* > > > > > > + * DAI clock polarity > > > > > > + * > > > > > > + * The setup for LRCK contradicts the datasheet, but unde= r a > > > > > > + * scope it's clear that the LRCK polarity is reversed > > > > > > + * compared to the expected polarity on the bus. > > > > > > + */ > > > > > > > > > > Did you check this or has it been copy-pasted? > > > > > > > > copy-pasted, I will check this. > > > > > > It's not going to be easy to do this if you only have a board with HD= MI. If you > > > can't test that easily, just remove the comment (or make it explicit = that you > > > copy pasted it?), no comment is better than a wrong one. > > > > I have talked with Marcus Cooper it may be able to test this this week-= end. > > Also this can explain why we need the " > > simple-audio-card,frame-inversion;" in the device-tree. > > > > If think this fix has been introduced by you, correct? Could you say > > on which SoC did you see this issue? > > This was seen on an H3 Just two more questions: - Did you observe this issue on both TDM and I2S mode? - On which DAI node? Since recent change in sun4i-i2s.c, we had to introduce the "simple-audio-card,frame-inversion" in LibreElec tree. H3 boards are quite common in LibreElec community so I think: - This fix is only needed in TDM mode - Or this fix is not required for the HDMI DAI node (HDMI DAI is a little bit different compare to other DAI but I think the first guess is more likely) Regards, Clement > > Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902F2C83000 for ; Thu, 30 Apr 2020 14:21:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B827206D9 for ; Thu, 30 Apr 2020 14:21:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="tTmsfrDw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wxsmkjon" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B827206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 77B641665; Thu, 30 Apr 2020 16:21:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 77B641665 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588256511; bh=Shh8Hi6+q10K6dQe13kwf19fcf48z4r+Eq/hYrd3uw4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tTmsfrDwy6cU+y/dQmvblXdI5lKkkXmJV2iAnJ2jAEoiIVf6HacAF/D2GkLp+m3Ds QFNJ7gfm3rqN+5LZ5GJH1vaTjeGNpeEErZyS/kgGMI36iHmpxG2W4QHzFF1oz6eAw6 miLmnaaLli/h1CiKR/geZ1G1L5AYLByi69ovnXxU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8DD7BF802A8; Thu, 30 Apr 2020 16:00:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5498CF802A9; Thu, 30 Apr 2020 16:00:32 +0200 (CEST) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1F077F802A1 for ; Thu, 30 Apr 2020 16:00:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1F077F802A1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wxsmkjon" Received: by mail-io1-xd43.google.com with SMTP id w4so1548071ioc.6 for ; Thu, 30 Apr 2020 07:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=WxsmkjonITcLJ97YhEvjgmBobJxYhdcS0FMYbI0ha9eAYIbOvVa++0B/N61OFuA+vq TZYJoOOK1ZCNtDRuUb0+F6GjgICAVNM5rw4vEuVnM80xd3VkxSFGCpu0bX2tf4mdswgH D8T/Hct4kccVa1z5uGmKgC3cbV8W5/BGPIlISHzo6yjyI6Yd84kp1sl1eFHyPTD6GGmH 0Q1F1IZODwzZhcHFUAcQpScBz+tK/gV6IwRa2pAu8aiuKxSgJ9XM9CrOeEgOUpJR6Mg0 6oYATFOQutPCYugnCrV+5/HZ8KiRd7lgTda3lkj13rjmdcAeGR16UBPZIBdRZZnJts6f Vuww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=aKdak2lXDJDJ/eGCvJRNqTK6BGshMoNUQmdQgl8oAUqHDYQWxjV6ArL7utwPexpY4a 6giFesLsNQBt5fL1jRwLW42+SJe34dpI9YMkrLl7Q2aHt5Td/ageI86KZpoPqm5VA8ml GFZoHCX6TIPWfp5Va2F54Shfoi1er5BeX9qyxiIbz4CqjkYSXIfb75+AErMAbL0aqQrd vTW4gvv+QVQtUeNztCMfblVTydsE6dm3IAGb+93AWD9P3CbHaug83ScxeEWQCl2vlUCR bJbW9ocx0MnyK4FlLLhXkpOqp0moa4N2W89zQTLzfMtbVHGyIT3GpwoXQGyAimSczAFn 6DpQ== X-Gm-Message-State: AGi0PuYEasFC7sJpvkZ7QJdLKAQoB+fg5R1IyOIOMcu2Guf8b/2FgmlS nukV3ZFGyYhluCqv1hnMPpOQVd0xvvwn2qweRPU= X-Google-Smtp-Source: APiQypL/hGXbUxNw4AVM3ITxY+bWgZQNGgI8BdvnXtQMrcBmjvMtXdgrG7Lhm8mMQi0TVyWgoYz+zdbaXKGpRu9prEA= X-Received: by 2002:a6b:b8d6:: with SMTP id i205mr2058871iof.123.1588255225316; Thu, 30 Apr 2020 07:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20200426104115.22630-1-peron.clem@gmail.com> <20200426104115.22630-4-peron.clem@gmail.com> <20200428081321.ht3el26yqhsnyfm4@gilmour.lan> <20200429123529.y24dpy63wxq7uvkt@gilmour.lan> <20200430084600.samghw4zxb5zdbez@gilmour.lan> In-Reply-To: <20200430084600.samghw4zxb5zdbez@gilmour.lan> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 30 Apr 2020 16:00:14 +0200 Message-ID: Subject: Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Linux-ALSA , linux-kernel , Jernej Skrabec , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , Chen-Yu Tsai , Mark Brown , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Maxime, On Thu, 30 Apr 2020 at 10:46, Maxime Ripard wrote: > > Hi, > > On Wed, Apr 29, 2020 at 06:33:00PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > On Wed, 29 Apr 2020 at 14:35, Maxime Ripard wrote: > > > > > > On Tue, Apr 28, 2020 at 10:55:47AM +0200, Cl=C3=A9ment P=C3=A9ron wro= te: > > > > > > +static int sun50i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s, > > > > > > + unsigned int fmt) > > > > > > > > > > The alignment is off here > > > > > > > > > > > +{ > > > > > > + u32 mode, val; > > > > > > + u8 offset; > > > > > > + > > > > > > + /* > > > > > > + * DAI clock polarity > > > > > > + * > > > > > > + * The setup for LRCK contradicts the datasheet, but unde= r a > > > > > > + * scope it's clear that the LRCK polarity is reversed > > > > > > + * compared to the expected polarity on the bus. > > > > > > + */ > > > > > > > > > > Did you check this or has it been copy-pasted? > > > > > > > > copy-pasted, I will check this. > > > > > > It's not going to be easy to do this if you only have a board with HD= MI. If you > > > can't test that easily, just remove the comment (or make it explicit = that you > > > copy pasted it?), no comment is better than a wrong one. > > > > I have talked with Marcus Cooper it may be able to test this this week-= end. > > Also this can explain why we need the " > > simple-audio-card,frame-inversion;" in the device-tree. > > > > If think this fix has been introduced by you, correct? Could you say > > on which SoC did you see this issue? > > This was seen on an H3 Just two more questions: - Did you observe this issue on both TDM and I2S mode? - On which DAI node? Since recent change in sun4i-i2s.c, we had to introduce the "simple-audio-card,frame-inversion" in LibreElec tree. H3 boards are quite common in LibreElec community so I think: - This fix is only needed in TDM mode - Or this fix is not required for the HDMI DAI node (HDMI DAI is a little bit different compare to other DAI but I think the first guess is more likely) Regards, Clement > > Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DD7C28CBC for ; Thu, 30 Apr 2020 14:00:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CB57206D9 for ; Thu, 30 Apr 2020 14:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YwNRxO3X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wxsmkjon" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB57206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+CtoYs/eLJuqrzB8DxIssx75i478o5dQ+h7TriFeykQ=; b=YwNRxO3XmID1ec dxZ6ikqIejsTwfJB/LwKe7S6vhSMBgmpPXuy3CCvZmqfxHBY6sqFBrqKtKHpRMlY8HEVpEJw+hWzp 8oAiDJOuPdCFrIGp1ZTyuqcYpHusAqS2vl6FsN21a+4W1YLspM9v31CRDs/96weigGF19wLN2y2xn ncrs0GlVUW4yAyAE3PeVuOXuljxBzKZyZSWLC97d0fVUu9sSjm82xZ2Z3R0VoKrTGBOo9tNcj/FF/ dQnVOY5rDreizkSPSJmuoPOczzQsSc2evFKhYvs0o4PqLINa0dxldaVQC+P1u+7p6dSfKW4P5h1Bh lpthUTIlGa68R4vscp0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU9jr-0003Lx-Ip; Thu, 30 Apr 2020 14:00:31 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU9jo-0003Js-HM for linux-arm-kernel@lists.infradead.org; Thu, 30 Apr 2020 14:00:29 +0000 Received: by mail-io1-xd43.google.com with SMTP id k23so1554036ios.5 for ; Thu, 30 Apr 2020 07:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=WxsmkjonITcLJ97YhEvjgmBobJxYhdcS0FMYbI0ha9eAYIbOvVa++0B/N61OFuA+vq TZYJoOOK1ZCNtDRuUb0+F6GjgICAVNM5rw4vEuVnM80xd3VkxSFGCpu0bX2tf4mdswgH D8T/Hct4kccVa1z5uGmKgC3cbV8W5/BGPIlISHzo6yjyI6Yd84kp1sl1eFHyPTD6GGmH 0Q1F1IZODwzZhcHFUAcQpScBz+tK/gV6IwRa2pAu8aiuKxSgJ9XM9CrOeEgOUpJR6Mg0 6oYATFOQutPCYugnCrV+5/HZ8KiRd7lgTda3lkj13rjmdcAeGR16UBPZIBdRZZnJts6f Vuww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nz4EYudAGnRAka2sLpxAUHkI/tIzbc4FpKMb2iD2HGI=; b=Fac4QjUNDh2CUJ2Pqhs+PjCnIPXZo9ZZMYIkjtNqB1uUT7fBtkc3REvd/ri9iRQ5s1 xYg/vAPNS12U1Sph6n1oKpLAY49nSV17c9RBYB37MnUddAAlU+Pi+GEHJ0PDw7BOkelV tasj2p0n5dYKgJlWOl5typ8p8N7rqWXtpXTvXtdCWSJQYfxAie5tv9a3fXpyEgKhwvBP 7GoVuuEp3c49aQxgsZrnnK/BiPbswUwNU4ABjKJ6banf2kVWV1QsXi3ePDY41b6DspPJ SD+4Lgnvzhfr43BcaDls0DCzDJfwvvq3RmP2XRkLiOMJNLXrTxvZHjChMh0vQ+I6YMjB /V1w== X-Gm-Message-State: AGi0PuYklj5czimkdPnfEByWUncmRzJXIu1k/EsK6Gh2Dop3XEQAR7RZ 9rvnHZhz9YC8Hn3RVWk9DIWnETl+lwNXLoBwXzjPC2hQnPM= X-Google-Smtp-Source: APiQypL/hGXbUxNw4AVM3ITxY+bWgZQNGgI8BdvnXtQMrcBmjvMtXdgrG7Lhm8mMQi0TVyWgoYz+zdbaXKGpRu9prEA= X-Received: by 2002:a6b:b8d6:: with SMTP id i205mr2058871iof.123.1588255225316; Thu, 30 Apr 2020 07:00:25 -0700 (PDT) MIME-Version: 1.0 References: <20200426104115.22630-1-peron.clem@gmail.com> <20200426104115.22630-4-peron.clem@gmail.com> <20200428081321.ht3el26yqhsnyfm4@gilmour.lan> <20200429123529.y24dpy63wxq7uvkt@gilmour.lan> <20200430084600.samghw4zxb5zdbez@gilmour.lan> In-Reply-To: <20200430084600.samghw4zxb5zdbez@gilmour.lan> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 30 Apr 2020 16:00:14 +0200 Message-ID: Subject: Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_070028_596388_D453CC6E X-CRM114-Status: GOOD ( 23.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linux-ALSA , linux-kernel , Jernej Skrabec , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , Chen-Yu Tsai , Mark Brown , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWF4aW1lLAoKT24gVGh1LCAzMCBBcHIgMjAyMCBhdCAxMDo0NiwgTWF4aW1lIFJpcGFyZCA8 bWF4aW1lQGNlcm5vLnRlY2g+IHdyb3RlOgo+Cj4gSGksCj4KPiBPbiBXZWQsIEFwciAyOSwgMjAy MCBhdCAwNjozMzowMFBNICswMjAwLCBDbMOpbWVudCBQw6lyb24gd3JvdGU6Cj4gPiBPbiBXZWQs IDI5IEFwciAyMDIwIGF0IDE0OjM1LCBNYXhpbWUgUmlwYXJkIDxtYXhpbWVAY2Vybm8udGVjaD4g d3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFR1ZSwgQXByIDI4LCAyMDIwIGF0IDEwOjU1OjQ3QU0gKzAy MDAsIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+ID4gPiA+ID4gK3N0YXRpYyBpbnQgc3VuNTBp X2kyc19zZXRfc29jX2ZtdChjb25zdCBzdHJ1Y3Qgc3VuNGlfaTJzICppMnMsCj4gPiA+ID4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZm10KQo+ID4gPiA+ ID4KPiA+ID4gPiA+IFRoZSBhbGlnbm1lbnQgaXMgb2ZmIGhlcmUKPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ICt7Cj4gPiA+ID4gPiA+ICsgICAgIHUzMiBtb2RlLCB2YWw7Cj4gPiA+ID4gPiA+ICsgICAg IHU4IG9mZnNldDsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICAgICAvKgo+ID4gPiA+ID4g PiArICAgICAgKiBEQUkgY2xvY2sgcG9sYXJpdHkKPiA+ID4gPiA+ID4gKyAgICAgICoKPiA+ID4g PiA+ID4gKyAgICAgICogVGhlIHNldHVwIGZvciBMUkNLIGNvbnRyYWRpY3RzIHRoZSBkYXRhc2hl ZXQsIGJ1dCB1bmRlciBhCj4gPiA+ID4gPiA+ICsgICAgICAqIHNjb3BlIGl0J3MgY2xlYXIgdGhh dCB0aGUgTFJDSyBwb2xhcml0eSBpcyByZXZlcnNlZAo+ID4gPiA+ID4gPiArICAgICAgKiBjb21w YXJlZCB0byB0aGUgZXhwZWN0ZWQgcG9sYXJpdHkgb24gdGhlIGJ1cy4KPiA+ID4gPiA+ID4gKyAg ICAgICovCj4gPiA+ID4gPgo+ID4gPiA+ID4gRGlkIHlvdSBjaGVjayB0aGlzIG9yIGhhcyBpdCBi ZWVuIGNvcHktcGFzdGVkPwo+ID4gPiA+Cj4gPiA+ID4gY29weS1wYXN0ZWQsIEkgd2lsbCBjaGVj ayB0aGlzLgo+ID4gPgo+ID4gPiBJdCdzIG5vdCBnb2luZyB0byBiZSBlYXN5IHRvIGRvIHRoaXMg aWYgeW91IG9ubHkgaGF2ZSBhIGJvYXJkIHdpdGggSERNSS4gSWYgeW91Cj4gPiA+IGNhbid0IHRl c3QgdGhhdCBlYXNpbHksIGp1c3QgcmVtb3ZlIHRoZSBjb21tZW50IChvciBtYWtlIGl0IGV4cGxp Y2l0IHRoYXQgeW91Cj4gPiA+IGNvcHkgcGFzdGVkIGl0PyksIG5vIGNvbW1lbnQgaXMgYmV0dGVy IHRoYW4gYSB3cm9uZyBvbmUuCj4gPgo+ID4gSSBoYXZlIHRhbGtlZCB3aXRoIE1hcmN1cyBDb29w ZXIgaXQgbWF5IGJlIGFibGUgdG8gdGVzdCB0aGlzIHRoaXMgd2Vlay1lbmQuCj4gPiBBbHNvIHRo aXMgY2FuIGV4cGxhaW4gd2h5IHdlIG5lZWQgdGhlICIKPiA+IHNpbXBsZS1hdWRpby1jYXJkLGZy YW1lLWludmVyc2lvbjsiIGluIHRoZSBkZXZpY2UtdHJlZS4KPiA+Cj4gPiBJZiB0aGluayB0aGlz IGZpeCBoYXMgYmVlbiBpbnRyb2R1Y2VkIGJ5IHlvdSwgY29ycmVjdD8gQ291bGQgeW91IHNheQo+ ID4gb24gd2hpY2ggU29DIGRpZCB5b3Ugc2VlIHRoaXMgaXNzdWU/Cj4KPiBUaGlzIHdhcyBzZWVu IG9uIGFuIEgzCgpKdXN0IHR3byBtb3JlIHF1ZXN0aW9uczoKLSBEaWQgeW91IG9ic2VydmUgdGhp cyBpc3N1ZSBvbiBib3RoIFRETSBhbmQgSTJTIG1vZGU/Ci0gT24gd2hpY2ggREFJIG5vZGU/CgpT aW5jZSByZWNlbnQgY2hhbmdlIGluIHN1bjRpLWkycy5jLCB3ZSBoYWQgdG8gaW50cm9kdWNlIHRo ZQoic2ltcGxlLWF1ZGlvLWNhcmQsZnJhbWUtaW52ZXJzaW9uIiBpbiBMaWJyZUVsZWMgdHJlZS4K SDMgYm9hcmRzIGFyZSBxdWl0ZSBjb21tb24gaW4gTGlicmVFbGVjIGNvbW11bml0eSBzbyBJIHRo aW5rOgogLSBUaGlzIGZpeCBpcyBvbmx5IG5lZWRlZCBpbiBURE0gbW9kZQogLSBPciB0aGlzIGZp eCBpcyBub3QgcmVxdWlyZWQgZm9yIHRoZSBIRE1JIERBSSBub2RlIChIRE1JIERBSSBpcyBhCmxp dHRsZSBiaXQgZGlmZmVyZW50IGNvbXBhcmUgdG8gb3RoZXIgREFJIGJ1dCBJIHRoaW5rIHRoZSBm aXJzdCBndWVzcwppcyBtb3JlIGxpa2VseSkKClJlZ2FyZHMsCkNsZW1lbnQKCj4KPiBNYXhpbWUK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK