From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0876C47089 for ; Thu, 27 May 2021 08:57:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1D11613CA for ; Thu, 27 May 2021 08:57:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1D11613CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D82781DB3; Thu, 27 May 2021 10:57:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="gIjVwJP/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C390E8200B; Thu, 27 May 2021 10:57:34 +0200 (CEST) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D50EC804B9 for ; Thu, 27 May 2021 10:57:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=green.wan@sifive.com Received: by mail-qv1-xf35.google.com with SMTP id e8so2207310qvp.7 for ; Thu, 27 May 2021 01:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IQVaOZcyVgdSf8wvs2V67FAzvJBk0Bg8gbzx6xI+2gA=; b=gIjVwJP/qoWCmMcMTL8kc/IXqOUNe7HQdNcQSPNTTfGv4fdVZvoOCofQKl20uDObqV MU5rVekCuU6htkYTMz15zz3e3W4EpUyNJO7bTjdulCIurip/a+1H7vv2orrB9E2cx7IQ 2tJhq30qcfj6svex12N+R717jpbK45qszD0IJlYOtJrjh5KQZxodGMHm3vLGVZvoI6qX 0IBHGlx/cayWv2VvqYBapcr7KjGRwN5remvtNUnV5GVObCjIhfHlpMF3vW7BTGrfIW2w a9d90ApN0WPZHaGJhuoeF+a+s8x+Nk1UyOBDg1uu3DrZKyLENiI1qAdIHBpQX81jLjQq Y3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IQVaOZcyVgdSf8wvs2V67FAzvJBk0Bg8gbzx6xI+2gA=; b=ZnSzy9IwKiRXIP+gFdJvEYK1BS+2G1SJuR0eteyw8b4aCWxRW+ya1agYfl6ZMSREYN 1ORi/3iD6BoZVJZqdySikg9yFdQQGc7ZmQuLy6nh1FF6FqJdCnGNX88cY/X9k/iXmEGI cvgGV+uj2o9UnLDWGXUa2jW7hPZnvtvMI24/+WH+1+nOARsAdcHQja1HgoujbmwDyPk/ EBHIImeBI+s7qZ8TbPnp/6Td+phI3ebTcxiiOmmPakS+jATzqhb43VySgZ65xXJIJWbq efaTDYVjvPiDudvZke21qZPQLLkoavzq4etww/FL5B8P/pR723iu4ZUePLMYgwNI6Nt6 QRZg== X-Gm-Message-State: AOAM533DMd1GpNbtEFGIEaTu5fMD0AzjZhn9KN3wVq4kdsFXtYg0w5Yu zgont+9epkheJrHvPDeiJeWk+EazF25wvp9PPioj2w== X-Google-Smtp-Source: ABdhPJwfgPfcnlcVUldvND/FWGJkUhR7W/ZWR0zYmrhbAUPIkKtj4nvu+CfNttwYbdfTShuwxwp3OsiNkednZg7U9L0= X-Received: by 2002:a05:6214:212f:: with SMTP id r15mr2710546qvc.11.1622105849587; Thu, 27 May 2021 01:57:29 -0700 (PDT) MIME-Version: 1.0 References: <20210526081249.GA19414@andestech.com> <20210526152435.GF17669@bill-the-cat> In-Reply-To: <20210526152435.GF17669@bill-the-cat> From: Green Wan Date: Thu, 27 May 2021 16:57:17 +0800 Message-ID: Subject: Re: [PULL] u-boot-riscv/master To: Tom Rini Cc: Leo Liang , Rick Chen , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Tom, Thanks for the comments. Not sure whether it catches different concerns, I plan to remove fdt_high and initrd_high since the bootm_* settings should be sufficient to calculate the values related to fdt_high and initrd_high. And I checked the bootm_* settings as below, the system can boot without fdt_high and initrd_high. - bootm_low is set to CONFIG_SYS_SDRAM_BASE - bootm_size is set to gd->ram_size (which comes from DT) - bootm_mapsize is now equal to bootm_size - boot log without fdt_high and initrd_high "## Flattened Device Tree blob at 88000000 Booting using the fdt blob at 0x88000000 Loading Device Tree to 00000000ffffa000, end 00000000fffff64d ... OK" Hi Leo/Rick, Should I create v12 for fu740 series patchset based on u-boot-riscv.git ? or revert [PATCH v11 7/8] plus a patch? Thanks a lot! Regards, Green On Wed, May 26, 2021 at 11:24 PM Tom Rini wrote: > On Wed, May 26, 2021 at 04:12:50PM +0800, Leo Liang wrote: > > > Hi Tom, > > > > The following changes since commit > eb53b943be2949ca111140a8e05532cd74cda058: > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-sh (2021-05-23 > 10:15:15 -0400) > > > > are available in the Git repository at: > > > > git@source.denx.de:u-boot/custodians/u-boot-riscv.git > > > > for you to fetch changes up to 9358576a281ab5e3b7348685bbd5f713833a5048: > > > > drivers: pci: pcie_dw_common: fix Werror compilation error (2021-05-24 > 23:54:54 +0800) > > > > Gitlab CI result shows no issue: > https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/7620 > > > > NAK. > ERROR: fdt or initrd relocation disabled at boot time > #993: FILE: include/configs/sifive-unmatched.h:65: > + "fdt_high=0xffffffffffffffff\0" \ > > ERROR: fdt or initrd relocation disabled at boot time > #994: FILE: include/configs/sifive-unmatched.h:66: > + "initrd_high=0xffffffffffffffff\0" \ > > You can, but shouldn't disable initrd relocation. You cannot disable > device tree relocation as that leads to too many issues due to > misalignment later. Make use of bootm_size or similar to make sure > everything is within an appropriate area of memory. Thanks. > > -- > Tom >