All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tomasz Dziendzielski" <tomasz.dziendzielski@gmail.com>
To: Konrad Weihmann <kweihmann@outlook.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order
Date: Thu, 11 Feb 2021 11:30:02 +0100	[thread overview]
Message-ID: <CAJkqNs21=9-B-oWU4AqLSLKZ9286N5UgoXNr7Smxr3+PqgZdVw@mail.gmail.com> (raw)
In-Reply-To: <AM9PR09MB46421810B3B2B59AAB545357A88C9@AM9PR09MB4642.eurprd09.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

>After this patch got merged I notice some "noise" in my builds.
>
>For bbappends which inherit unrelated classes I get a lot of warning like
>
>Issue: nativesdk-openssh: native/nativesdk class is not inherited last,
>this can result in unexpected behaviour. Classes inherited after
>native/nativesdk: my-custom-class.bbclass [native-last]
>
>First it doesn't give any hint that this is caused by the bbappend and
>secondly I have no idea how to fix that (if that is even possible).
>
>So I would like to have at least an option to ignore these warnings for
>classes I'm sure don't cause any conflict - something more granular then
>just to deactivate this pretty useful check.
>
>Thoughts?

I think it's a good idea to just ignore specific classes. The diff below
should be enough, with some additional note in the warning message. I'll
check if it works correctly later today.

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 53230fc667..2f53a9be09 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1381,6 +1381,10 @@ python () {
                     # native also inherits nopackages and relocatable
bbclasses
                     skip_classes.extend(['nopackages', 'relocatable'])

+                extra_skip_classes =
(d.getVar('NATIVE_LAST_IGNORE_CLASSES') or '').split()
+                if extra_skip_classes:
+                    skip_classes.extend(extra_skip_classes)
+
                 broken_order = []
                 for class_item in reversed(inherited_classes):
                     if needle not in class_item:

Best regards,
Tomasz Dziendzielski

[-- Attachment #2: Type: text/html, Size: 2056 bytes --]

  reply	other threads:[~2021-02-11 10:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24  9:55 [PATCH 1/2] insane: Add test for native/nativesdk inherit order Tomasz Dziendzielski
2021-01-24  9:55 ` [PATCH 2/2] meta: Fix native inheritance order in recipes Tomasz Dziendzielski
2021-01-27 19:11 ` [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order Martin Jansa
2021-01-27 19:54   ` Tomasz Dziendzielski
     [not found]   ` <165E2EBA5493813B.12137@lists.openembedded.org>
2021-01-27 21:36     ` Tomasz Dziendzielski
2021-02-11  7:21 ` Konrad Weihmann
2021-02-11 10:30   ` Tomasz Dziendzielski [this message]
2021-02-12 18:26     ` Peter Kjellerstedt
2021-02-12 23:12       ` Richard Purdie
2021-02-11 11:43   ` Richard Purdie
2021-02-11 12:10     ` Konrad Weihmann
2021-02-11 13:04       ` Richard Purdie
2021-02-11 14:47         ` Konrad Weihmann
2021-02-11 14:59           ` Richard Purdie
2021-02-11 15:12             ` Konrad Weihmann
     [not found]             ` <1662BA34B045612A.24722@lists.openembedded.org>
2021-02-22  9:31               ` Konrad Weihmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJkqNs21=9-B-oWU4AqLSLKZ9286N5UgoXNr7Smxr3+PqgZdVw@mail.gmail.com' \
    --to=tomasz.dziendzielski@gmail.com \
    --cc=kweihmann@outlook.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.