2013/4/2 Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>

dev_queue_xmit() can return positive error codes, so check for nonzero.

Signed-off-by: Alan Ott <alan@signal11.us>
---
net/ieee802154/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index e1b4580..a68c792 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -1139,7 +1139,7 @@ static netdev_tx_t lowpan_xmit(struct sk_buff *skb, struct net_device *dev)
error:
dev_kfree_skb(skb);
out:
- if (err < 0)
+ if (err)

lets say ok....

pr_debug("ERROR: xmit failed\n");

return (err < 0 ? NETDEV_TX_BUSY : NETDEV_TX_OK);

but here you still checks for negative error only, why?

--
1.7.11.2