From: liu ping fan <qemulist@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum
Date: Thu, 9 May 2013 17:05:01 +0800 [thread overview]
Message-ID: <CAJnKYQkKDFGqNr_Ws3urbyLdEwF8ychpvxvCn_nqAtVA9okfgQ@mail.gmail.com> (raw)
In-Reply-To: <20130509083141.GI1074@stefanha-thinkpad.redhat.com>
On Thu, May 9, 2013 at 4:31 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Thu, May 09, 2013 at 08:40:22AM +0800, Liu Ping Fan wrote:
>> diff --git a/include/exec/memory.h b/include/exec/memory.h
>> index 9e88320..77e0d40 100644
>> --- a/include/exec/memory.h
>> +++ b/include/exec/memory.h
>> @@ -192,6 +192,16 @@ struct MemoryRegionSection {
>>
>> typedef struct MemoryListener MemoryListener;
>>
>> +/* The list of priority, ex, vhost should have higher priority (less num) than
>> + * kvm, ie PRI_VRING < PRI_HYPV
>
> s/PRI_HYPV/PRI_HYPERV/
>
Will fix.
>> + */
>> +typedef enum {
>> + PRI_DEFAULT = 0,
>> + PRI_CORE = 1,
>> + PRI_VRING = 9,
>> + PRI_HYPERV = 10,
>
> HYPERV == hypervisor? Easy to confuse with Microsoft Hyper-V. Please
> use PRI_ACCEL or PRI_HYPERVISOR.
Ok.
Regards,
Pingfan
next prev parent reply other threads:[~2013-05-09 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 0:40 [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm Liu Ping Fan
2013-05-09 0:40 ` [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum Liu Ping Fan
2013-05-09 8:31 ` Stefan Hajnoczi
2013-05-09 9:05 ` liu ping fan [this message]
2013-05-09 9:21 ` Peter Maydell
2013-05-09 9:30 ` liu ping fan
2013-05-09 8:30 ` [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm Stefan Hajnoczi
2013-05-09 9:00 ` liu ping fan
2013-05-09 15:26 ` Stefan Hajnoczi
2013-05-10 6:03 ` liu ping fan
2013-05-10 7:12 ` Stefan Hajnoczi
2013-05-10 9:04 ` liu ping fan
2013-05-09 8:44 ` Michael S. Tsirkin
2013-05-09 8:54 ` liu ping fan
2013-05-09 14:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJnKYQkKDFGqNr_Ws3urbyLdEwF8ychpvxvCn_nqAtVA9okfgQ@mail.gmail.com \
--to=qemulist@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.