All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev <netdev@vger.kernel.org>, Martin KaFai Lau <kafai@fb.com>,
	David Miller <davem@davemloft.net>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>
Subject: Re: [PATCH net] Revert "net: Add a second bind table hashed by port and address"
Date: Thu, 16 Jun 2022 10:41:05 -0700	[thread overview]
Message-ID: <CAJnrk1YnGssapE0HCiwLd9DqDULVytYGT_TTqPJyXz1pRO5HtA@mail.gmail.com> (raw)
In-Reply-To: <CANn89iJeXRnb5VPMgFatfn8v8OPRh7riwkhg33XWCGg6tusenw@mail.gmail.com>

On Thu, Jun 16, 2022 at 10:29 AM Eric Dumazet <edumazet@google.com> wrote:
>
> On Thu, Jun 16, 2022 at 7:18 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Thu, 16 Jun 2022 12:01:36 +0200 Paolo Abeni wrote:
> > > > Do we really need to remove the test ? It is a benchmark, and should
> > > > not 'fail' on old kernels.
> > >
> > > I agree it's nice to keep the self-test alive.
> > >
> > > Side notes, not strictly related to the revert: the self test is not
> > > currently executed by `make run_tests` and requires some additional
> > > setup: ulimit -n <high number>, 2001:db8:0:f101::1 being a locally
> > > available address, and a mandatory command line argument.
> > >
> > > @Joanne: you should additionally provide a wrapper script to handle the
> > > above and update TEST_PROGS accordingly. As for this revert, could you
> > > please re-post it touching the kernel code only?
> >
> > Let me take the revert in for today's PR. Hope that's okay. We can
> > revive the test in -next with the wrapper/setup issue addressed.
> > I don't want more people to waste time bisecting the warnings this
> > generates.
I'll make sure to include a wrapper script when I resubmit it.
>
> Note we have missing Reported-... tags to please syzbot.
Jakub, please let me know if you want me to resubmit v2 of this with
the Reported- tag added, or if you'll add that part in.

  reply	other threads:[~2022-06-16 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 19:32 [PATCH net] Revert "net: Add a second bind table hashed by port and address" Joanne Koong
2022-06-16  6:24 ` Eric Dumazet
2022-06-16 10:01   ` Paolo Abeni
2022-06-16 17:18     ` Jakub Kicinski
2022-06-16 17:28       ` Eric Dumazet
2022-06-16 17:41         ` Joanne Koong [this message]
2022-06-16 17:41         ` Jakub Kicinski
2022-06-16 17:57           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJnrk1YnGssapE0HCiwLd9DqDULVytYGT_TTqPJyXz1pRO5HtA@mail.gmail.com \
    --to=joannelkoong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kafai@fb.com \
    --cc=kuba@kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.