From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"kafai@fb.com" <kafai@fb.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [PATCH net] virtio_net: reject XDP programs using header adjustment
Date: Mon, 19 Dec 2016 15:42:24 +0000 [thread overview]
Message-ID: <CAJpBn1yCHOLRYs2p4-YBYG5q3omynWkB7=5ZvoND_ULhHNv0Qw@mail.gmail.com> (raw)
In-Reply-To: <BL2PR07MB2306FB78FBB5F2D17681699D8D910@BL2PR07MB2306.namprd07.prod.outlook.com>
On Mon, Dec 19, 2016 at 3:23 PM, Mintz, Yuval <Yuval.Mintz@cavium.com> wrote:
>> commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog")
>> added a new XDP helper to prepend and remove data from a frame.
>> Make virtio_net reject programs making use of this helper until proper
>> support is added.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>
> Is that how it goes until we'll add the proper infrastructure?
> Am I expected to provide the same for qede?
I asked Martin to fix the existing drivers like qede but virtio's XDP
was not merged at that point.
> I was under the impression that so long as this is being [early] developed
> and there's no way to communicate what is and isn't supported by
> a given implementation, it would simply be the user's responsibility
> to make sure what he's trying is supported.
IMHO the less user has to guess the better if we're hoping for wide adoption.
next prev parent reply other threads:[~2016-12-19 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 15:05 [PATCH net] virtio_net: reject XDP programs using header adjustment Jakub Kicinski
2016-12-19 15:23 ` Mintz, Yuval
2016-12-19 15:42 ` Jakub Kicinski [this message]
2016-12-19 17:50 ` John Fastabend
2016-12-19 20:08 ` David Miller
2016-12-20 12:30 ` Jakub Kicinski
2016-12-23 18:44 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJpBn1yCHOLRYs2p4-YBYG5q3omynWkB7=5ZvoND_ULhHNv0Qw@mail.gmail.com' \
--to=jakub.kicinski@netronome.com \
--cc=Yuval.Mintz@cavium.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.