From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F418AC43470 for ; Mon, 10 May 2021 13:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1E56613CD for ; Mon, 10 May 2021 13:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240780AbhEJNXG (ORCPT ); Mon, 10 May 2021 09:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343658AbhEJMOI (ORCPT ); Mon, 10 May 2021 08:14:08 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E772C0612EA for ; Mon, 10 May 2021 05:07:08 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2so22978117lft.4 for ; Mon, 10 May 2021 05:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QvZsXwdzWair1nAvybVvnt+mffaSYKaI0smFVVcSaM8=; b=Xf9IAnDVO23XTX3sypiGCiiSTxeA9Uybsy6g5IM+NzeNeGZxnSFRuu33qdMR39T2hg IGha8lO56UgkP+7zN5ega6jl6zd6eZJ9bLdObGCRHcN7vu+4wwzwCVH5YdPEqefwqHcD SKDr04Q7OE91oFsgi6sgcFGoNAG1qeqRNGV8I7yFaZyVactJW77+YAP9tmRfC9L1seOG 2fBJg7x7+0HUkH70QkDIGy34iPloq4R7fxI9VFjgdxtYkXoDlF+Dzpek97Rhmhcj8u2f DPZVyhq1W31v2lowdwSY87S4fj9Z0nwdu9zYR9EiQv7uToUswwpwzKl7dImkkcy3L2yU 0WLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QvZsXwdzWair1nAvybVvnt+mffaSYKaI0smFVVcSaM8=; b=Jh7kF8iQrZN8ksLsQAGYC9ALptEvpxb1krqS73agWs1sW0vd/OgNwe/n/JRtgg/w/R 0RD42a+P8e5F+Sy4oUeFtFpD0sEJYQOH9DmvKFChsOnh29cz7oRKb5hkiiSkYFQXqOZu C32YFwbInDmbDO8fFsKKslPBpdTDSnkFve+OvF3xrusyuT7/5lv8hCXye6+hya6uParu uZck6ntFaiXXWZ5emXrrPy7q4mJpDWzzBE/RyvLHv43OktZs1RtH3TG9nMVJfJMQ88go DLdPMoMge/Drg7undAzY5+6cRoOwOPAPStlI5pCAYMuuHjXPvnkWlVZ6gMFwPbHcdeQQ QmGg== X-Gm-Message-State: AOAM5303RolBkLqPvndNH6vKKripHNWWx8PhGi84jPRisonFRWUEVpEj j4Xt2VQcmmAIDfPnkm5/IX7hiumClE6a0bx5JcJewQ== X-Google-Smtp-Source: ABdhPJxHMIMSwGujHeovQDXLF5mCz5AI4ncOEkje56YJkefAlsUYfKrtgWBhwbrt0nH36Me7JJYP3F4L7CZ79s3T4V0= X-Received: by 2002:ac2:5631:: with SMTP id b17mr16178232lff.58.1620648426660; Mon, 10 May 2021 05:07:06 -0700 (PDT) MIME-Version: 1.0 References: <20210503114818.288896-1-gi-oh.kim@ionos.com> <20210503114818.288896-4-gi-oh.kim@ionos.com> In-Reply-To: From: Haris Iqbal Date: Mon, 10 May 2021 14:06:55 +0200 Message-ID: Subject: Re: [PATCH for-next 03/20] RDMA/rtrs-clt: No need to check queue_depth when receiving To: Leon Romanovsky Cc: Gioh Kim , linux-rdma@vger.kernel.org, bvanassche@acm.org, Doug Ledford , Jason Gunthorpe , Jinpu Wang , Gioh Kim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, May 10, 2021 at 1:53 PM Leon Romanovsky wrote: > > On Mon, May 10, 2021 at 01:00:33PM +0200, Haris Iqbal wrote: > > On Sun, May 9, 2021 at 1:24 PM Leon Romanovsky wrote: > > > > > > On Mon, May 03, 2021 at 01:48:01PM +0200, Gioh Kim wrote: > > > > From: Gioh Kim > > > > > > > > The queue_depth size is sent from server and > > > > server already checks validity of the value. > > > > > > Do you trust server? What will be if server is not reliable and sends > > > garbage? > > > > Hi Leon, > > > > The server code checks for the queue_depth before sending. If the > > server is really running malicious code, then the queue_depth is the > > last thing that the client needs to worry about. > > Like what? for an example? Like accessing compromised block devices. If the queue_depth is garbage, the client would fail at allocation with ENOMEM; thats it. > > Thanks