* [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus
@ 2022-05-23 1:32 Luiz Angelo Daros de Luca
2022-05-23 1:44 ` Luiz Angelo Daros de Luca
2022-05-23 11:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-05-23 1:32 UTC (permalink / raw)
To: netdev
Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, edumazet,
kuba, pabeni, Luiz Angelo Daros de Luca
If found, register the DSA internally allocated slave_mii_bus with an OF
"mdio" child object. It can save some drivers from creating their
custom internal MDIO bus.
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/dsa2.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index d0a2452a1e24..cac48a741f27 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -13,6 +13,7 @@
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
+#include <linux/of_mdio.h>
#include <linux/of_net.h>
#include <net/devlink.h>
#include <net/sch_generic.h>
@@ -852,6 +853,7 @@ static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds)
static int dsa_switch_setup(struct dsa_switch *ds)
{
struct dsa_devlink_priv *dl_priv;
+ struct device_node *dn;
struct dsa_port *dp;
int err;
@@ -907,7 +909,10 @@ static int dsa_switch_setup(struct dsa_switch *ds)
dsa_slave_mii_bus_init(ds);
- err = mdiobus_register(ds->slave_mii_bus);
+ dn = of_get_child_by_name(ds->dev->of_node, "mdio");
+
+ err = of_mdiobus_register(ds->slave_mii_bus, dn);
+ of_node_put(dn);
if (err < 0)
goto free_slave_mii_bus;
}
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus
2022-05-23 1:32 [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
@ 2022-05-23 1:44 ` Luiz Angelo Daros de Luca
2022-05-23 11:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-05-23 1:44 UTC (permalink / raw)
To: open list:NETWORKING DRIVERS
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring
In the last attempt, this patch was part of a doc+net series. However,
Rob Herring NAKed the binding patch as we cannot define a "mdio" node
in dsa.yaml without breaking anyone who references dsa.yaml to need to
redefine/specialize that same node.
https://lore.kernel.org/lkml/Yhfmi2Mn6e0NMXh3@robh.at.kernel.org/
So, the generic slave "mdio" node must be declared on each device that
might use it in the future.
Regards,
Luiz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus
2022-05-23 1:32 [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
2022-05-23 1:44 ` Luiz Angelo Daros de Luca
@ 2022-05-23 11:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-23 11:30 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: netdev, andrew, vivien.didelot, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Sun, 22 May 2022 22:32:34 -0300 you wrote:
> If found, register the DSA internally allocated slave_mii_bus with an OF
> "mdio" child object. It can save some drivers from creating their
> custom internal MDIO bus.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next,RESEND] net: dsa: OF-ware slave_mii_bus
https://git.kernel.org/netdev/net-next/c/fe7324b93222
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-23 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 1:32 [PATCH net-next RESEND] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
2022-05-23 1:44 ` Luiz Angelo Daros de Luca
2022-05-23 11:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.